From: Nikolay Kulikov <nikolayof23@gmail.com>
To: Francisco Maestre <francisco@maestretorreblanca.com>
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] staging: rtl8723bs: remove unnecessary braces in sdio_intf.c
Date: Sun, 3 May 2026 12:58:14 +0300 [thread overview]
Message-ID: <afccNlRpYCowTwah@archlinux> (raw)
In-Reply-To: <20260503004144.66733-1-francisco@maestretorreblanca.com>
On Sat, May 02, 2026 at 07:41:44PM -0500, Francisco Maestre wrote:
> Remove braces around a single-statement block in the SDIO
> disconnect path, as per kernel coding style guidelines.
>
> This fixes the following checkpatch.pl warning:
> WARNING: braces {} are not necessary for single statement blocks
>
> Signed-off-by: Francisco Maestre <francisco@maestretorreblanca.com>
> ---
> drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
> index d664e254912c..a86252ccac76 100644
> --- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
> +++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
> @@ -146,9 +146,8 @@ static void sdio_deinit(struct dvobj_priv *dvobj)
> sdio_claim_host(func);
> sdio_disable_func(func);
>
> - if (dvobj->irq_alloc) {
> + if (dvobj->irq_alloc)
> sdio_release_irq(func);
> - }
>
> sdio_release_host(func);
> }
> --
> 2.50.1 (Apple Git-155)
>
>
This is already fixed in staging-next.
Thanks,
Nikolay
prev parent reply other threads:[~2026-05-03 9:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-03 0:41 [PATCH 2/3] staging: rtl8723bs: remove unnecessary braces in sdio_intf.c Francisco Maestre
2026-05-03 9:58 ` Nikolay Kulikov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afccNlRpYCowTwah@archlinux \
--to=nikolayof23@gmail.com \
--cc=francisco@maestretorreblanca.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.