From: "Christoph Lameter (Ampere)" <cl@linux.com>
To: Huang Shijie <shijie@os.amperecomputing.com>
Cc: kuba@kernel.org, patches@amperecomputing.com,
davem@davemloft.net, horms@kernel.org, edumazet@google.com,
ast@kernel.org, dhowells@redhat.com, linyunsheng@huawei.com,
aleksander.lobakin@intel.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, cl@os.amperecomputing.com
Subject: Re: [PATCH v2] net: skbuff: set FLAG_SKB_NO_MERGE for skbuff_fclone_cache
Date: Thu, 29 Feb 2024 08:56:20 -0800 (PST) [thread overview]
Message-ID: <afcf367f-5b33-5249-ad85-2addede18dc5@linux.com> (raw)
In-Reply-To: <20240227062833.7404-1-shijie@os.amperecomputing.com>
On Tue, 27 Feb 2024, Huang Shijie wrote:
> Since we do not set FLAG_SKB_NO_MERGE for skbuff_fclone_cache,
> the current skbuff_fclone_cache maybe not really allocated, it maybe
> used an exist old kmem_cache. In NUMA, the fclone allocated by
> alloc_skb_fclone() maybe in remote node.
This is not the right approach. If you want to force a local allocation
you need to use GFP_THISNODE. Merging has nothing to do with locality.
next prev parent reply other threads:[~2024-02-29 16:56 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-20 2:18 [PATCH] net: skbuff: allocate the fclone in the current NUMA node Huang Shijie
2024-02-20 5:32 ` Eric Dumazet
2024-02-20 6:26 ` Shijie Huang
2024-02-20 8:17 ` Eric Dumazet
2024-02-20 8:37 ` Shijie Huang
2024-02-24 19:07 ` Eric Dumazet
2024-02-26 10:18 ` Jesper Dangaard Brouer
2024-02-26 10:29 ` Eric Dumazet
2024-02-27 6:28 ` [PATCH v2] net: skbuff: set FLAG_SKB_NO_MERGE for skbuff_fclone_cache Huang Shijie
2024-02-27 12:55 ` Eric Dumazet
2024-02-27 13:15 ` Eric Dumazet
2024-02-28 7:05 ` Shijie Huang
2024-02-28 9:38 ` Eric Dumazet
2024-02-29 17:00 ` Christoph Lameter (Ampere)
2024-02-29 17:07 ` Eric Dumazet
2024-02-29 17:57 ` Christoph Lameter (Ampere)
2024-02-29 16:56 ` Christoph Lameter (Ampere) [this message]
2024-02-26 10:10 ` [PATCH] net: skbuff: allocate the fclone in the current NUMA node Alexander Lobakin
2024-02-27 6:30 ` Shijie Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afcf367f-5b33-5249-ad85-2addede18dc5@linux.com \
--to=cl@linux.com \
--cc=aleksander.lobakin@intel.com \
--cc=ast@kernel.org \
--cc=cl@os.amperecomputing.com \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linyunsheng@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=patches@amperecomputing.com \
--cc=shijie@os.amperecomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.