From: Matthew Wilcox <willy@infradead.org>
To: Namjae Jeon <linkinjeon@kernel.org>
Cc: viro@zeniv.linux.org.uk, brauner@kernel.org, hch@lst.de,
tytso@mit.edu, jack@suse.cz, djwong@kernel.org, dsterba@suse.com,
pali@kernel.org, amir73il@gmail.com, xiang@kernel.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Hyunchul Lee <hyc.lee@gmail.com>
Subject: Re: [PATCH v9 10/17] ntfs: update attrib operations
Date: Sun, 3 May 2026 13:49:13 +0100 [thread overview]
Message-ID: <afdESUirlu57HBOT@casper.infradead.org> (raw)
In-Reply-To: <20260213081804.13351-11-linkinjeon@kernel.org>
On Fri, Feb 13, 2026 at 05:17:57PM +0900, Namjae Jeon wrote:
> @@ -215,7 +232,7 @@ static int ntfs_decompress(struct page *dest_pages[], int completed_pages[],
> handle_bounds_compressed_page(dp, i_size,
> initialized_size);
> flush_dcache_page(dp);
> - kunmap(dp);
> + kunmap_local(page_address(dp));
This doesn't work. kmap() makes page_address() work, but kmap_local()
doesn't. kmap_local() returns a local mapping of the page, and you have
to kunmap_local() _that_ address. page_address() will continue to
return NULL for highmem pages.
I'll send a patch soon for ntfs_decompress(), but thought I'd flag this
in case there are other places that need to be audited.
next prev parent reply other threads:[~2026-05-03 12:49 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-13 8:17 [PATCH v9 00/17] ntfs filesystem remake Namjae Jeon
2026-02-13 8:17 ` [PATCH v9 01/17] Revert "fs: Remove NTFS classic" Namjae Jeon
2026-02-13 8:17 ` [PATCH v9 02/17] fs: add generic FS_IOC_SHUTDOWN definitions Namjae Jeon
2026-02-21 6:17 ` David Timber
2026-02-21 7:10 ` Darrick J. Wong
2026-02-13 8:17 ` [PATCH v9 03/17] ntfs: update in-memory, on-disk structures and headers Namjae Jeon
2026-02-13 8:17 ` [PATCH v9 04/17] ntfs: update super block operations Namjae Jeon
2026-02-13 8:17 ` [PATCH v9 05/17] ntfs: update inode operations Namjae Jeon
2026-02-13 8:17 ` [PATCH v9 06/17] ntfs: update mft operations Namjae Jeon
2026-02-13 8:17 ` [PATCH v9 07/17] ntfs: update directory operations Namjae Jeon
2026-02-13 8:17 ` [PATCH v9 08/17] ntfs: update file operations Namjae Jeon
2026-02-13 8:17 ` [PATCH v9 09/17] ntfs: update iomap and address space operations Namjae Jeon
2026-02-13 8:17 ` [PATCH v9 10/17] ntfs: update attrib operations Namjae Jeon
2026-05-03 12:49 ` Matthew Wilcox [this message]
2026-05-03 13:33 ` Namjae Jeon
2026-02-13 8:17 ` [PATCH v9 11/17] ntfs: update runlist handling and cluster allocator Namjae Jeon
2026-02-13 8:17 ` [PATCH v9 12/17] ntfs: add reparse and ea operations Namjae Jeon
2026-02-13 8:18 ` [PATCH v9 13/17] ntfs: update misc operations Namjae Jeon
2026-02-13 8:18 ` [PATCH v9 14/17] ntfs3: remove legacy ntfs driver support Namjae Jeon
2026-02-13 8:18 ` [PATCH v9 15/17] ntfs: add Kconfig and Makefile Namjae Jeon
2026-02-13 8:18 ` [PATCH v9 16/17] Documentation: filesystems: update NTFS driver documentation Namjae Jeon
2026-02-13 8:18 ` [PATCH v9 17/17] MAINTAINERS: update ntfs filesystem entry Namjae Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afdESUirlu57HBOT@casper.infradead.org \
--to=willy@infradead.org \
--cc=amir73il@gmail.com \
--cc=brauner@kernel.org \
--cc=djwong@kernel.org \
--cc=dsterba@suse.com \
--cc=hch@lst.de \
--cc=hyc.lee@gmail.com \
--cc=jack@suse.cz \
--cc=linkinjeon@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pali@kernel.org \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
--cc=xiang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.