From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BC17DC624D7 for ; Thu, 3 Sep 2026 20:45:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uHI35z49PmbE0rOxX2nHE6hngp3uo1uDzzWrWEO1Cfs=; b=L0okb70aOzr4uK FBFFiU0K80UbMLYbIFynYMuA7hSgSkSbrqj9es3MjOoeykE1TTg8f6At8SVlNJJd0qmjsCZzcNBAL LmovFKw5DR3/k8tSDZJnHwZWAlknQ4JemQSPl9FSZJcATcTI6xXLFfkmaHaurPvVlnGkKxwov9LmC //eZfr7/OcLbRo0mGYNqHa2Uz3bvvVBP7BosimagPwJURaV1gBasGrDfk6zZplxYSSMqEQ9j+kS5p T9RBEFdiR4X2CvSxa8SwbnkBuEfsVB1PBCSCahq6KXlk6t6EJVD5qxUSyj4D/nMBUlwACVultvqYA wVP6KUx/4vMpMR+Q33mQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x2EIz-00000000ZoE-1l7h; Thu, 03 Sep 2026 20:45:05 +0000 Received: from mail-ed1-x531.google.com ([2a00:1450:4864:20::531]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x2EIw-00000000ZmA-44n2 for linux-rockchip@lists.infradead.org; Thu, 03 Sep 2026 20:45:04 +0000 Received: by mail-ed1-x531.google.com with SMTP id 4fb4d7f45d1cf-6a615ab11b5so25724a12.0 for ; Thu, 03 Sep 2026 13:45:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788468300; x=1789073100; darn=lists.infradead.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=X3guYpEVe0jojtjWvcu73KPb7DZ8REKqlzshck7w5p0=; b=rLh2n31A1pRphJCMXf43KMRoepA8ooAidn/Pl2fXMGKyiO9jsc7gWgGJjqMnBUFgsB AiLDhrHVlp8W+J/9C/7FiDJyF6O8FyVoCutdRxIL+mHwmobUVUaKNkMupxc4EFzTC6Z2 6hG34KymSkI0VCqcKWeQ/9OGenWgm4UyyrMcpXcISgW8ceLrfNLrQGDwHMVfryW0U733 YVIurqMT82wZy834FMdxssz6o3z4I6ggrdY4/MvqURHaBF7VB9DsmxD6HBuGiCtaIKQg Bv6f0eD3+VrYj+6wS31mXiSAW1X3eiokszAP6YwqMHwsgyrl9cDfvlE8GZtwBS1rVrPd cEaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788468300; x=1789073100; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=X3guYpEVe0jojtjWvcu73KPb7DZ8REKqlzshck7w5p0=; b=On+cKKxtbZwXF2AUA59lrb2P80cySykvbcgcTKXju1DuvuBmPk8L9CWsZCGxqty0EL wMgy1bm6L524U2xYCrYrmiwONj8ODOI39JIMrwOgs9xSsG9wUNyKHrrCelk60+YJqkDY Cvt/GMUVcswaJUAUQZP/n/vOLMN3aDeu4cTGTeq4eBw5JDKF3v3NVCBAA2nYl2snYGER QyMikbgRmnOvzI9RC3x8DxkiVJZsHAmwnMywQ2f9V+OAP6r9bQQLy76xndm/vYvUuN8v 2CJNdAz8FazbsWxauyH6awUDNKKznc1823pGlr8Vv/WDArR0CocnDIrwhHZlxvBUb17/ 1hLg== X-Forwarded-Encrypted: i=1; AKwUvByR2IwDjvfFKHU98upCbTnk5DSlBqKVEZjWM6n0LE/6HWT5t/Wsn3YkmdZcJl/sAQzZWbFDhMFACpdnRsZPEg==@lists.infradead.org X-Gm-Message-State: AFuF++kIk51FHwQiFWj3O/NptlqQr2oCEP4iIa0bUMjhU3YJc+1vt8kQ 1RuujmznX8IZ4lxt9y4GwGFA8y6hGq+bAGqj97ECLGC1LVqr2cBb1LOJ X-Gm-Gg: AYBFou1xApOWuIE26/OIE6jX/rEKOoMeqlTaRPW3elg6JZm7JOXeD3AkUgjlsJcjkpF h+qOg68b8PLZ5Ouv8mn1vf7jJWhbqeIA5vsa42au1+q6PIN7mYeOBXeAztwwBPI80vgGBwqmgnJ EKaL66dTvZCcDO92sifmhLWBBkD/foc2vSvOT1bY78nmr0t5KB20XaORUsDEN/Gqky6DLQ901EV XRFXTJ7olBGzgrXIbuq/VkIRgGNxEecHFnJO+QVmoQByUAHolbQ8QHP1p2V/Gv96ipdtlG+RKvJ 2D6+5z3BsxW/sg4UK5jfapkwgGCheS1ynZSVlfT7mzihqV+FiEsDBp4Vq4q7ymhVLelLON/HqVB /85onf13W4MUg+CbCbJWNtY3hknjLh0hLcJRWpXP8xHZHvUQbWFlgBQQtRAsVKx140ssQCfxnu/ VXfHKDp7Gyyz5Ml1RAoSr5/7TagGYY1MOL+FW2opZYkgsweyjjRWkrRpL8LVrDznzIuYgm8quT5 OJY8lF3o4fn+wub64ndyrrolDtxRgJyJNlGCA== X-Received: by 2002:a05:6402:1d48:b0:6a0:d411:930d with SMTP id 4fb4d7f45d1cf-6a7e8d9b328mr180296a12.2.1788468300064; Thu, 03 Sep 2026 13:45:00 -0700 (PDT) Received: from ?IPV6:2a02:a449:4071:0:32d0:42ff:fe10:6983? ([2a02:a449:4071:0:32d0:42ff:fe10:6983]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6a7e68a6a1dsm233448a12.7.2026.09.03.13.44.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Sep 2026 13:44:59 -0700 (PDT) Message-ID: Date: Thu, 3 Sep 2026 22:44:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] drm/rockchip: rk3066_hdmi: convert to devm_drm_bridge_alloc() API To: =?UTF-8?Q?Heiko_St=C3=BCbner?= , Sandy Huang , Andy Yan , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, =?UTF-8?Q?H=C3=BCseyin_BIYIK?= References: <20260824-drm-v2-1-7f9273c6020b@gmail.com> <2814844.6tgchFWduM@diego> Content-Language: en-US, ar-EG From: Johan Jonker In-Reply-To: <2814844.6tgchFWduM@diego> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260903_134503_032500_8B9857F8 X-CRM114-Status: GOOD ( 20.57 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org SGksCgpPbiA5LzMvMjYgMTc6MTIsIEhlaWtvIFN0w7xibmVyIHdyb3RlOgo+IEFtIE1vbnRhZywg MjQuIEF1Z3VzdCAyMDI2LCAxMjoyMToxOSBNaXR0ZWxldXJvcMOkaXNjaGUgU29tbWVyemVpdCBz Y2hyaWViIEpvaGFuIEpvbmtlciB2aWEgQjQgUmVsYXk6Cj4+IEZyb206IEjDvHNleWluIEJJWUlL IDxib29naWVwb3BAZ214LmNvbT4KPj4KPj4gVGhlIGZ1bmN0aW9uIGRldm1fZHJtX2JyaWRnZV9h bGxvYygpIGlzIHRoZSBuZXcgQVBJIGZvciBhbGxvY2F0aW5nIERSTSBicmlkZ2VzLgo+PiBUaGlz IGNvbnZlcnNpb24gd2FzIG1pc3NlZCBkdXJpbmcgdGhlIGluaXRpYWwgY29udmVyc2lvbiBvZiBh bGwgYnJpZGdlcyB0bwo+PiB0aGUgbmV3IEFQSS4KPj4KPj4gU2lnbmVkLW9mZi1ieTogSMO8c2V5 aW4gQklZSUsgPGJvb2dpZXBvcEBnbXguY29tPgo+PiBTaWduZWQtb2ZmLWJ5OiBKb2hhbiBKb25r ZXIgPGpieDYyNDRAZ21haWwuY29tPgo+PiAtLS0KPj4gIGRyaXZlcnMvZ3B1L2RybS9yb2NrY2hp cC9yazMwNjZfaGRtaS5jIHwgOCArKysrLS0tLQo+PiAgMSBmaWxlIGNoYW5nZWQsIDQgaW5zZXJ0 aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKPj4KPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry bS9yb2NrY2hpcC9yazMwNjZfaGRtaS5jIGIvZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlwL3JrMzA2 Nl9oZG1pLmMKPj4gaW5kZXggZjI4ZDZhODgzZTA5Li4zOWM2NWVlMDdjYWEgMTAwNjQ0Cj4+IC0t LSBhL2RyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9yazMwNjZfaGRtaS5jCj4+ICsrKyBiL2RyaXZl cnMvZ3B1L2RybS9yb2NrY2hpcC9yazMwNjZfaGRtaS5jCj4+IEBAIC03MDMsNyArNzAzLDYgQEAg cmszMDY2X2hkbWlfcmVnaXN0ZXIoc3RydWN0IGRybV9kZXZpY2UgKmRybSwgc3RydWN0IHJrMzA2 Nl9oZG1pICpoZG1pKQo+PiAgCQkJIERSTV9NT0RFX0VOQ09ERVJfVE1EUywgTlVMTCk7Cj4+ICAK Cj4+ICAJaGRtaS0+YnJpZGdlLmRyaXZlcl9wcml2YXRlID0gaGRtaTsKCkNhbiB0aGlzIGJlIHJl bW92ZWQ/ClNlZSBsaW5rL2NvbW1lbnQgYmVsb3cuCgoKPj4gLQloZG1pLT5icmlkZ2UuZnVuY3Mg PSAmcmszMDY2X2hkbWlfYnJpZGdlX2Z1bmNzOwo+PiAgCWhkbWktPmJyaWRnZS5vcHMgPSBEUk1f QlJJREdFX09QX0RFVEVDVCB8Cj4+ICAJCQkgICBEUk1fQlJJREdFX09QX0VESUQgfAo+PiAgCQkJ ICAgRFJNX0JSSURHRV9PUF9IRE1JIHwKPj4gQEAgLTc0Nyw5ICs3NDYsMTAgQEAgc3RhdGljIGlu dCByazMwNjZfaGRtaV9iaW5kKHN0cnVjdCBkZXZpY2UgKmRldiwgc3RydWN0IGRldmljZSAqbWFz dGVyLAo+PiAgCWludCBpcnE7Cj4+ICAJaW50IHJldDsKPj4gIAo+PiAtCWhkbWkgPSBkZXZtX2t6 YWxsb2MoZGV2LCBzaXplb2YoKmhkbWkpLCBHRlBfS0VSTkVMKTsKPj4gLQlpZiAoIWhkbWkpCj4+ IC0JCXJldHVybiAtRU5PTUVNOwo+PiArCWhkbWkgPSBkZXZtX2RybV9icmlkZ2VfYWxsb2MoZGV2 LCBzdHJ1Y3QgcmszMDY2X2hkbWksIGJyaWRnZSwKPj4gKwkJCQkgICAgICZyazMwNjZfaGRtaV9i cmlkZ2VfZnVuY3MpOwo+PiArCWlmIChJU19FUlIoaGRtaSkpCj4+ICsJCXJldHVybiBQVFJfRVJS KGhkbWkpOwo+IAoKPiBJZiBJJ20gcmVhZGluZyB0aGluZ3MgY29ycmVjdGx5LCB0aGUgcGFydHMg aW4gcmszMDY2X2hkbWlfcmVnaXN0ZXIgc2V0dGluZwo+IGhkbWktPmJyaWRnZS5kcml2ZXJfcHJp dmF0ZSAoc2hvdWxkIHVzZSB0aGUgY29udGFpbmVyIGZpZWxkIG9mIHN0cnVjdAo+IGRybV9icmlk Z2UgaW5zdGVhZCkgCgpUaGUgZHJpdmVyX3ByaXZhdGUgbGluZSB3YXMgYWRkZWQgd2l0aCB0aGlz IHBhdGNoOgoKW1BBVENIXSBkcm0vcm9ja2NoaXA6IHJrMzA2Nl9oZG1pOiBzd2l0Y2ggdG8gZHJt IGJyaWRnZQpodHRwczovL2xvcmUua2VybmVsLm9yZy9hbGwvMjAyNTA0MjgxMDIzMDkuMTUwMTk4 Ni0xLWFuZHlzaHJrQDE2My5jb20vCgphbmQgaGRtaS0+YnJpZGdlLmZ1bmNzIGFyZSByZWR1bmRh bnQgYnkgdGhpcyBjaGFuZ2U/CgpOb3QgcmVkdW5kYW50LCBqdXN0IGZ1bmNzIGFyZSBhdHRhY2hl ZCBpbiBhIGNvbW1vbiBmdW5jdGlvbiBfX2Rldm1fZHJtX2JyaWRnZV9hbGxvYygpCgpodHRwczov L2VsaXhpci5ib290bGluLmNvbS9saW51eC92Ny4yLjIvc291cmNlL2RyaXZlcnMvZ3B1L2RybS9k cm1fYnJpZGdlLmMjTDM4MwoKdm9pZCAqX19kZXZtX2RybV9icmlkZ2VfYWxsb2Moc3RydWN0IGRl dmljZSAqZGV2LCBzaXplX3Qgc2l6ZSwgc2l6ZV90IG9mZnNldCwKCQkJICAgICAgY29uc3Qgc3Ry dWN0IGRybV9icmlkZ2VfZnVuY3MgKmZ1bmNzKQp7Cgl2b2lkICpjb250YWluZXI7CglzdHJ1Y3Qg ZHJtX2JyaWRnZSAqYnJpZGdlOwoJaW50IGVycjsKCglpZiAoIWZ1bmNzKSB7CgkJZGV2X3dhcm4o ZGV2LCAiTWlzc2luZyBmdW5jcyBwb2ludGVyXG4iKTsKCQlyZXR1cm4gRVJSX1BUUigtRUlOVkFM KTsKCX0KCgljb250YWluZXIgPSBremFsbG9jKHNpemUsIEdGUF9LRVJORUwpOwoJaWYgKCFjb250 YWluZXIpCgkJcmV0dXJuIEVSUl9QVFIoLUVOT01FTSk7CgoJYnJpZGdlID0gY29udGFpbmVyICsg b2Zmc2V0OwoJSU5JVF9MSVNUX0hFQUQoJmJyaWRnZS0+bGlzdCk7CglicmlkZ2UtPmNvbnRhaW5l ciA9IGNvbnRhaW5lcjsKCWJyaWRnZS0+ZnVuY3MgPSBmdW5jczsKCWtyZWZfaW5pdCgmYnJpZGdl LT5yZWZjb3VudCk7CgoJZXJyID0gZGV2bV9hZGRfYWN0aW9uX29yX3Jlc2V0KGRldiwgZHJtX2Jy aWRnZV9wdXRfdm9pZCwgYnJpZGdlKTsKCWlmIChlcnIpCgkJcmV0dXJuIEVSUl9QVFIoZXJyKTsK CglyZXR1cm4gY29udGFpbmVyOwp9CkVYUE9SVF9TWU1CT0woX19kZXZtX2RybV9icmlkZ2VfYWxs b2MpOwoKPT09PT09PT09PT0KCk90aGVyIGV4YW1wbGUgZnJvbSBzdGk6CgpodHRwczovL2xvcmUu a2VybmVsLm9yZy9hbGwvY2U5YzZhYTMtNTM3Mi00NjhmLWE0YmYtNWEyNjEyNTllNDU5QHNhbXN1 bmcuY29tLwoKPj4+PiBJdCBsb29rcyBsaWtlIHlvdSBkb24ndCBzZXQgYnJpZGdlLT5kcml2ZXJf cHJpdmF0ZSBhbnltb3JlLiBJcyBpdCBvbiBwdXJwb3NlPwo+Pj4gVGhpcyBsb29rcyBjb3JyZWN0 IHRvIG1lLiBJbiBjdXJyZW50IGNvZGUsIGRyaXZlcl9wcml2YXRlIGlzIHVzZWQgdG8KPj4+IGhv bGQgYSBwb2ludGVyIHRvIHRoZSBkcml2ZXIgcHJpdmF0ZSBzdHJ1Y3QgKHN0cnVjdAo+Pj4gYW5h bG9naXhfZHBfZGV2aWNlKS4gV2l0aCBkZXZtX2RybV9icmlkZ2VfYWxsb2MoKSBjb250YWluZXJf b2YoKSBpcyBub3cKPj4+IGVub3VnaCwgbm8gcG9pbnRlciBpcyBuZWVkZWQuIFdpdGggdGhlIHBh dGNoIGFwcGxpZWQsIGRyaXZlcl9wcml2YXRlCj4+PiBiZWNvbWVzIHVudXNlZC4KPj4gVGhlbiB3 ZSBzaG91bGQgcmVtb3ZlIGl0IGZyb20gdGhlIHN0cnVjdHVyZSBpZiBpdCdzIHVudXNlZC4KCgpk cm0vc3RpOiBoZG1pOiBjb252ZXJ0IHRvIGRldm1fZHJtX2JyaWRnZV9hbGxvYygpIEFQSQpodHRw czovL2dpdC5rZXJuZWwub3JnL3B1Yi9zY20vbGludXgva2VybmVsL2dpdC90b3J2YWxkcy9saW51 eC5naXQvY29tbWl0Lz9pZD1hYzQ1MzE0MjRkOTA3ZjM5ODNlOTE5YTdiZGEyYjkwZWEwY2VkZTRm Cgo9PT09PT09PT09PT0KClRoaXMgc2VyaWUgd2FzIG1pc3NpbmcgYSBmZXcgYnJpZGdlcyB0b28g bWFueS4KCmRybTogY29udmVydCBhbGwgYnJpZGdlcyB0byBkZXZtX2RybV9icmlkZ2VfYWxsb2Mo KQpodHRwczovL3BhdGNod29yay5mcmVlZGVza3RvcC5vcmcvc2VyaWVzLzE0ODIyOS8KCj09PT0K ClBsZWFzZSBhZHZpc2Ugd2hhdCBjaGFuZ2VzIGFyZSBuZWVkZWQ/ClJLMzA2Nl9oZG1pIGlzIGJy b2tlbiBzaW5jZSBzb21ld2hlcmUgMjAyNS0wNS4KCkpvaGFuCgoKPiAKPiAKPiBIZWlrbwo+IAo+ IAo+IAo+PiAgCj4+ICAJaGRtaS0+ZGV2ID0gZGV2Owo+PiAgCWhkbWktPmRybV9kZXYgPSBkcm07 Cj4+Cj4+IC0tLQo+PiBiYXNlLWNvbW1pdDogMjcwOWRkNWFlMzJmMDgyOGYzODYzMjdjNzZiYmE5 ZjM5ZjYzYTFjNgo+PiBjaGFuZ2UtaWQ6IDIwMjYwODI0LWRybS1lNDY4OWY2NWFiOGMKPj4KPj4g QmVzdCByZWdhcmRzLAo+Pgo+IAo+IAo+IAo+IAoKCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCkxpbnV4LXJvY2tjaGlwIG1haWxpbmcgbGlzdApMaW51eC1y b2NrY2hpcEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21h aWxtYW4vbGlzdGluZm8vbGludXgtcm9ja2NoaXAK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 55E7BC624D7 for ; Thu, 3 Sep 2026 20:45:04 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4A20610E19A; Thu, 3 Sep 2026 20:45:03 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="n7wrKmCz"; dkim-atps=neutral Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) by gabe.freedesktop.org (Postfix) with ESMTPS id 40A8710E19A for ; Thu, 3 Sep 2026 20:45:02 +0000 (UTC) Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-6a5f5d37778so25545a12.2 for ; Thu, 03 Sep 2026 13:45:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788468300; x=1789073100; darn=lists.freedesktop.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=X3guYpEVe0jojtjWvcu73KPb7DZ8REKqlzshck7w5p0=; b=n7wrKmCzmWI3Es5lkADFQWDO0QTrWxvFZkAT/NFTAB0Hm6h09pAtm89u3In+FnSok5 ThXrr9azgGnC5SLeG7pBn3TI+cHNPnsITTWAXF6iYP5K5QuaKmQH6CwNU8wo6ICCupBp 9OHLSyc6bQwFWEgAT1xT2XZD/v+3Q0TQKE3qjNCWE8WOrSHIqDcWzr5F0fcvd8hPoQs/ q1pJw7g5iZzjJkcLBD5HK8X2jNh/C63tl3HrXloNbL71zDwFUeuk58habDxaQHWOjfGz lyG9GDYEYIFSfSm6rzak3fLm5f5Grjc4szefM+/OOcHLgCLta8F6NLpDL5JYm3ZU9nou 7s+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788468300; x=1789073100; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=X3guYpEVe0jojtjWvcu73KPb7DZ8REKqlzshck7w5p0=; b=hCa3+4dHJkmuTYr12b8tnguLGtd+Ah7+A8PD9s0vkxuiBjmoWtrh9SQZKg56hSatNz bI0RlwIIa477r/o7gWjR9nbf+oFPrPgDUp3DFeHknsQPxCyunullT+2kv9Ei27xqoJNt 7AnH/fAxDeJr3rqAlf2vd8255LqNKA+RHRbEHjpSkJpU/U5MpNE3ZB2JFHhQrDdxM11l XbPey+S7+MZKT9XshheUVtwNLh5CP85kodxjBH9XcyFWDMJoK7tvVsGLXdfbBlYQpQF8 kOyKy/BnjF0hkr5Q2OY2th4I5hU23999qB1yg06Gico+rmjZmzkcCFfF+cL4ThalA3s5 XO+Q== X-Gm-Message-State: AFuF++nxMQ0HAyZrrKdDCECIPUBXTX9oR5hD/GyYWD9Bi7WffmkirSc6 z7RDZoUAFco7x4nnGC18gsesm3aXeR5otjX+B4xO5IGKxN37Wq2Sh9ry X-Gm-Gg: AYBFou0H952JLCs/vcB5rce++7vI++WGVdfZK8gJxqPgF62Eq3wGcpxrBvrnoaEuqdc 4m/8B5NjwCL4NCHKAUm0Zf9UQbeTX+wMnnZxq5gK54Yqzuq+vFTfpKWl92uO+xd9dAGYlB7Z/IV o15yVHmpJL6RK2YxnR9bKcMfArjx2iOOH8ZMcHn0pYERK0SBeNX4VhBS8tyoF6YLGaF+fGEcyaz uQKtJvZz4NKY9RLkObzLJpErU+/l6h9r//rQeV5mv+kAEZ7Q4QeHmyl8BksYqmVTHAPDNLSiD9d OyOTXUvPKI8O7MIg4GZAtRV2fi1Rsy1q2hHOhHNjtzZMvbYcomoGY//qviwoZPbdVpxeDm+y170 WjK391c/gGY+O5wjottgecR87vnYAFQZYrTobGYX/+FJ7U6RWyvj2yFTfVybs/T9U03QFycYwdQ K+k3u625nrzySbmHJ2W321PEhPvQNQPQRVYiNNITNuX4RtC3cIs09OfIKTmBeeYOKuxr2qB//Xq yR2yjw/hIW9NdQzdjrWc0xVuMZEsG0cYShiJQ== X-Received: by 2002:a05:6402:1d48:b0:6a0:d411:930d with SMTP id 4fb4d7f45d1cf-6a7e8d9b328mr180296a12.2.1788468300064; Thu, 03 Sep 2026 13:45:00 -0700 (PDT) Received: from ?IPV6:2a02:a449:4071:0:32d0:42ff:fe10:6983? ([2a02:a449:4071:0:32d0:42ff:fe10:6983]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6a7e68a6a1dsm233448a12.7.2026.09.03.13.44.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Sep 2026 13:44:59 -0700 (PDT) Message-ID: Date: Thu, 3 Sep 2026 22:44:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] drm/rockchip: rk3066_hdmi: convert to devm_drm_bridge_alloc() API To: =?UTF-8?Q?Heiko_St=C3=BCbner?= , Sandy Huang , Andy Yan , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, =?UTF-8?Q?H=C3=BCseyin_BIYIK?= References: <20260824-drm-v2-1-7f9273c6020b@gmail.com> <2814844.6tgchFWduM@diego> Content-Language: en-US, ar-EG From: Johan Jonker In-Reply-To: <2814844.6tgchFWduM@diego> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi, On 9/3/26 17:12, Heiko Stübner wrote: > Am Montag, 24. August 2026, 12:21:19 Mitteleuropäische Sommerzeit schrieb Johan Jonker via B4 Relay: >> From: Hüseyin BIYIK >> >> The function devm_drm_bridge_alloc() is the new API for allocating DRM bridges. >> This conversion was missed during the initial conversion of all bridges to >> the new API. >> >> Signed-off-by: Hüseyin BIYIK >> Signed-off-by: Johan Jonker >> --- >> drivers/gpu/drm/rockchip/rk3066_hdmi.c | 8 ++++---- >> 1 file changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/gpu/drm/rockchip/rk3066_hdmi.c b/drivers/gpu/drm/rockchip/rk3066_hdmi.c >> index f28d6a883e09..39c65ee07caa 100644 >> --- a/drivers/gpu/drm/rockchip/rk3066_hdmi.c >> +++ b/drivers/gpu/drm/rockchip/rk3066_hdmi.c >> @@ -703,7 +703,6 @@ rk3066_hdmi_register(struct drm_device *drm, struct rk3066_hdmi *hdmi) >> DRM_MODE_ENCODER_TMDS, NULL); >> >> hdmi->bridge.driver_private = hdmi; Can this be removed? See link/comment below. >> - hdmi->bridge.funcs = &rk3066_hdmi_bridge_funcs; >> hdmi->bridge.ops = DRM_BRIDGE_OP_DETECT | >> DRM_BRIDGE_OP_EDID | >> DRM_BRIDGE_OP_HDMI | >> @@ -747,9 +746,10 @@ static int rk3066_hdmi_bind(struct device *dev, struct device *master, >> int irq; >> int ret; >> >> - hdmi = devm_kzalloc(dev, sizeof(*hdmi), GFP_KERNEL); >> - if (!hdmi) >> - return -ENOMEM; >> + hdmi = devm_drm_bridge_alloc(dev, struct rk3066_hdmi, bridge, >> + &rk3066_hdmi_bridge_funcs); >> + if (IS_ERR(hdmi)) >> + return PTR_ERR(hdmi); > > If I'm reading things correctly, the parts in rk3066_hdmi_register setting > hdmi->bridge.driver_private (should use the container field of struct > drm_bridge instead) The driver_private line was added with this patch: [PATCH] drm/rockchip: rk3066_hdmi: switch to drm bridge https://lore.kernel.org/all/20250428102309.1501986-1-andyshrk@163.com/ and hdmi->bridge.funcs are redundant by this change? Not redundant, just funcs are attached in a common function __devm_drm_bridge_alloc() https://elixir.bootlin.com/linux/v7.2.2/source/drivers/gpu/drm/drm_bridge.c#L383 void *__devm_drm_bridge_alloc(struct device *dev, size_t size, size_t offset, const struct drm_bridge_funcs *funcs) { void *container; struct drm_bridge *bridge; int err; if (!funcs) { dev_warn(dev, "Missing funcs pointer\n"); return ERR_PTR(-EINVAL); } container = kzalloc(size, GFP_KERNEL); if (!container) return ERR_PTR(-ENOMEM); bridge = container + offset; INIT_LIST_HEAD(&bridge->list); bridge->container = container; bridge->funcs = funcs; kref_init(&bridge->refcount); err = devm_add_action_or_reset(dev, drm_bridge_put_void, bridge); if (err) return ERR_PTR(err); return container; } EXPORT_SYMBOL(__devm_drm_bridge_alloc); =========== Other example from sti: https://lore.kernel.org/all/ce9c6aa3-5372-468f-a4bf-5a261259e459@samsung.com/ >>>> It looks like you don't set bridge->driver_private anymore. Is it on purpose? >>> This looks correct to me. In current code, driver_private is used to >>> hold a pointer to the driver private struct (struct >>> analogix_dp_device). With devm_drm_bridge_alloc() container_of() is now >>> enough, no pointer is needed. With the patch applied, driver_private >>> becomes unused. >> Then we should remove it from the structure if it's unused. drm/sti: hdmi: convert to devm_drm_bridge_alloc() API https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=ac4531424d907f3983e919a7bda2b90ea0cede4f ============ This serie was missing a few bridges too many. drm: convert all bridges to devm_drm_bridge_alloc() https://patchwork.freedesktop.org/series/148229/ ==== Please advise what changes are needed? RK3066_hdmi is broken since somewhere 2025-05. Johan > > > Heiko > > > >> >> hdmi->dev = dev; >> hdmi->drm_dev = drm; >> >> --- >> base-commit: 2709dd5ae32f0828f386327c76bba9f39f63a1c6 >> change-id: 20260824-drm-e4689f65ab8c >> >> Best regards, >> > > > >