From: Oliver Neukum <oneukum@suse.com>
To: yicongsrfy@163.com, kuba@kernel.org, andrew+netdev@lunn.ch,
andrew@lunn.ch, oneukum@suse.com
Cc: davem@davemloft.net, linux-usb@vger.kernel.org,
netdev@vger.kernel.org, yicong@kylinos.cn
Subject: Re: [PATCH v2] usbnet: Set duplex status to unknown in the absence of MII
Date: Thu, 24 Jul 2025 11:03:57 +0200 [thread overview]
Message-ID: <afdfb8e8-0d42-4b5c-86fa-e46fed35b80f@suse.com> (raw)
In-Reply-To: <20250724013133.1645142-1-yicongsrfy@163.com>
On 24.07.25 03:31, yicongsrfy@163.com wrote:
> From: Yi Cong <yicong@kylinos.cn>
>
> Currently, USB CDC devices that do not use MDIO to get link status have
> their duplex mode set to half-duplex by default. However, since the CDC
> specification does not define a duplex status, this can be misleading.
>
> This patch changes the default to DUPLEX_UNKNOWN in the absence of MII,
> which more accurately reflects the state of the link and avoids implying
> an incorrect or error state.
>
> v2: rewrote commmit messages and code comments
>
> Link: https://lore.kernel.org/all/20250723152151.70a8034b@kernel.org/
> Signed-off-by: Yi Cong <yicong@kylinos.cn>
Acked-by: Oliver Neukum <oneukum@suse.com>
next prev parent reply other threads:[~2025-07-24 9:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-21 7:10 [PATCH] usbnet: Set duplex status to unknown in the absence of MII yicongsrfy
2025-07-21 13:51 ` Andrew Lunn
2025-07-22 2:09 ` yicongsrfy
2025-07-22 13:06 ` Andrew Lunn
2025-07-23 1:29 ` yicongsrfy
2025-07-23 7:17 ` Oliver Neukum
2025-07-23 8:44 ` yicongsrfy
2025-07-23 10:03 ` Oliver Neukum
2025-07-23 13:04 ` Andrew Lunn
2025-07-23 13:05 ` Andrew Lunn
2025-07-23 22:21 ` Jakub Kicinski
2025-07-24 1:31 ` [PATCH v2] " yicongsrfy
2025-07-24 9:03 ` Oliver Neukum [this message]
2025-07-25 18:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afdfb8e8-0d42-4b5c-86fa-e46fed35b80f@suse.com \
--to=oneukum@suse.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yicong@kylinos.cn \
--cc=yicongsrfy@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.