From: Ping-Ke Shih <pkshih@realtek.com>
To: Vincent Schurink <spam@acio.nl>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: RE: [PATCH rtw-next v4] wifi: rtw89: set RA init rate level when the station RSSI is known
Date: Mon, 16 Nov 2026 08:33:49 +0000 [thread overview]
Message-ID: <affec3fd16f6419d8072f5dfba3b31ba@realtek.com> (raw)
In-Reply-To: <20261116081741.51039-1-spam@acio.nl>
Vincent Schurink <spam@acio.nl> wrote:
> @@ -519,6 +533,11 @@ void rtw89_phy_ra_update_sta_link(struct rtw89_dev *rtwdev,
>
> rcu_read_unlock();
>
> + ra->init_rate_lv = rtw89_phy_ra_get_init_rate_lv(rtwsta_link);
> + if (ra->rssi_unknown && ra->init_rate_lv) {
> + ra->upd_all = 1;
> + ra->rssi_unknown = false;
> + }
To be more conservative, I'd only update ra->init_rate_lv when ra->rssi_unknown
flagged, since I don't thoroughly know how firmware deal with the value.
Let's get and check local variable, and then assign to ra->init_rate_lv.
> if (changed & IEEE80211_RC_SUPP_RATES_CHANGED)
> ra->upd_mask = 1;
> if (changed & (IEEE80211_RC_BW_CHANGED | IEEE80211_RC_NSS_CHANGED))
next prev parent reply other threads:[~2026-11-16 8:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 8:17 [PATCH rtw-next v4] wifi: rtw89: set RA init rate level when the station RSSI is known Vincent Schurink
2026-11-16 8:33 ` Ping-Ke Shih [this message]
2026-11-16 8:58 ` V. S.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=affec3fd16f6419d8072f5dfba3b31ba@realtek.com \
--to=pkshih@realtek.com \
--cc=linux-wireless@vger.kernel.org \
--cc=spam@acio.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.