From: Oleg Nesterov <oleg@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Andy Lutomirski <luto@kernel.org>, Kees Cook <kees@kernel.org>,
Kusaram Devineni <kusaram@devineni.in>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@kernel.org>, Will Drewry <wad@chromium.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] signal: change force_sig_info_to_task() to call __send_signal_locked()
Date: Mon, 4 May 2026 11:27:08 +0200 [thread overview]
Message-ID: <afhmbCryeyIz0E3V@redhat.com> (raw)
In-Reply-To: <afYGeHSWkLzXDlvC@redhat.com>
On 05/02, Oleg Nesterov wrote:
>
> force_sig_info_to_task() calls send_signal_locked() but this is pointless;
> info is always valid and has_si_pid_and_uid(info) should never be true.
> Forced signals do not carry si_pid/si_uid, not to mention that info.si_pid
> overlaps with .si_addr/si_call_addr/etc.
https://sashiko.dev/#/patchset/afYGeHSWkLzXDlvC%40redhat.com
Sorry I could not reply earlier...
Oh, I didn't know people use force_sig() to send SIGKILL. I'd say they
should not, but this doesn't matter - they do.
So this needs yet another version. And I will read man grep 3 times.
Thanks again Sashiko.
Oleg.
next prev parent reply other threads:[~2026-05-04 9:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-02 14:13 [PATCH v2 1/2] signal: change force_sig_info_to_task() to call __send_signal_locked() Oleg Nesterov
2026-05-02 14:13 ` [PATCH v2 2/2] signal: prevent evasion of SA_IMMUTABLE signals Oleg Nesterov
2026-05-04 9:27 ` Oleg Nesterov [this message]
2026-05-13 23:52 ` [PATCH v2 1/2] signal: change force_sig_info_to_task() to call __send_signal_locked() Andrew Morton
2026-05-14 8:18 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afhmbCryeyIz0E3V@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=kees@kernel.org \
--cc=kusaram@devineni.in \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@kernel.org \
--cc=wad@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.