All of lore.kernel.org
 help / color / mirror / Atom feed
From: Erik Cervin Edin <erik@cervined.in>
To: Tian Yuchen <cat@malon.dev>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH] Reintegrate: send "Huh?" warnings to stderr, not stdout
Date: Mon, 4 May 2026 12:03:36 +0200	[thread overview]
Message-ID: <afht-MqIGaZLwbnY@mbp> (raw)
In-Reply-To: <5a821f71-3d6e-4942-9bdb-257617484a6b@malon.dev>

On 26/04/29 02:05AM, Tian Yuchen wrote:
> It would be better for me if this sentence (i.e., what was the code
> originally *intended* to do before the patch?) were placed right at the
> beginning. Something similar to:
> 
> 	In show_merge(), the warning "Huh?: $msg" is emitted to stdout because it
> uses the erroneous redirect `echo 2>&1`. The intent was clearly to use `>&2`
> to print to stderr...
> 
> Of course, it’s up to you ;)

Good point! I hoisted the intent up to the opening paragraph; took the
spirit of your wording rather than copying it verbatim, and tightened
the rest while I was at it.

  reply	other threads:[~2026-05-04 10:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-27 10:47 [PATCH] Reintegrate: send "Huh?" warnings to stderr, not stdout Erik Cervin-Edin
2026-04-28 18:05 ` Tian Yuchen
2026-05-04 10:03   ` Erik Cervin Edin [this message]
2026-05-04 10:28 ` [PATCH v2] " erik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=afht-MqIGaZLwbnY@mbp \
    --to=erik@cervined.in \
    --cc=cat@malon.dev \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.