From: Herbert Xu <herbert@gondor.apana.org.au>
To: Rosen Penev <rosenp@gmail.com>
Cc: linux-crypto@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Kees Cook <kees@kernel.org>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
open list <linux-kernel@vger.kernel.org>,
"open list:KERNEL HARDENING (not covered by other
areas):Keyword:b__counted_by(_le|_be)?b"
<linux-hardening@vger.kernel.org>
Subject: Re: [PATCH] talitos: allocate channels with main struct
Date: Tue, 5 May 2026 13:50:33 +0800 [thread overview]
Message-ID: <afmFKQjJQUHeQO2O@gondor.apana.org.au> (raw)
In-Reply-To: <20260430214340.59588-1-rosenp@gmail.com>
On Thu, Apr 30, 2026 at 02:43:40PM -0700, Rosen Penev wrote:
>
> - priv = devm_kzalloc(dev, sizeof(struct talitos_private), GFP_KERNEL);
> + of_property_read_u32(np, "fsl,num-channels", &num_channels);
Sashiko suggests that you check the return value of this call:
https://sashiko.dev/#/patchset/20260430214340.59588-1-rosenp%40gmail.com
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2026-05-05 5:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-30 21:43 [PATCH] talitos: allocate channels with main struct Rosen Penev
2026-05-05 5:50 ` Herbert Xu [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-05-06 8:56 Rosen Penev
2026-05-06 9:25 ` Paul Louvel
2026-05-15 10:20 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afmFKQjJQUHeQO2O@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=davem@davemloft.net \
--cc=gustavoars@kernel.org \
--cc=kees@kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rosenp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.