All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Raag Jadav <raag.jadav@intel.com>
Cc: Mallesh Koujalagi <mallesh.koujalagi@intel.com>,
	<intel-xe@lists.freedesktop.org>, <matthew.brost@intel.com>,
	<anshuman.gupta@intel.com>, <badal.nilawar@intel.com>,
	<riana.tauro@intel.com>, <karthik.poosa@intel.com>,
	<sk.anirban@intel.com>
Subject: Re: [PATCH v5] drm/xe/xe_survivability: Simplify runtime survivability error handling
Date: Tue, 5 May 2026 15:02:12 -0400	[thread overview]
Message-ID: <afo-tJeBJXBHKk2d@intel.com> (raw)
In-Reply-To: <afosyMxQb4IdeRcp@black.igk.intel.com>

On Tue, May 05, 2026 at 07:45:44PM +0200, Raag Jadav wrote:
> On Mon, May 04, 2026 at 04:33:01PM +0530, Mallesh Koujalagi wrote:
> > xe_survivability_mode_runtime_enable() returns an int, but its caller
> > csc_hw_error_work() ignores the return value and cannot take any
> > meaningful recovery action on failure. The function logs errors via
> > dev_err() and proceeds to declare the device wedged regardless of
> > sysfs creation failure, making the return value redundant.
> > 
> > Change the return type to void and remove the unnecessary
> > error handling in the caller.
> > 
> > v2:
> > - Return is not require after the sysfs creation fail. (Rodrigo/Riana)
> > - Change int to void return type. (Rodrigo)
> > - Remove extra message from csc_hw_error_work().
> > 
> > v3:
> > - Remove ret variable. (Raag)
> > 
> > v4:
> > - Drop ret variable from other part of code.
> > 
> > v5:
> > - Reframe as refactoring instead of bug fix. (Raag)
> > - Remove Fixes tag and update subject line.
> > 
> > Signed-off-by: Mallesh Koujalagi <mallesh.koujalagi@intel.com>
> 
> Reviewed-by: Raag Jadav <raag.jadav@intel.com>

pushed to drm-xe-next. thanks for the patch and reviews

      reply	other threads:[~2026-05-05 19:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-04 11:03 [PATCH v5] drm/xe/xe_survivability: Simplify runtime survivability error handling Mallesh Koujalagi
2026-05-04 14:00 ` ✓ CI.KUnit: success for " Patchwork
2026-05-04 15:02 ` ✓ Xe.CI.BAT: " Patchwork
2026-05-04 17:46 ` ✓ Xe.CI.FULL: " Patchwork
2026-05-05 17:45 ` [PATCH v5] " Raag Jadav
2026-05-05 19:02   ` Rodrigo Vivi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=afo-tJeBJXBHKk2d@intel.com \
    --to=rodrigo.vivi@intel.com \
    --cc=anshuman.gupta@intel.com \
    --cc=badal.nilawar@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=karthik.poosa@intel.com \
    --cc=mallesh.koujalagi@intel.com \
    --cc=matthew.brost@intel.com \
    --cc=raag.jadav@intel.com \
    --cc=riana.tauro@intel.com \
    --cc=sk.anirban@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.