Re: [PATCH RFC v3 2/2] gpio: s5p: Disable when using upstream DTS

[Lukas Timmermann <linux@timmermann.space>]

On Wed, May 06, 2026 at 01:13:30AM +0200, Lukas Timmermann wrote:
> Prevent the older s5p_gpio driver from probing when using upstream DTs
> because of incompatibilities. pinctrl_exynos5250 driver should be used
> instead which binds the s5p_gpio for gpio features but replaces pinctrl.
> 
> Signed-off-by: Lukas Timmermann <uboot@timmermann.space>
> ---
>  drivers/gpio/s5p_gpio.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpio/s5p_gpio.c b/drivers/gpio/s5p_gpio.c
> index c072f146514..f32c5f7ae1a 100644
> --- a/drivers/gpio/s5p_gpio.c
> +++ b/drivers/gpio/s5p_gpio.c
> @@ -353,7 +353,9 @@ static const struct udevice_id exynos_gpio_ids[] = {
>  	{ .compatible = "samsung,s5pc110-pinctrl" },
>  	{ .compatible = "samsung,exynos4210-pinctrl" },
>  	{ .compatible = "samsung,exynos4x12-pinctrl" },
> +#if IS_ENABLED(CONFIG_OF_UPSTREAM)
I just noticed, that this if should be inverted. Will be fixed in the
next patch. Sorry for the noise.
>  	{ .compatible = "samsung,exynos5250-pinctrl" },
> +#endif
>  	{ .compatible = "samsung,exynos5420-pinctrl" },
>  	{ .compatible = "samsung,exynos78x0-gpio" },
>  	{ }
> 
> -- 
> 2.54.0
> 

Best regards

Lukas Timmermann