From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 09A1F40DFB4 for ; Wed, 6 May 2026 15:11:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778080298; cv=none; b=AlMtdGOVrJseHQz/ejxekC1ECRnAKYRAd3i7AhRDb+T01uWnXgOxFMdKlf+9ZHxLtNzgOtwryHw7jJKTCNxzw1txwPBiOE0Rm2Aeju/nCbPaPmKUAz+/XbU+VV6T0THDPOJtCXCN0dt3kVOoZLFPEM/Pg1rMkDXxlvppLDkR+EE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778080298; c=relaxed/simple; bh=F5fhkEZyxmeKsS+7sWw0nNqrTbsDNl4GumucroQuQpA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=u/wYLPBc7WWdTIa1Z4xRC69XEPs4+GLI9nBvKJSBEpuTBXXXLxX58+cBV9AsQRssm/klBRyWlGHdr8W/CCeQAsTzK576GCMPVdvjX1r8sit7nXjLPddUQgZmxsIPIc58uqnHqgUqUA5mzwoA9qSpyBhJdEg1cN3KFeH0RTA31Jk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=idcbekky; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=XoEjMFLR; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="idcbekky"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="XoEjMFLR" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 646DUUoW1527798 for ; Wed, 6 May 2026 15:11:36 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=VAvDrLQhkJN+W48UK8rozA3z RdlMci8Z6g/AtmbwceE=; b=idcbekkyzbozSqhTzTY4QfVBSptwWKpb1+JW0fKT VgZAOljbDtn3V+96l/JmHfcXtgxLOsl3NlpIJZQ+MtuiWNsbDRNEandWiTDR1zAx 8ZfAFL3q7yuAFFSF/hHlin9394QGwjv/74acxgPrTffgmRTzA4WtCpATnI9Lzbw6 unVKOnT19/5MHAZQhFTXYyWJH6e+iIszPHpM/UH4dvsE/RRAxoRCK89N/IYCg8gy buNbM92vrTlUeiwXXxPLaaXMuCXFq7uCg1gFLTSAZnqAATrXi97506gCd08WHy5O AaraXuPUYuNzfy0qbgMuayElM2J1ruV6XVdA6g0ylBzCnA== Received: from mail-oi1-f198.google.com (mail-oi1-f198.google.com [209.85.167.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e01289uq9-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 06 May 2026 15:11:35 +0000 (GMT) Received: by mail-oi1-f198.google.com with SMTP id 5614622812f47-463a075e177so4993534b6e.2 for ; Wed, 06 May 2026 08:11:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778080295; x=1778685095; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=VAvDrLQhkJN+W48UK8rozA3zRdlMci8Z6g/AtmbwceE=; b=XoEjMFLRwl9sBYcKBqFi9/PxZj0LAfHVZubJm3yBhl4C0C88E/GxfIOCSa+KG2Ybax qxgNvxB+FIZ3YpnKSvvO3Hb/LVoAP6kxcrj6LpZZHJc8E08g+lLJbBzs31jTt8ctnbLb /u+oedB06sUrN7B6i3afBHC187OgMVs8jg+E5i4ClTR51wnCqUX/PlylLe79lvw//aHP pEFE6WPeuJhmvLPUqyda+EACBuOzEn+cq2962+4E34SgmFJ3rgnXWJyZ+WRar4GWY3sE 92LGx5vPlBn1Bos7CSVk77WfamaCv9Drdnt98H+b5bFmocHVeI3EgJv7wSo8iD07T4N5 HeIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778080295; x=1778685095; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VAvDrLQhkJN+W48UK8rozA3zRdlMci8Z6g/AtmbwceE=; b=JYT76DEZS+ZzafEtpC77qiwpt4QIn/Qss2niLozXTvSmYLuRbgJABUUwEZc9AFkqvE WMZMxhBTd5Ss45xG5BE6c1PMuLH4oW3+EC+84euvfY/m00yX377K/dxcKhgDwQ6SZjhq sqFcQJi6iFEap8imikIwpt8i3MYG4sGdoAwq1DDtwu+Ksjtf5W0nS5T9eDHuxBIXaBrm IOKYvMFvmNyPALzYmlb6aWcsrpDp3XnRS85h95KTaUsVA8f28IR70mCjzfDtCJRpNCDa fEV0oYaCceIzW9PYOECVKie1pBlle4TtfxdJSX7B6XZ+siWaCyNQ+glp8YcLapmE/lRq BrUQ== X-Forwarded-Encrypted: i=1; AFNElJ9CDlmriwjomWVn3KtHxZlLRUQdm4EcS5HLDDwF/QG3yKRFINxbx+tMLMB/3+hwIGTxpKiI+HKEi2qdjIY=@vger.kernel.org X-Gm-Message-State: AOJu0Yxh7E4+sA0UcAgxcwWfNZg6obpddEBqzJrX+pZCYXcU8744kxgq O8TBjCB7R1PdgoKkJz7KI7TL4XMyVPZiKQFsXvr63M7dJixl8wXVwK4KPhPdomq0IFzh7GUN+Eo QQJkWTbH6EQB/AXS9M0aF0a3FVpdvK3TytRnRoyykORgfQdXa37KE5KUV7kd/UIOGWGo= X-Gm-Gg: AeBDieuE1ijdeRF3lPh83+s5mxkpmuS67idL+svUTQLhxEb0lYVGAzHI1RNb/9pwfVu t/FybUnkmMObl13uozPU7hc+zt74XHj176Ie/ZsRHYem7hTUbfgORfeLaeazEwM9oh+oMJ+U/2H 9TxlWk3Gesehpw5NFq/Tp+g48mhx8kzKfFrlKi0EQRl6ctOXXF6Pgv+BA8l4U+++4IxyDTgLc8I eidjMHI317zz3WYAuIduQ+7W2lbHeOOj+KXN86Lbloj2QJ6+3Rt0K7zfpSUB4JzQQWbJRGWcclz bM29k8ns/rR7UpUi8MQXdUBPxUEQ8eOUV/NEW3Z8n2ljc98JnQKYG0GT4eFjM6Q5xRRoEAYYqWL IipAcJTKgGEIg4x14njAcmsvv8RPUfunp2T+InhgU3BvtubP8q4uF0Q== X-Received: by 2002:a05:6808:c40d:b0:45e:a592:5903 with SMTP id 5614622812f47-480424f529cmr2108728b6e.32.1778080294945; Wed, 06 May 2026 08:11:34 -0700 (PDT) X-Received: by 2002:a05:6808:c40d:b0:45e:a592:5903 with SMTP id 5614622812f47-480424f529cmr2108698b6e.32.1778080294364; Wed, 06 May 2026 08:11:34 -0700 (PDT) Received: from mai.linaro.org ([2a05:6e02:1041:c10:41ef:7b80:b3e8:2c1a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48e53116a9fsm28115265e9.8.2026.05.06.08.11.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 May 2026 08:11:33 -0700 (PDT) Date: Wed, 6 May 2026 17:11:31 +0200 From: Daniel Lezcano To: "Markus Schneider-Pargmann (TI.com)" Cc: Daniel Lezcano , Thomas Gleixner , Vishal Mahaveer , Kevin Hilman , Dhruva Gole , Sebin Francis , Kendall Willis , Akashdeep Kaur , linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 2/3] clocksource/drivers/timer-ti-dm: Add clocksource support Message-ID: References: <20260309-topic-ti-dm-clkevt-v6-16-v4-0-bb8d2a04c45e@baylibre.com> <20260309-topic-ti-dm-clkevt-v6-16-v4-2-bb8d2a04c45e@baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260309-topic-ti-dm-clkevt-v6-16-v4-2-bb8d2a04c45e@baylibre.com> X-Proofpoint-GUID: GF46kmQKPgcEBWZ8C9ecifx3XNmffYz1 X-Proofpoint-ORIG-GUID: GF46kmQKPgcEBWZ8C9ecifx3XNmffYz1 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA2MDE1MCBTYWx0ZWRfXydo0aGQMuKJP yMkYtzwOW6jkr4XKxsY1G4f+UhbTwv1ZZgwS7eY38qxQdHDF/PlwZqFmzVTV1NMWG5n0Das423y dX4dMTEQD9VUz+Tt18aO7Nglm1/0jsctiHlv9yxx3pnZsoZPbeyDTNb/NbRnNAXLg/Zycb8owuV xLcp/PiQjn6lQLmzOTj2Ww+1RmhuVRHQiAHvS4dZEVsBbOgMkBQU4rSIGomIDHyaUhMER8PjUMm RXGz/rxawjLNWLyKK9GmBJ+P9M8PqKygwxVT4PQiE97qfZWLQ2ybO17eNJcgkbY70k4VGbBGQol ngLHYD3IaNJLrcWSWZ1pZAY60AT3KgSPXdoGwe9CM3wUx1FBxp3IpYw/m8hs6T4CPhwPov8kdFt zX4cm2zsZp2jTgd+W0k6bapttZ0hpZDWfaHTIvUtF970LkLqXtiZDhmg3RXkOtHMM30MWcF378i KOSLzT+AWUD4m5+14cw== X-Authority-Analysis: v=2.4 cv=A8xc+aWG c=1 sm=1 tr=0 ts=69fb5a27 cx=c_pps a=4ztaESFFfuz8Af0l9swBwA==:117 a=xqWC_Br6kY4A:10 a=kj9zAlcOel0A:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=sozttTNsAAAA:8 a=IpJZQVW2AAAA:8 a=JElLfZU68dzkMRh_SLMA:9 a=CjuIK1q_8ugA:10 a=TPnrazJqx2CeVZ-ItzZ-:22 a=IawgGOuG5U0WyFbmm1f5:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-06_01,2026-05-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 spamscore=0 phishscore=0 bulkscore=0 clxscore=1015 lowpriorityscore=0 malwarescore=0 adultscore=0 impostorscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605060150 On Mon, Mar 09, 2026 at 11:45:47AM +0100, Markus Schneider-Pargmann wrote: > Add support for using the TI Dual-Mode Timer as a clocksource. The > driver automatically picks the first timer that is marked as always-on > on with the "ti,timer-alwon" property to be the clocksource. > > The timer can then be used for CPU independent time keeping. > > Signed-off-by: Markus Schneider-Pargmann (TI.com) > --- > drivers/clocksource/timer-ti-dm.c | 137 ++++++++++++++++++++++++++++++++++++++ > 1 file changed, 137 insertions(+) [ ... ] > > timer->pdev = pdev; > > + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > + > + if (omap_dm_timer_clocksource_base && res && > + res->start == omap_dm_timer_clocksource_base && > + !IS_ERR_OR_NULL(timer->fclk)) { > + ret = omap_dm_timer_setup_clocksource(timer); > + if (ret) > + return ret; > + } No please, this is very confusing. timer->capability |= OMAP_TIMER_ALWON is available res->start has not to be checked against omap_dm_timer_clocksource_base Basically, you should endup with one change in this probe function. if (!omap_dm_timer_clocksource_base) { ret = omap_dm_timer_setup_clocksource(timer); if (ret) return ret; } I suggest to do some cleanups in the driver in order to set the scene for your changes. > + > pm_runtime_enable(dev); > > if (!timer->reserved) { > > -- > 2.53.0 > --