From: Vaibhav Gupta <vaibhavgupta40@gmail.com>
To: Harshitha Ramamurthy <hramamurthy@google.com>
Cc: Joshua Washington <joshwash@google.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Willem de Bruijn <willemb@google.com>,
Ankit Garg <nktgrg@google.com>,
Tim Hostetler <thostet@google.com>,
Alok Tiwari <alok.a.tiwari@oracle.com>,
John Fraker <jfraker@google.com>, Matt Olson <maolson@google.com>,
Praveen Kaligineedi <pkaligineedi@google.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] gve: Use generic power management
Date: Wed, 6 May 2026 16:21:34 +0000 [thread overview]
Message-ID: <aftqjk7YOQJGh0e3@gmail.com> (raw)
In-Reply-To: <CAEAWyHf3x=sCefMKkUvRq6hq8qd_ALM=MPvnN57xmyE5VCN+CA@mail.gmail.com>
> > - .suspend = gve_suspend,
> > - .resume = gve_resume,
> > -#endif
> > + .driver.pm = &gve_pm_ops,
>
> Thanks for the patch! A minor suggestion: could you wrap this in pm_sleep_ptr()?
>
> Also, please include the net-next prefix in the subject line when posting v2.
>
> With those changes, feel free to add:
> Reviewed-by: Harshitha Ramamurthy <hramamurthy@google.com>
>
> Thanks,
> Harshitha
>
Thanks for your input Harshitha! I have made the suggested amends, and I will
send the v2 in reply to my v1 patch, as I have to include the review tag of
Alexander as well.
Thanks
Vaibhav
> > };
> >
> > module_pci_driver(gve_driver);
>
> > --
> > 2.53.0
> >
next prev parent reply other threads:[~2026-05-06 16:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-04 18:21 [PATCH v1] gve: Use generic power management Vaibhav Gupta
2026-05-05 16:08 ` Alexander Lobakin
2026-05-05 17:28 ` Harshitha Ramamurthy
2026-05-06 16:21 ` Vaibhav Gupta [this message]
2026-05-06 16:47 ` [PATCH net-next v2] " Vaibhav Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aftqjk7YOQJGh0e3@gmail.com \
--to=vaibhavgupta40@gmail.com \
--cc=alok.a.tiwari@oracle.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hramamurthy@google.com \
--cc=jfraker@google.com \
--cc=joshwash@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maolson@google.com \
--cc=netdev@vger.kernel.org \
--cc=nktgrg@google.com \
--cc=pabeni@redhat.com \
--cc=pkaligineedi@google.com \
--cc=thostet@google.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.