Re: [PATCH] Remove the deprecated glusterfs block driver

[Kevin Wolf <kwolf@redhat.com>]

Am 07.05.2026 um 08:08 hat Philippe Mathieu-Daudé geschrieben:
> On 7/5/26 07:16, Thomas Huth wrote:
> > From: Thomas Huth <thuth@redhat.com>
> > 
> > Glusterfs has been marked as deprecated since QEMU v9.2, and as far
> > as I know, nobody spoke up 'til today that it should be kept.
> > The listed e-mail address integration@gluster.org in our MAINTAINERS
> > file seems to be bouncing nowadays, and looking at their website
> > https://www.gluster.org/ the most recent news are from 2020 / 2021 ...
> > so it seems like there is really hardly any interest in Glusterfs
> > anymore. Thus it's time to remove the code now from QEMU.
> > 
> > Signed-off-by: Thomas Huth <thuth@redhat.com>
> > ---
> >   MAINTAINERS                                   |    6 -
> >   docs/about/deprecated.rst                     |    8 -
> >   docs/about/removed-features.rst               |    7 +
> >   docs/system/device-url-syntax.rst.inc         |   39 -
> >   docs/system/qemu-block-drivers.rst.inc        |   84 -
> >   meson.build                                   |   47 -
> >   qapi/block-core.json                          |   52 -
> >   block/gluster.c                               | 1644 -----------------
> >   tests/qtest/modules-test.c                    |    3 -
> >   block/meson.build                             |    1 -
> >   meson_options.txt                             |    2 -
> >   .../ci/setup/debian/debian-13-ppc64le.yaml    |    1 -
> >   .../ci/setup/ubuntu/ubuntu-2404-aarch64.yaml  |    1 -
> >   .../ci/setup/ubuntu/ubuntu-2404-s390x.yaml    |    1 -
> >   scripts/coverity-scan/coverity-scan.docker    |    1 -
> >   scripts/coverity-scan/run-coverity-scan       |    2 +-
> >   scripts/meson-buildoptions.sh                 |    3 -
> >   .../dockerfiles/debian-amd64-cross.docker     |    1 -
> >   .../dockerfiles/debian-arm64-cross.docker     |    1 -
> >   .../dockerfiles/debian-mips64el-cross.docker  |    1 -
> >   .../dockerfiles/debian-mipsel-cross.docker    |    1 -
> >   .../dockerfiles/debian-ppc64el-cross.docker   |    1 -
> >   .../dockerfiles/debian-riscv64-cross.docker   |    1 -
> >   .../dockerfiles/debian-s390x-cross.docker     |    1 -
> >   tests/docker/dockerfiles/debian.docker        |    1 -
> >   .../dockerfiles/fedora-rust-nightly.docker    |    1 -
> >   tests/docker/dockerfiles/fedora.docker        |    1 -
> >   tests/docker/dockerfiles/opensuse-leap.docker |    1 -
> >   tests/docker/dockerfiles/ubuntu2204.docker    |    1 -
> >   tests/lcitool/projects/qemu.yml               |    1 -
> >   30 files changed, 8 insertions(+), 1907 deletions(-)
> >   delete mode 100644 block/gluster.c
> 
> Need a rebase on top of commit f168046842c ("cocci: Do not
> initialize variable used by QLIST_FOREACH macro").
> 
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> Tested-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> 
> Apparently we could now revert commits a6b257a08e3 ("file-posix:
> Handle undetectable alignment") and 3a20013fbb2 ("block: posix:
> Always allocate the first block"). Not sure if that could be
> useful for other backends or harmless. Cc'ing Nir.

I haven't looked at the specific code changes, but if it's file-posix,
it's unrelated to the builtin gluster block driver in QEMU, but a file
on a glusterfs mount on the host. We still need to behave correctly for
that. (And if it can happen with glusterfs, it probably can happen with
other filesystems, too.)

Kevin