From: Johan Hovold <johan@kernel.org>
To: Crescent Hsieh <crescentcy.hsieh@moxa.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 4/4] usb: serial: mxuport: add sysfs control for UART FIFO
Date: Thu, 7 May 2026 17:59:05 +0200 [thread overview]
Message-ID: <afy2yeDTHiVFkPmy@hovoldconsulting.com> (raw)
In-Reply-To: <20260324035041.352190-5-crescentcy.hsieh@moxa.com>
On Tue, Mar 24, 2026 at 11:50:41AM +0800, Crescent Hsieh wrote:
> Add a per-port sysfs attribute, uart_fifo, to allow userspace to enable
> or disable the UART FIFO at runtime.
Why would you want to do that?
We should try to avoid driver specific sysfs knobs.
> Map the requested state to the RQ_VENDOR_SET_FIFO_DISABLE vendor command
> and track the current FIFO setting in the per-port private data.
>
> Initialize the FIFO state during port probe and remove the sysfs
> attribute when the port is released.
Johan
next prev parent reply other threads:[~2026-05-07 15:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-24 3:50 [PATCH v1 0/4] usb: serial: mxuport: extend MXU50U support and runtime controls Crescent Hsieh
2026-03-24 3:50 ` [PATCH v1 1/4] usb: serial: mxuport: add support for more MXU50U UART devices Crescent Hsieh
2026-05-07 14:13 ` Johan Hovold
2026-03-24 3:50 ` [PATCH v1 2/4] usb: serial: mxuport: handle SEND_NEXT tx flow control Crescent Hsieh
2026-05-07 14:40 ` Johan Hovold
2026-03-24 3:50 ` [PATCH v1 3/4] usb: serial: mxuport: support serial interface mode configuration Crescent Hsieh
2026-05-07 15:56 ` Johan Hovold
2026-03-24 3:50 ` [PATCH v1 4/4] usb: serial: mxuport: add sysfs control for UART FIFO Crescent Hsieh
2026-05-07 15:59 ` Johan Hovold [this message]
2026-05-12 11:28 ` Crescent Hsieh
2026-05-13 8:20 ` Johan Hovold
2026-05-13 8:48 ` Greg Kroah-Hartman
2026-05-15 9:08 ` Crescent Hsieh
2026-05-15 9:17 ` Greg Kroah-Hartman
2026-03-30 7:24 ` [PATCH v1 0/4] usb: serial: mxuport: extend MXU50U support and runtime controls Crescent Hsieh
2026-03-30 7:54 ` Johan Hovold
2026-04-27 3:37 ` Crescent Hsieh
2026-04-27 10:43 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afy2yeDTHiVFkPmy@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=crescentcy.hsieh@moxa.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.