From: Bruce Richardson <bruce.richardson@intel.com>
To: Ciara Loftus <ciara.loftus@intel.com>
Cc: <dev@dpdk.org>, Mukul Katiyar <mukul@versa-networks.com>,
<stable@dpdk.org>
Subject: Re: [PATCH v2 1/2] net/ice: properly handle TM hierarchy deletion
Date: Thu, 7 May 2026 14:11:16 +0100 [thread overview]
Message-ID: <afyPdAwI6_ClTYFK@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <20260507125930.1668860-1-ciara.loftus@intel.com>
On Thu, May 07, 2026 at 12:59:29PM +0000, Ciara Loftus wrote:
> From: Mukul Katiyar <mukul@versa-networks.com>
>
> When a TM hierarchy is fully deleted and then committed, the hardware
> scheduler nodes may be left with any bandwidth limits that were
> programmed by the previous hierarchy commit. These stale limits may
> remain in effect the next time the device starts, permanently throttling
> traffic even though the TM hierarchy was removed.
>
> Fix this by resetting all descendant hardware scheduler nodes to their
> default state when committing an empty hierarchy. Also restore the port
> queue count to its hardware default and clear the committed flag so the
> port starts cleanly without any TM configuration applied.
>
> Fixes: 715d449a965b ("net/ice: enhance Tx scheduler hierarchy support")
> Cc: stable@dpdk.org
>
> Signed-off-by: Mukul Katiyar <mukul@versa-networks.com>
> Signed-off-by: Ciara Loftus <ciara.loftus@intel.com>
> ---
> v2:
> * Ensure restore is only performed if a hierarchy has already been
> committed
> ---
> .mailmap | 1 +
> drivers/net/intel/ice/ice_tm.c | 24 ++++++++++++++++++++++--
> 2 files changed, 23 insertions(+), 2 deletions(-)
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
next prev parent reply other threads:[~2026-05-07 13:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-07 12:59 [PATCH v2 1/2] net/ice: properly handle TM hierarchy deletion Ciara Loftus
2026-05-07 12:59 ` [PATCH v2 2/2] net/ice: fix shaper profile reference count tracking Ciara Loftus
2026-05-07 13:11 ` Bruce Richardson [this message]
2026-05-07 13:39 ` [PATCH v2 1/2] net/ice: properly handle TM hierarchy deletion Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afyPdAwI6_ClTYFK@bricha3-mobl1.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=ciara.loftus@intel.com \
--cc=dev@dpdk.org \
--cc=mukul@versa-networks.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.