From: Florian Westphal <fw@strlen.de>
To: Li Xiasong <lixiasong1@huawei.com>
Cc: netfilter-devel@vger.kernel.org,
Pablo Neira Ayuso <pablo@netfilter.org>,
Phil Sutter <phil@nwl.cc>,
coreteam@netfilter.org, yuehaibing@huawei.com,
zhangchangzhong@huawei.com, weiyongjun1@huawei.com
Subject: Re: [PATCH nft v2 0/2] netfilter: fix expectation reference leaks
Date: Thu, 7 May 2026 20:16:44 +0200 [thread overview]
Message-ID: <afzXDEIOvOSfHC34@strlen.de> (raw)
In-Reply-To: <20260507140423.3734545-1-lixiasong1@huawei.com>
Li Xiasong <lixiasong1@huawei.com> wrote:
> this series fixes two expectation reference leaks in netfilter.
No need to resend, but [PATCH nft] means: 'this is nftables.git' (i.e.
userspace). This should be [PATCH v2 nf].
> The first patch simplifies SIP REGISTER handling by validating helper
> availability before expectation allocation, removing an early-return
> leak path.
>
> The second patch adds a missing nf_ct_expect_put() in nft_ct expectation
> object evaluation to balance the allocation reference.
Thanks for v2. Reviewed-by: Florian Westphal <fw@strlen.de>
prev parent reply other threads:[~2026-05-07 18:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-07 14:04 [PATCH nft v2 0/2] netfilter: fix expectation reference leaks Li Xiasong
2026-05-07 14:04 ` [PATCH nft v2 1/2] netfilter: nf_conntrack_sip: get helper before allocating expectation Li Xiasong
2026-05-07 14:04 ` [PATCH nft v2 2/2] netfilter: nft_ct: fix missing expect put in obj eval Li Xiasong
2026-05-07 18:16 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afzXDEIOvOSfHC34@strlen.de \
--to=fw@strlen.de \
--cc=coreteam@netfilter.org \
--cc=lixiasong1@huawei.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=phil@nwl.cc \
--cc=weiyongjun1@huawei.com \
--cc=yuehaibing@huawei.com \
--cc=zhangchangzhong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.