From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f44.google.com (mail-dl1-f44.google.com [74.125.82.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 27242353ED9 for ; Wed, 20 May 2026 05:27:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779254864; cv=none; b=YnuAJpkMKImEwjgT/E88z19UZ5RUZpvpwDL1E/aMbcFCYhIx08FVbP6wAAEHzyIVSxs6zHHEkgqR1S6Xz2hyVY6L9XQJN0e2HzfECfwc3iR8GDtjrFwpUwCI/nU6581YozH0u5tqgXL5U/KeSI7gHh94VVNx/ZqLJ71tSfrzf9s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779254864; c=relaxed/simple; bh=l0zRM2r+AQUNnb8A268apqaIB3mS80ht+d+1M1KKNFE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=K3lZUOO+ZcgWk6xGJcoPBdU9PczCMMdq4SLwS5MvoDve6/i0WTAQkSZ8icAT1D00TaCluG4ovA/o4FoW1rSa9gavxsfMuDrVfPdY9PPM0uNbYyaRIEKAXM7cQDHmaXxqQuo/FJicFSG/kZL6QBsyzC1wGQfCp16tkQDUoCYlk0U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VYNJtPac; arc=none smtp.client-ip=74.125.82.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VYNJtPac" Received: by mail-dl1-f44.google.com with SMTP id a92af1059eb24-1332772f6b3so5527318c88.1 for ; Tue, 19 May 2026 22:27:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779254862; x=1779859662; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=tWnObvvYz2jxVvNJZ4O4Otjd3qRMPJxYo5uUEck8zsM=; b=VYNJtPacffiX92QpyrOU3Lyjiq8y8ThCuoAAkgBCYCptHiXE1n9o72gsaMSUmdzi+C 3RCRowkltdAC1/1x2ZA5jwW6rbRQYvxJ9x1v0xrJMOqh7uLemCY5uJH8ve7LsEjNnGlx oV0KNVE0D9y9v/fOltAdg2TFCxTy/Q8GoUQ4QhZld4mXawtyqQkdnTakHz5gIEfuZOd4 do6LRUIsh+oDtslTnLsjYvUQC6neJwikmm40m8oCBmcDcJv1ZGZmLZrldMqY33lxxRQQ laXNIk/ukJBcX2qLKsBrLmT/XTSnOB99uU5iOuZZS8ZGXpoL05YHG1w6L/BoiN7/7QIn rjLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779254862; x=1779859662; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tWnObvvYz2jxVvNJZ4O4Otjd3qRMPJxYo5uUEck8zsM=; b=RVSeky/y95iIMZDDonfvHKVwlSqhkLMU52sD7PnuvjKBYZ27K4m6SYG0JZ0YGZ2wDs U+Drv3gQSJU0zY22dTHvzzHfUkq3el9jFHjn8W+Rcr42KRn6Z/DgWmnvbUpjCjk4z00g at0HncQ3Guds08vqjYQjQtW14PBvlLkZ57Qps5b9bzvKWd+wX7uKGp/WSN816D1sD1Py Q5QrBfdErH+lgx/Z+IWM2SKE3QnbRrXNu+zqeKH1HqElTVeq7iDyhrgoghxkygFFJiF2 xBnE8h0uy/IrTUgugCl4jqWpYE8jaGqOXZt4gVQdvH3O58P9H3K0A+5vJr+q0knz+20W dWpA== X-Forwarded-Encrypted: i=1; AFNElJ8Cek+9LGtq39XPp2BYjLWTEQstqpal5vTf5IjliznGYQSigWEpofiST1O40mS2zVja2+5/bkpoVv7RTww=@vger.kernel.org X-Gm-Message-State: AOJu0YzurOhdzeBcqb8qwYe16Y7Ru1i3HanBDF6+mFpWG+bvTXgMZlr8 Zg+ukD+EedGa4eIYXp14JGGXN/6c3E9wzPPChrUx8IbzwXM+8w9JkESa X-Gm-Gg: Acq92OFdaSMg5g+7MdOhUwP3eK69fSimH5IEUeHPIY3CCO2Ev/XEG/h7AFugyj34JFx +7FUkfyWwiofGTRZ/3WXfeQ/sdAZTJqTvea8gEytdT8IndlOSffef3ybsZwWSk/SFrtzMsl3UmK Den5hdVO2rruyKLlyvAJyRzwrLiAxnj9t9GzLsB8U2qpGqGbBEaeLiiL54djvTmPh/eTG0HxzsG DyyvMnGv/DJn1w5hv9rwF3BOv0ILbylZBNG+gfHg1nqFMAqljNY6SEGtyEedBh0L5TmGvbXHDHZ 9bNN7g/a62VFNMSYmsbx3coOhAZYpysXjFNo+hpBQx/m/FaMQHzO4G5fgfIqmnuOoQe4LQYJjYo az/dvIcjfCiI10tlaF94sZpTHC+MrQNUVQeEKA3TzABZkUy159qTP4I0TmqB83kuVeZsWrSSb+Y 0wjkS8IoUmoof8dUfMOlG6+YHHzI/XA7ML9T/Ue48KDl3F0o23FHVPRS80a84uzppL X-Received: by 2002:a05:7022:e14:b0:135:d5d1:514 with SMTP id a92af1059eb24-135d5d1061cmr2290514c88.14.1779254861871; Tue, 19 May 2026 22:27:41 -0700 (PDT) Received: from google.com ([2a00:79e0:2ebe:8:7677:c3e6:c92a:e780]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-134cbdcf140sm25863329c88.5.2026.05.19.22.27.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2026 22:27:41 -0700 (PDT) Date: Tue, 19 May 2026 22:27:37 -0700 From: Dmitry Torokhov To: Bartosz Golaszewski Cc: Linus Walleij , Bartosz Golaszewski , Geert Uytterhoeven , Frank Rowand , Mika Westerberg , Andy Shevchenko , Aaro Koskinen , Janusz Krzysztofik , Tony Lindgren , Russell King , Jonathan Corbet , Shuah Khan , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH v2 5/6] gpio: remove machine hogs Message-ID: References: <20260309-gpio-hog-fwnode-v2-0-4e61f3dbf06a@oss.qualcomm.com> <20260309-gpio-hog-fwnode-v2-5-4e61f3dbf06a@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, May 19, 2026 at 05:46:50PM -0700, Dmitry Torokhov wrote: > On Mon, Mar 09, 2026 at 01:42:41PM +0100, Bartosz Golaszewski wrote: > > With no more users, remove legacy machine hog API from the kernel. > > > > Reviewed-by: Linus Walleij > > Reviewed-by: Andy Shevchenko > > Signed-off-by: Bartosz Golaszewski > > Argh! What is the replacement for this? I have patches for rsk7203 to > use them to get rid of legacy gpio use, like this: > > diff --git a/arch/sh/boards/mach-rsk/devices-rsk7203.c b/arch/sh/boards/mach-rsk/devices-rsk7203.c > index f8760a91e2f1..5bbd3b31cffb 100644 > --- a/arch/sh/boards/mach-rsk/devices-rsk7203.c > +++ b/arch/sh/boards/mach-rsk/devices-rsk7203.c > @@ -12,7 +12,7 @@ > #include > #include > #include > -#include > +#include > #include > #include > #include > @@ -165,6 +165,19 @@ static const struct platform_device_info rsk7203_devices[] __initconst = { > }, > }; > > +/* The base of the function GPIOs in the flat enum */ > +#define SH7203_FN_BASE GPIO_FN_PINT7_PB > + > +static struct gpiod_hog rsk7203_gpio_hogs[] = { > + GPIO_HOG("sh7203_pfc-fn", GPIO_FN_TXD0 - SH7203_FN_BASE, > + "TXD0", GPIO_ACTIVE_HIGH, GPIOD_ASIS), > + GPIO_HOG("sh7203_pfc-fn", GPIO_FN_RXD0 - SH7203_FN_BASE, > + "RXD0", GPIO_ACTIVE_HIGH, GPIOD_ASIS), > + GPIO_HOG("sh7203_pfc-fn", GPIO_FN_IRQ0_PB - SH7203_FN_BASE, > + "IRQ0_PB", GPIO_ACTIVE_HIGH, GPIOD_ASIS), > + { } > +}; > + > static int __init rsk7203_devices_setup(void) > { > struct platform_device *pd; > @@ -172,12 +185,10 @@ static int __init rsk7203_devices_setup(void) > int i; > > /* Select pins for SCIF0 */ > - gpio_request(GPIO_FN_TXD0, NULL); > - gpio_request(GPIO_FN_RXD0, NULL); > + gpiod_add_hogs(rsk7203_gpio_hogs); > > /* Setup LAN9118: CS1 in 16-bit Big Endian Mode, IRQ0 at Port B */ > __raw_writel(0x36db0400, 0xfffc0008); /* CS1BCR */ > - gpio_request(GPIO_FN_IRQ0_PB, NULL); > > error = software_node_register_node_group(rsk7203_swnodes); > if (error) { > > > If there is no replacement maybe we can resurrect this? Or shoudl we > have add swnode support for hogs? Hmm, I guess it is already there so I should simply switch. Sorry about the noise. Thanks. -- Dmitry