All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Uwe Kleine-König (The Capable Hub)" <u.kleine-koenig@baylibre.com>
To: Hans Verkuil <hverkuil+cisco@kernel.org>
Cc: linux-media@vger.kernel.org
Subject: Re: [v1] media: Use named initializers for arrays of i2c_device_data
Date: Wed, 20 May 2026 15:37:05 +0200	[thread overview]
Message-ID: <ag24InIgERctIZyo@monoceros> (raw)
In-Reply-To: <d5a34e40-2570-44d7-80e8-0646f6f0fe68@kernel.org>

[-- Attachment #1: Type: text/plain, Size: 1095 bytes --]

Hello Hans,

On Wed, May 20, 2026 at 09:16:18AM +0200, Hans Verkuil wrote:
> On 16/05/2026 08:26, Uwe Kleine-König (The Capable Hub) wrote:
> > On Fri, May 15, 2026 at 11:24:38AM -0700, Patchwork Integration wrote:
> >> Thanks for your patches! Unfortunately the Media CI robot detected some
> >> issues:
> > 
> > I wonder about the Media CI robot testing iio and hwmon patches. What is
> > their source? (Hmm, I guess that's because I forgot to remove the
> > prerequisite-patch-id lines from the patch.)
> 
> Yes, that's weird. Note that you also forgot to add a second '---'
> line before the 'drivers/media/cec/i2c/tda9950.c               |  2 +-' line.
> 
> When I tried to apply your patch with 'git am' it thought the include/linux/mod_devicetable.h
> diff was part of the patch because of that missing line.

I don't know your tooling, but git-am gets that right on my end (i.e it stops the
commit log at the first (and here only) '---' and also ignores the
indented patch to include/.

Sorry this is more complicated for you than I intended.

Best regards
Uwe

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

      reply	other threads:[~2026-05-20 13:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-15 16:15 [PATCH v1] media: Use named initializers for arrays of i2c_device_data Uwe Kleine-König (The Capable Hub)
     [not found] ` <6a0764e6.ec7b09a3.350c1e.ff87@mx.google.com>
2026-05-16  6:26   ` [v1] " Uwe Kleine-König (The Capable Hub)
2026-05-20  7:16     ` Hans Verkuil
2026-05-20 13:37       ` Uwe Kleine-König (The Capable Hub) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ag24InIgERctIZyo@monoceros \
    --to=u.kleine-koenig@baylibre.com \
    --cc=hverkuil+cisco@kernel.org \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.