Re: [PATCH 1/2] platform/x86: hp-wmi: Add support for Omen 16-b1xxx (8A13)

[Krishna Chomal <krishna.chomal108@gmail.com>]

On Wed, May 13, 2026 at 12:39:15PM -0700, foobisdweik wrote:
>Add board name 8A13 (OMEN by HP Laptop 16-b1xxx, 12th-gen Intel/RTX 30
>series) to the Omen thermal-profile, timed-thermal-profile, and Victus-S
>DMI lists.
>

The DMI lists are exclusively checked at every reference so adding to
Victus-S seems sufficient, as addition to omen thermal-profile and
timed-thermal-profile would not make a difference.

>The 8A13 firmware exposes the standard Omen "PerformanceControl" WMI
>feature, uses the legacy EC thermal-profile offset (0x95), and
>implements the Victus-S-style GM2D/GM2E WMI methods at EC offsets
>0xB0..0xB3 (RPM1..RPM4 tach) and 0x34..0x35 (SRP1/SRP2 setpoints).
>This makes it identical in interface to its same-era sibling 8A44
>(Omen 16-n0xxx), so reuse omen_v1_legacy_thermal_params.
>
>After this change /sys/firmware/acpi/platform_profile reports
>cool/balanced/performance and the hp hwmon device exposes per-fan
>tachs plus the manual-mode pwm control on Omen 16-b1xxx.
>
>Signed-off-by: foobisdweik <dweikmferris@gmail.com>
>---
> drivers/platform/x86/hp/hp-wmi.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/platform/x86/hp/hp-wmi.c b/drivers/platform/x86/hp/hp-wmi.c
>index 24c151289dd3..389506a6d2e3 100644
>--- a/drivers/platform/x86/hp/hp-wmi.c
>+++ b/drivers/platform/x86/hp/hp-wmi.c
>@@ -157,7 +157,7 @@ static const char * const omen_thermal_profile_boards[] = {
> 	"886B", "886C", "88C8", "88CB", "88D1", "88D2", "88F4", "88F5", "88F6",
> 	"88F7", "88FD", "88FE", "88FF",
> 	"8900", "8901", "8902", "8912", "8917", "8918", "8949", "894A", "89EB",
>-	"8A15", "8A42",
>+	"8A13", "8A15", "8A42",
> 	"8BAD",
> 	"8C58",
> 	"8E41",
>@@ -177,7 +177,7 @@ static const char * const omen_thermal_profile_force_v0_boards[] = {
>  * "balanced" when reaching zero.
>  */
> static const char * const omen_timed_thermal_profile_boards[] = {
>-	"8A15", "8A42",
>+	"8A13", "8A15", "8A42",
> 	"8BAD",
> };
>
>@@ -189,6 +189,10 @@ static const char * const victus_thermal_profile_boards[] = {
>
> /* DMI Board names of Victus 16-r and Victus 16-s laptops */
> static const struct dmi_system_id victus_s_thermal_profile_boards[] __initconst = {
>+	{
>+		.matches = { DMI_MATCH(DMI_BOARD_NAME, "8A13") },
>+		.driver_data = (void *)&omen_v1_legacy_thermal_params,
>+	},
> 	{
> 		.matches = { DMI_MATCH(DMI_BOARD_NAME, "8A44") },
> 		.driver_data = (void *)&omen_v1_legacy_thermal_params,
>-- 
>2.54.0
>