From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D5B553D88E3 for ; Wed, 20 May 2026 10:47:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779274054; cv=none; b=csbKldZuE51tJA60IMiowD8TonfDYZpi7MOoKIdSKcg+QMp+0Xl3hDgtajmSAfvj32Hm1ANgcCPDHtjdB5SqMBY+sHTs1gOIS7PRF/HRhphCYz4exzY+kCB1Vbqm51CROSygQ5SII+BAyluU68mSjrRCRGY1finkuniaYvC2QBg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779274054; c=relaxed/simple; bh=68HhIE2EAQwt4+Q2eaTzkkzGc+va/8UEbKUJhjEuM8o=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZMHtcS4VFzD1zxzWB0hmwF58hK0jgLzZ3sGnWVula7Ow1eoUIU7C9sAaOQXkz2kGwp3Z2DzNCRvxDhPiI4ymsE2e4qbhxbGOGMvXs8hkJCWRulMPLAy0eZ8uUe/bgszew/4v0umvpEyTSw0HR4/x9OZweytMm1U0gWHkoAv87bY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=DGp9NnvL; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="DGp9NnvL" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1779274051; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PEta+uiz2+Tre2/Q69yFNnbDcTAxkjevfo50+NVEvkU=; b=DGp9NnvLxsOtZYkcOds5YdDsj1alay14l/gOQ+Kp016SGKKDfG6eDHipOuYWPI+u0JYI6l pFq+TvHiPUJT+K8mHBkcVaLuh2cXy9/uPuWEsDATTVJ5l5VVlAdWUOOrZQPWrbp8iAtIkr m3OWMdzaprl5Y0G/j5KedDYBYsPW8vw= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-79-nph68kbVPQiuzPbNmtqxoQ-1; Wed, 20 May 2026 06:47:26 -0400 X-MC-Unique: nph68kbVPQiuzPbNmtqxoQ-1 X-Mimecast-MFC-AGG-ID: nph68kbVPQiuzPbNmtqxoQ_1779274043 Received: from mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.95]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 666891956058; Wed, 20 May 2026 10:47:22 +0000 (UTC) Received: from localhost (unknown [10.43.135.229]) by mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8F4D81684; Wed, 20 May 2026 10:47:17 +0000 (UTC) Date: Wed, 20 May 2026 12:47:15 +0200 From: Miroslav Lichvar To: John Stultz Cc: David Woodhouse , Richard Cochran , Wen Gu , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Thomas Gleixner , Stephen Boyd , Anna-Maria Behnsen , Frederic Weisbecker , Shuah Khan , Peter Zijlstra , Thomas =?iso-8859-1?Q?Wei=DFschuh?= , Arnd Bergmann , Julien Ridoux , Ryan Luu , linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH v2 2/8] timekeeping: Account for clawback adjustment in ntp_error Message-ID: References: <20260517220326.4625-1-dwmw2@infradead.org> <20260517220326.4625-3-dwmw2@infradead.org> <0cf0c9451c38854b8114786d0c03342d06ebc3d1.camel@infradead.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Scanned-By: MIMEDefang 3.6 on 10.30.177.95 On Tue, May 19, 2026 at 12:28:06PM -0700, John Stultz wrote: > On Tue, May 19, 2026 at 3:04 AM David Woodhouse wrote: > But yea, it does get subtle and complicated, which is all the more > reason to make sure we have things well documented. > > > > Miroslav's review and input here would also be good. > > > > Ack. Thomas had nudged me to add Miroslav to Cc, which > > get_maintainers.pl had not. > > Yeah. Maybe it would be good to get Miroslav added as a reviewer in > the MAINTAINERS file. > > Miroslav: Any objection to that? I'm ok with that, but I can't promise to provide any actual reviews. Loading all that context needed to understand the code is painful. It would be so nice if it could be simplified by switching to 64-bit multiplier. -- Miroslav Lichvar