Re: [Linux Kernel 7.0.7] [hp_wmi] EC layout for board 8C9C unsupported

[Krishna Chomal <krishna.chomal108@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2908 bytes --]

On Fri, May 15, 2026 at 03:21:46PM -0500, Bogdan Nicolae wrote:
>Krishna,
>
>Well, no, power profiles do not work at all. The system is usable, but
>not controllable. I tried both power-profiles-daemon and tuned-ppd,
>neither worked.
>

Oh, this was unexpected. Your board (8C9C) was the first to be added in this
category so I assumed it was working fine all along. What about fan
control via sysfs (/sys/devices/platform/hp-wmi/hwmon/*), does that
work? Your device should support AUTO/MAX/MANUAL - all three modes.

>Here is the EC hex dump of /sys/kernel/debug/ec/ec0/io:
>0000000 0000 0000 0100 0040 ffff 00ff 00ff 011b
>0000010 0001 203a 00ff ffff ffff ffff ff11 24ff
>0000020 0000 0000 0026 0000 ff00 0020 3600 584b
>0000030 4e43 4b30 3138 324a 504c 0055 0001 ff00
>0000040 ffff 01ff ff00 ffff 4cff 4f49 004e 0000
>0000050 0700 ffff 0031 ff00 0002 412d 0000 0000
>0000060 8000 0000 0000 0000 0000 0000 0000 0000
>0000070 0000 0000 0000 0000 0000 0000 0000 0000
>0000080 0000 0000 0000 0000 0000 2d2d 0000 0000
>0000090 3333 2d33 4341 342d 5742 304b 3034 3037
>00000a0 0000 d600 0041 2400 0000 0800 2a73 1802
>00000b0 0025 0024 0000 2022 0000 0000 0301 1111
>00000c0 0000 1986 02b4 40da 3c28 1b5f 1986 1964
>00000d0 0000 0000 0000 1986 0146 115b 0000 00e0
>00000e0 0000 3300 3610 3a10 3710 8710 0603 a600
>00000f0 0500 000b 0000 4330 0090 34e3 0658 2d00
>0000100
>

Understood, thank you. Please try applying the attached patch:
- 0001-platform-x86-hp-wmi-Enable-thermal-profile-readback-.patch

and recompiling the hp-wmi driver (located at drivers/platform/x86/hp/hp-wmi.c)

Expected results:
1. Warning disappears from dmesg
2. Power profile is working
3. Fan control is working

>If it helps and/or related, there are a few other issues:
>May 15 08:24:29 kernel: ACPI BIOS Error (bug): Attempt to CreateField
>of length zero (20251212/dsopcode-133)
>May 15 08:24:29 kernel: ACPI Error: Aborting method \_SB.WMID.WQBC due
>to previous error (AE_AML_OPERAND_VALUE) (20251212/psparse-529)
>May 15 08:24:29 kernel: ACPI BIOS Error (bug): Attempt to CreateField
>of length zero (20251212/dsopcode-133)
>May 15 08:24:29 kernel: ACPI Error: Aborting method \_SB.WMID.WQBE due
>to previous error (AE_AML_OPERAND_VALUE) (20251212/psparse-529)
>May 15 08:24:29 kernel: ACPI BIOS Error (bug): Attempt to CreateField
>of length zero (20251212/dsopcode-133)
>May 15 08:24:29 kernel: ACPI Error: Aborting method \_SB.WMID.WHCM due
>to previous error (AE_AML_OPERAND_VALUE) (20251212/psparse-529)
>May 15 08:24:29 kernel: ACPI Error: Aborting method \_SB.WMID.WMAA due
>to previous error (AE_AML_OPERAND_VALUE) (20251212/psparse-529)
>May 15 11:23:25 kernel: ACPI BIOS Error (bug): Could not resolve
>symbol [\_SB.PCI0.LPCB.BAT1], AE_NOT_FOUND (20251212/psargs-332)
>May 15 11:23:25 kernel: ACPI Error: Aborting method \_SB.PEP._DSM due
>to previous error (AE_NOT_FOUND) (20251212/psparse-529)
>
>Thanks,
>Bogdan

[-- Attachment #2: 0001-platform-x86-hp-wmi-Enable-thermal-profile-readback-.patch --]
[-- Type: text/plain, Size: 1369 bytes --]

From 25396b4c7303b61a067baaf37dab45a5a3603d64 Mon Sep 17 00:00:00 2001
From: Krishna Chomal <krishna.chomal108@gmail.com>
Date: Wed, 20 May 2026 23:31:59 +0530
Subject: [PATCH] platform/x86: hp-wmi: Enable thermal profile readback for
 board 8C9C

Board 8C9C was earlier marked with quirk victus_s_thermal_params as part
of 8ca7515d3c76 ("platform/x86: hp-wmi: fix platform profile values
for Omen 16-wf1xxx"). This resulted in thermal profile readback being
disabled. With the correct hardware information (EC layout), we fix this
by replacing the quirk with omen_v1_thermal_params.

Fixes: 8ca7515d3c76 ("platform/x86: hp-wmi: fix platform profile values for Omen 16-wf1xxx")
Signed-off-by: Krishna Chomal <krishna.chomal108@gmail.com>
---
 drivers/platform/x86/hp/hp-wmi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/x86/hp/hp-wmi.c b/drivers/platform/x86/hp/hp-wmi.c
index d1cc6e7d176c..323e6c13526b 100644
--- a/drivers/platform/x86/hp/hp-wmi.c
+++ b/drivers/platform/x86/hp/hp-wmi.c
@@ -239,7 +239,7 @@ static const struct dmi_system_id victus_s_thermal_profile_boards[] __initconst
 	},
 	{
 		.matches = { DMI_MATCH(DMI_BOARD_NAME, "8C9C") },
-		.driver_data = (void *)&victus_s_thermal_params,
+		.driver_data = (void *)&omen_v1_thermal_params,
 	},
 	{
 		.matches = { DMI_MATCH(DMI_BOARD_NAME, "8D41") },
-- 
2.54.0