All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: Matthieu Baerts <matttbe@kernel.org>
Cc: Greg KH <gregkh@linuxfoundation.org>,
	stable <stable@vger.kernel.org>,
	Kuniyuki Iwashima <kuniyu@google.com>
Subject: Re: [5.15.y] build issue when building the queue
Date: Wed, 20 May 2026 10:46:35 -0400	[thread overview]
Message-ID: <ag3JS6WBj-_26wEy@laps> (raw)
In-Reply-To: <c059d010-19c8-4891-9b12-a9658ff59b21@kernel.org>

On Wed, May 20, 2026 at 11:28:28PM +1000, Matthieu Baerts wrote:
>Hi Sasha, Greg,
>
>(+cc Kuniyuki)
>
>Our CI at MPTCP cannot build the patches being queued for v5.15:
>
>
>  net/unix/af_unix.c: In function 'bpf_iter_unix_hold_batch':
>  net/unix/af_unix.c:3352:22: error: 'unix_table_locks' undeclared
>(first use in this function); did you mean 'unix_table_lock'?
>   3352 |         spin_unlock(&unix_table_locks[start_sk->sk_hash]);
>        |                      ^~~~~~~~~~~~~~~~
>        |                      unix_table_lock
>
>  net/unix/af_unix.c: In function 'bpf_iter_unix_batch':
>  net/unix/af_unix.c:3397:14: error: implicit declaration of function
>'unix_get_first'; did you mean 'unix_get_socket'?
>[-Werror=implicit-function-declaration]
>   3397 |         sk = unix_get_first(seq, pos);
>        |              ^~~~~~~~~~~~~~
>        |              unix_get_socket
>
>
>https://github.com/multipath-tcp/mptcp_net-next/actions/runs/26156680393/job/76937788263#step:9:2175
>
>For the first one, unix_table_locks has been introduced in afd20b9290e1
>("af_unix: Replace the big lock with small locks."). Before, the version
>without 's' (unix_table_lock) was used.
>
>For the second one, unix_get_first has been introduced in 4408d55a6467
>("af_unix: Refactor unix_next_socket().").
>
>It looks like these errors are due to:
>
>  bpf-af_unix-use-batching-algorithm-in-bpf-unix-iter.patch
>
>This backport of 855d8e77ffb0 ("bpf: af_unix: Use batching algorithm in
>bpf unix iter.") is needed for 4d328dd69538 ("bpf, sockmap: Fix af_unix
>iter deadlock") apparently.
>
>I'm not sure how you want to fix this in v5.15: backporting new
>improvements, or adapting. But maybe easier to drop the faulty patch for
>the moment, and bpf-sockmap-fix-af_unix-iter-deadlock.patch I suppose.

Thanks for the report. I've just dropped this (and few other follow-up
commits).

-- 
Thanks,
Sasha

      reply	other threads:[~2026-05-20 14:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-20 13:28 [5.15.y] build issue when building the queue Matthieu Baerts
2026-05-20 14:46 ` Sasha Levin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ag3JS6WBj-_26wEy@laps \
    --to=sashal@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=kuniyu@google.com \
    --cc=matttbe@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.