From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BEDFC3D9DBD for ; Thu, 21 May 2026 12:44:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779367495; cv=none; b=uuYkZfnmVQQIQXCY2tG+yIMEmm36AKsf4nnTd8dQztopHK/91ioADMhZhOX5/6TpFCRNQuMcyBF7hiBvX35zzl/c0eXKS7Kz7MiN+TEpjXMmXxnBUqKJkVuXZKMSBwcPLv/TY8ARPyOHQj/0F3aMi0/c24XSVSegw1biP4bKBQw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779367495; c=relaxed/simple; bh=ov7JLvS1G5cn82ppFLalJ5lDsVjdGH/kFEJR2a9m+ro=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DbSKkSXDbDqksvG5Alrp/c+tUeBL4jqAAaPhKNqkjtzMsaYxRqc/VOnfaVOrpWEOINQf2BrEkIazmkyYbtaHckp4lL5afWa2jTwe9cDPClsSL24LgE3QCuEvtWurs536U/ogV/wI+hp1gRPRiE9YWduckohaCFilMgnN+uVWyeI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1wQ2lJ-0000Zz-Iy; Thu, 21 May 2026 14:44:29 +0200 Received: from pty.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::c5]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wQ2lH-0016dC-2c; Thu, 21 May 2026 14:44:28 +0200 Received: from mtr by pty.whiteo.stw.pengutronix.de with local (Exim 4.98.2) (envelope-from ) id 1wQ2lI-00000004VX3-121G; Thu, 21 May 2026 14:44:28 +0200 Date: Thu, 21 May 2026 14:44:28 +0200 From: Michael Tretter To: Sven =?utf-8?Q?P=C3=BCschel?= Cc: Jacob Chen , Ezequiel Garcia , Mauro Carvalho Chehab , Heiko Stuebner , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Hans Verkuil , linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, kernel@pengutronix.de, nicolas@ndufresne.ca, sebastian.reichel@collabora.com, p.zabel@pengutronix.de, Nicolas Dufresne Subject: Re: [PATCH v7 06/28] media: rockchip: rga: fix too small buffer size Message-ID: Mail-Followup-To: Michael Tretter , Sven =?utf-8?Q?P=C3=BCschel?= , Jacob Chen , Ezequiel Garcia , Mauro Carvalho Chehab , Heiko Stuebner , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Hans Verkuil , linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, kernel@pengutronix.de, nicolas@ndufresne.ca, sebastian.reichel@collabora.com, p.zabel@pengutronix.de, Nicolas Dufresne References: <20260521-spu-rga3-v7-0-3f33e8c7145f@pengutronix.de> <20260521-spu-rga3-v7-6-3f33e8c7145f@pengutronix.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260521-spu-rga3-v7-6-3f33e8c7145f@pengutronix.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: m.tretter@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org On Thu, 21 May 2026 00:44:11 +0200, Sven Püschel wrote: > Fix the command buffer size being only a quarter of the actual size. > The RGA_CMDBUF_SIZE macro was potentially intended to specify the length > of the cmdbuf u32 array pointer. But as it's used to specify the size of > the allocation, which is counted in bytes. Therefore adjust the macro > size to bytes as it better matches the variable name and adjust it's > users accordingly. > > As the command buffer is relatively small, it probably didn't caused > an issue due to being smaller than a single page. > > Fixes: f7e7b48e6d79 ("[media] rockchip/rga: v4l2 m2m support") > Reviewed-by: Nicolas Dufresne > Signed-off-by: Sven Püschel > > --- > > Flagged by Sashiko: > https://sashiko.dev/#/patchset/20260325-spu-rga3-v4-0-e90ec1c61354%40pengutronix.de?part=10 > --- > drivers/media/platform/rockchip/rga/rga-hw.c | 2 +- > drivers/media/platform/rockchip/rga/rga-hw.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/platform/rockchip/rga/rga-hw.c b/drivers/media/platform/rockchip/rga/rga-hw.c > index 43ed742a16492..d1618bb247501 100644 > --- a/drivers/media/platform/rockchip/rga/rga-hw.c > +++ b/drivers/media/platform/rockchip/rga/rga-hw.c > @@ -414,7 +414,7 @@ static void rga_cmd_set(struct rga_ctx *ctx, > { > struct rockchip_rga *rga = ctx->rga; > > - memset(rga->cmdbuf_virt, 0, RGA_CMDBUF_SIZE * 4); > + memset(rga->cmdbuf_virt, 0, RGA_CMDBUF_SIZE); Maybe use rga->hw->cmdbuf_size instead of RGA_CMDBUF_SIZE to really be in sync with the allocation. Anyway: Reviewed-by: Michael Tretter > > rga_cmd_set_src_addr(ctx, src->dma_desc_pa); > /* > diff --git a/drivers/media/platform/rockchip/rga/rga-hw.h b/drivers/media/platform/rockchip/rga/rga-hw.h > index cc6bd7f5b0300..2b8537a5fd0d7 100644 > --- a/drivers/media/platform/rockchip/rga/rga-hw.h > +++ b/drivers/media/platform/rockchip/rga/rga-hw.h > @@ -6,7 +6,7 @@ > #ifndef __RGA_HW_H__ > #define __RGA_HW_H__ > > -#define RGA_CMDBUF_SIZE 0x20 > +#define RGA_CMDBUF_SIZE 0x80 > > /* Hardware limits */ > #define MAX_WIDTH 8192 > > -- > 2.54.0 > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6BF5ACD5BB1 for ; Thu, 21 May 2026 12:44:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/uWnyBHRI8gwEg/vEQtgpjrzXOvJamLpD2KN2fKO5wk=; b=gTDExg0UdpKteb TNnVKklLLuwTlMzD4MI5GZkaveDVJa6ehkJg3Gp3U3JVosZaGMr10xHyxEK72wnq9CANlE8JMkOtk +xcK99u2KoFoSXXtd7jLa5KS7RaGZVnLDHmfGhqHbrfgWx06J4pXlDmPwpRQ3dpDKPEY0o+1nHqeA sx4DCJbSi/2pZQqhMBGyNHN4p+o7f3Lbu01rQeqYzo7oqul62RpC5C1fZwU7eTMKQGjol9SHKjAV9 APdrmEjIwsLbodIXY+heep+7paFgybAa6cElbvCQgyh/Xo6CDDFyVIWNDAgxc8pKGIdJe7X4F4NJ4 mv/f7tHJrd9bVnghuv0w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wQ2lc-00000007l2n-3ETg; Thu, 21 May 2026 12:44:49 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wQ2la-00000007l1i-0JC4 for linux-rockchip@lists.infradead.org; Thu, 21 May 2026 12:44:47 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1wQ2lJ-0000Zz-Iy; Thu, 21 May 2026 14:44:29 +0200 Received: from pty.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::c5]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wQ2lH-0016dC-2c; Thu, 21 May 2026 14:44:28 +0200 Received: from mtr by pty.whiteo.stw.pengutronix.de with local (Exim 4.98.2) (envelope-from ) id 1wQ2lI-00000004VX3-121G; Thu, 21 May 2026 14:44:28 +0200 Date: Thu, 21 May 2026 14:44:28 +0200 From: Michael Tretter To: Sven =?utf-8?Q?P=C3=BCschel?= Cc: Jacob Chen , Ezequiel Garcia , Mauro Carvalho Chehab , Heiko Stuebner , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Hans Verkuil , linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, kernel@pengutronix.de, nicolas@ndufresne.ca, sebastian.reichel@collabora.com, p.zabel@pengutronix.de, Nicolas Dufresne Subject: Re: [PATCH v7 06/28] media: rockchip: rga: fix too small buffer size Message-ID: Mail-Followup-To: Michael Tretter , Sven =?utf-8?Q?P=C3=BCschel?= , Jacob Chen , Ezequiel Garcia , Mauro Carvalho Chehab , Heiko Stuebner , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Hans Verkuil , linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, kernel@pengutronix.de, nicolas@ndufresne.ca, sebastian.reichel@collabora.com, p.zabel@pengutronix.de, Nicolas Dufresne References: <20260521-spu-rga3-v7-0-3f33e8c7145f@pengutronix.de> <20260521-spu-rga3-v7-6-3f33e8c7145f@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260521-spu-rga3-v7-6-3f33e8c7145f@pengutronix.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: m.tretter@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-rockchip@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260521_054446_112911_DBC0C9C0 X-CRM114-Status: GOOD ( 20.52 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org T24gVGh1LCAyMSBNYXkgMjAyNiAwMDo0NDoxMSArMDIwMCwgU3ZlbiBQw7xzY2hlbCB3cm90ZToK PiBGaXggdGhlIGNvbW1hbmQgYnVmZmVyIHNpemUgYmVpbmcgb25seSBhIHF1YXJ0ZXIgb2YgdGhl IGFjdHVhbCBzaXplLgo+IFRoZSBSR0FfQ01EQlVGX1NJWkUgbWFjcm8gd2FzIHBvdGVudGlhbGx5 IGludGVuZGVkIHRvIHNwZWNpZnkgdGhlIGxlbmd0aAo+IG9mIHRoZSBjbWRidWYgdTMyIGFycmF5 IHBvaW50ZXIuIEJ1dCBhcyBpdCdzIHVzZWQgdG8gc3BlY2lmeSB0aGUgc2l6ZSBvZgo+IHRoZSBh bGxvY2F0aW9uLCB3aGljaCBpcyBjb3VudGVkIGluIGJ5dGVzLiBUaGVyZWZvcmUgYWRqdXN0IHRo ZSBtYWNybwo+IHNpemUgdG8gYnl0ZXMgYXMgaXQgYmV0dGVyIG1hdGNoZXMgdGhlIHZhcmlhYmxl IG5hbWUgYW5kIGFkanVzdCBpdCdzCj4gdXNlcnMgYWNjb3JkaW5nbHkuCj4gCj4gQXMgdGhlIGNv bW1hbmQgYnVmZmVyIGlzIHJlbGF0aXZlbHkgc21hbGwsIGl0IHByb2JhYmx5IGRpZG4ndCBjYXVz ZWQKPiBhbiBpc3N1ZSBkdWUgdG8gYmVpbmcgc21hbGxlciB0aGFuIGEgc2luZ2xlIHBhZ2UuCj4g Cj4gRml4ZXM6IGY3ZTdiNDhlNmQ3OSAoIlttZWRpYV0gcm9ja2NoaXAvcmdhOiB2NGwyIG0ybSBz dXBwb3J0IikKPiBSZXZpZXdlZC1ieTogTmljb2xhcyBEdWZyZXNuZSA8bmljb2xhcy5kdWZyZXNu ZUBjb2xsYWJvcmEuY29tPgo+IFNpZ25lZC1vZmYtYnk6IFN2ZW4gUMO8c2NoZWwgPHMucHVlc2No ZWxAcGVuZ3V0cm9uaXguZGU+Cj4gCj4gLS0tCj4gCj4gRmxhZ2dlZCBieSBTYXNoaWtvOgo+IGh0 dHBzOi8vc2FzaGlrby5kZXYvIy9wYXRjaHNldC8yMDI2MDMyNS1zcHUtcmdhMy12NC0wLWU5MGVj MWM2MTM1NCU0MHBlbmd1dHJvbml4LmRlP3BhcnQ9MTAKPiAtLS0KPiAgZHJpdmVycy9tZWRpYS9w bGF0Zm9ybS9yb2NrY2hpcC9yZ2EvcmdhLWh3LmMgfCAyICstCj4gIGRyaXZlcnMvbWVkaWEvcGxh dGZvcm0vcm9ja2NoaXAvcmdhL3JnYS1ody5oIHwgMiArLQo+ICAyIGZpbGVzIGNoYW5nZWQsIDIg aW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9t ZWRpYS9wbGF0Zm9ybS9yb2NrY2hpcC9yZ2EvcmdhLWh3LmMgYi9kcml2ZXJzL21lZGlhL3BsYXRm b3JtL3JvY2tjaGlwL3JnYS9yZ2EtaHcuYwo+IGluZGV4IDQzZWQ3NDJhMTY0OTIuLmQxNjE4YmIy NDc1MDEgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS9yb2NrY2hpcC9yZ2Ev cmdhLWh3LmMKPiArKysgYi9kcml2ZXJzL21lZGlhL3BsYXRmb3JtL3JvY2tjaGlwL3JnYS9yZ2Et aHcuYwo+IEBAIC00MTQsNyArNDE0LDcgQEAgc3RhdGljIHZvaWQgcmdhX2NtZF9zZXQoc3RydWN0 IHJnYV9jdHggKmN0eCwKPiAgewo+ICAJc3RydWN0IHJvY2tjaGlwX3JnYSAqcmdhID0gY3R4LT5y Z2E7Cj4gIAo+IC0JbWVtc2V0KHJnYS0+Y21kYnVmX3ZpcnQsIDAsIFJHQV9DTURCVUZfU0laRSAq IDQpOwo+ICsJbWVtc2V0KHJnYS0+Y21kYnVmX3ZpcnQsIDAsIFJHQV9DTURCVUZfU0laRSk7CgpN YXliZSB1c2UgcmdhLT5ody0+Y21kYnVmX3NpemUgaW5zdGVhZCBvZiBSR0FfQ01EQlVGX1NJWkUg dG8gcmVhbGx5IGJlCmluIHN5bmMgd2l0aCB0aGUgYWxsb2NhdGlvbi4KCkFueXdheToKClJldmll d2VkLWJ5OiBNaWNoYWVsIFRyZXR0ZXIgPG0udHJldHRlckBwZW5ndXRyb25peC5kZT4KCj4gIAo+ ICAJcmdhX2NtZF9zZXRfc3JjX2FkZHIoY3R4LCBzcmMtPmRtYV9kZXNjX3BhKTsKPiAgCS8qCj4g ZGlmZiAtLWdpdCBhL2RyaXZlcnMvbWVkaWEvcGxhdGZvcm0vcm9ja2NoaXAvcmdhL3JnYS1ody5o IGIvZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS9yb2NrY2hpcC9yZ2EvcmdhLWh3LmgKPiBpbmRleCBj YzZiZDdmNWIwMzAwLi4yYjg1MzdhNWZkMGQ3IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvbWVkaWEv cGxhdGZvcm0vcm9ja2NoaXAvcmdhL3JnYS1ody5oCj4gKysrIGIvZHJpdmVycy9tZWRpYS9wbGF0 Zm9ybS9yb2NrY2hpcC9yZ2EvcmdhLWh3LmgKPiBAQCAtNiw3ICs2LDcgQEAKPiAgI2lmbmRlZiBf X1JHQV9IV19IX18KPiAgI2RlZmluZSBfX1JHQV9IV19IX18KPiAgCj4gLSNkZWZpbmUgUkdBX0NN REJVRl9TSVpFIDB4MjAKPiArI2RlZmluZSBSR0FfQ01EQlVGX1NJWkUgMHg4MAo+ICAKPiAgLyog SGFyZHdhcmUgbGltaXRzICovCj4gICNkZWZpbmUgTUFYX1dJRFRIIDgxOTIKPiAKPiAtLSAKPiAy LjU0LjAKPiAKPiAKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCkxpbnV4LXJvY2tjaGlwIG1haWxpbmcgbGlzdApMaW51eC1yb2NrY2hpcEBsaXN0cy5pbmZy YWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGlu dXgtcm9ja2NoaXAK