From: Nikolay Aleksandrov <razor@blackwall.org>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
netdev@vger.kernel.org, eric.dumazet@gmail.com,
syzbot+a35f9259d08f907c06e6@syzkaller.appspotmail.com,
Ido Schimmel <idosch@nvidia.com>
Subject: Re: [PATCH v2 net] net: bridge: prevent too big nested attributes in br_fill_linkxstats()
Date: Thu, 21 May 2026 15:22:03 +0300 [thread overview]
Message-ID: <ag7463AoU8pVuamX@penguin> (raw)
In-Reply-To: <20260520114207.1394241-1-edumazet@google.com>
On Wed, May 20, 2026 at 11:42:07AM +0000, Eric Dumazet wrote:
> After commit ff205bf8c554 ("netlink: add one debug check in nla_nest_end()")
> syzbot found that br_fill_linkxstats() can send corrupted netlink packets.
>
> Make sure the nested attribute size is bounded.
>
> Fixes: a60c090361ea ("bridge: netlink: export per-vlan stats")
> Reported-by: syzbot+a35f9259d08f907c06e6@syzkaller.appspotmail.com
> Closes: https://lore.kernel.org/netdev/6a0b0da3.050a0220.175f0c.0000.GAE@google.com/
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> ---
> Cc: Nikolay Aleksandrov <razor@blackwall.org>
> Cc: Ido Schimmel <idosch@nvidia.com>
> ---
> v2: remove the WARN_ON(err == -EMSGSIZE) in rtnl_stats_get() (Ido)
> adjust limit (Ido)
> v1: https://lore.kernel.org/netdev/20260518130531.1015332-1-edumazet@google.com/
>
> net/bridge/br_netlink.c | 10 ++++++++++
> net/core/rtnetlink.c | 5 +++--
> 2 files changed, 13 insertions(+), 2 deletions(-)
>
Thanks!
Acked-by: Nikolay Aleksandrov <razor@blackwall.org>
next prev parent reply other threads:[~2026-05-21 12:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-20 11:42 [PATCH v2 net] net: bridge: prevent too big nested attributes in br_fill_linkxstats() Eric Dumazet
2026-05-20 19:52 ` Ido Schimmel
2026-05-21 12:22 ` Nikolay Aleksandrov [this message]
2026-05-21 16:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ag7463AoU8pVuamX@penguin \
--to=razor@blackwall.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=syzbot+a35f9259d08f907c06e6@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.