Re: [PATCH v5 0/2] platform/x86: hp-wmi: Add Victus 15-fb0xxx fan control

[Krishna Chomal <krishna.chomal108@gmail.com>]

On Thu, May 21, 2026 at 06:19:48PM +0530, Radhey Kalra wrote:
>Hi Krishna,
>
>I tested the current platform-profile behavior on 8A3D more carefully.
>
>The board already exposes the generic hp-wmi platform-profile choices:
>
>cool quiet balanced performance
>
>Writes to all choices succeed and read back correctly, and I do not
>see hp_wmi errors in dmesg.
>
>However, under full CPU load I could not confirm that these profiles
>change CPU power behavior. Across quiet/balanced/performance/cool, CPU
>frequency stayed around 3.27 GHz and the reported PPT stayed around 33
>W. Fan RPM rose somewhat later in the test, but the system was also
>heating up, so I cannot separate that from normal firmware thermal fan
>ramping.

You are right. Because your board is not registered in any list, so it
goes to a fallback route and registers quiet/balanced/performance/cool.
Changes to platform profile are handled through this chain:

hp_wmi_platform_profile_set
	-> thermal_profile_set
		-> hp_wmi_perform_query(HPWMI_THERMAL_PROFILE_QUERY)

For my device, when I selected victus_8a3d_board_params quirk, the driver
tried to use this query HPWMI_THERMAL_PROFILE_QUERY which failed and
caused the driver to not load. In you case, it looks like the query does
not return an error. However, not returning an error does not necessarily
imply that it is working correctly, which can be further confirmed when
you mention that changing power modes has no physical effect on the system.

>So I should not claim that platform-profile policy is meaningfully
>validated for 8A3D. What I have verified is that the Victus
>fan-control path works.
>
>That is why I avoided a plain addition to
>victus_s_thermal_profile_boards: it would move 8A3D from the existing
>generic platform-profile path to the Victus S-specific
>platform-profile path, which I have not verified on this board.
>

I think your board does need Victus-S-specific platform-profile path
because the old/legacy queries did not have any effect on the system.

>Thanks, Radhey
>
[...]