From: Dan Carpenter <error27@gmail.com>
To: Artur Ugnivenko <artur.ugnivenko@gmx.de>
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
linux-staging@lists.linux.dev, ahmet@sezginduran.net
Subject: Re: [PATCH v6 1/4] staging: rtl8723bs: shorten long lines in hal/sdio_halinit.c
Date: Thu, 21 May 2026 17:09:47 +0300 [thread overview]
Message-ID: <ag8SK_CdcCXr3MJ6@stanley.mountain> (raw)
In-Reply-To: <20260521134756.24546-2-artur.ugnivenko@gmx.de>
On Thu, May 21, 2026 at 03:47:53PM +0200, Artur Ugnivenko wrote:
> Fix checkpatch warnings on lines above 100 chars in length by splitting
> long function calls and long comments into multiple lines.
>
> Signed-off-by: Artur Ugnivenko <artur.ugnivenko@gmx.de>
> ---
> drivers/staging/rtl8723bs/hal/sdio_halinit.c | 52 ++++++++++++++++----
> 1 file changed, 42 insertions(+), 10 deletions(-)
You need to add a note about about what changed between each version.
https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/
regards,
dan carpenter
next prev parent reply other threads:[~2026-05-21 14:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-21 13:47 [PATCH v6 0/4] staging: rtl8723bs: fix several style issues in hal/sdio_halinit.c Artur Ugnivenko
2026-05-21 13:47 ` [PATCH v6 1/4] staging: rtl8723bs: shorten long lines " Artur Ugnivenko
2026-05-21 14:09 ` Dan Carpenter [this message]
2026-05-21 13:47 ` [PATCH v6 2/4] staging: rtl8723bs: fix inconsistent braces " Artur Ugnivenko
2026-05-21 14:08 ` [PATCH v6 0/4] staging: rtl8723bs: fix several style issues " Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ag8SK_CdcCXr3MJ6@stanley.mountain \
--to=error27@gmail.com \
--cc=ahmet@sezginduran.net \
--cc=artur.ugnivenko@gmx.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.