From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: David Lechner <dlechner@baylibre.com>
Cc: Vladislav Kulikov <vlad.kulikov.c@gmail.com>,
jic23@kernel.org, nuno.sa@analog.com, andy@kernel.org,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] iio: magnetometer: add driver for MEMSIC MMC5983MA
Date: Sun, 10 May 2026 10:02:16 +0300 [thread overview]
Message-ID: <agAteDsZ69MIqyrT@ashevche-desk.local> (raw)
In-Reply-To: <880e0d0c-da84-484e-869b-ff77454874e1@baylibre.com>
On Sat, May 09, 2026 at 05:09:33PM -0500, David Lechner wrote:
> On 5/7/26 3:50 PM, Vladislav Kulikov wrote:
> > Add support for the MEMSIC MMC5983MA 3-axis magnetometer. The driver
> > provides raw magnetic field readings via IIO sysfs with SET/RESET
> > offset cancellation for each measurement.
...
> > + ret = regmap_read_poll_timeout(data->regmap, MMC5983_REG_STATUS,
> > + status,
> > + status & MMC5983_STATUS_MEAS_M_DONE_BIT,
> > + 10000, 50000);
>
> I wouldn't mind seeing 10 * KILO, 50 * KILO here to make it easier to read.
No, it should be USEC_PER_MSEC (requires time.h to be included).
> > + if (ret)
> > + return ret;
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-05-10 7:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-07 20:50 [PATCH v2 0/2] iio: magnetometer: add MEMSIC MMC5983MA driver Vladislav Kulikov
2026-05-07 20:50 ` [PATCH v2 1/2] dt-bindings: iio: magnetometer: add MEMSIC MMC5983MA Vladislav Kulikov
2026-05-08 15:06 ` Conor Dooley
2026-05-09 21:51 ` David Lechner
2026-05-07 20:50 ` [PATCH v2 2/2] iio: magnetometer: add driver for " Vladislav Kulikov
2026-05-09 22:09 ` David Lechner
2026-05-10 7:02 ` Andy Shevchenko [this message]
2026-05-11 17:14 ` Jonathan Cameron
2026-05-08 10:03 ` [PATCH v2 0/2] iio: magnetometer: add MEMSIC MMC5983MA driver Andy Shevchenko
2026-05-08 10:40 ` Vlad
2026-05-09 7:58 ` Andy Shevchenko
2026-05-09 22:06 ` David Lechner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=agAteDsZ69MIqyrT@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
--cc=vlad.kulikov.c@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.