From: Hyunwoo Kim <imv4bel@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: dhowells@redhat.com, marc.dionne@auristor.com,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
horms@kernel.org, qingfang.deng@linux.dev,
jiayuan.chen@linux.dev, linux-afs@lists.infradead.org,
netdev@vger.kernel.org, stable@vger.kernel.org,
imv4bel@gmail.com
Subject: Re: [PATCH net v3] rxrpc: Also unshare DATA/RESPONSE packets when paged frags are present
Date: Mon, 11 May 2026 02:05:19 +0900 [thread overview]
Message-ID: <agC6z1FeEN6jMjyk@v4bel> (raw)
In-Reply-To: <20260510100310.230b15ed@kernel.org>
On Sun, May 10, 2026 at 10:03:10AM -0700, Jakub Kicinski wrote:
> On Mon, 11 May 2026 01:48:39 +0900 Hyunwoo Kim wrote:
> > On Sun, May 10, 2026 at 08:45:20AM -0700, Jakub Kicinski wrote:
> > > On Fri, 8 May 2026 17:53:09 +0900 Hyunwoo Kim wrote:
> > > > sp->hdr.securityIndex != 0 &&
> > > > - skb_cloned(skb)) {
> > > > + (skb_cloned(skb) ||
> > > > + skb_has_frag_list(skb) ||
> > > > + skb_has_shared_frag(skb))) {
> > >
> > > We seem to be getting a lot of fixes for this issue, and this one is
> > > incorrect :| Writing to _any_ frags is incorrect. You have to copy
> > > if skb is not linear. skb_ensure_writable()
> >
> > I was testing a patch based on skb_ensure_writable() but it seems v3
> > has just been merged to mainline...
> >
> > What would be the best way to proceed?
>
> Depends on the tree. Where was it merged?
That's the torvalds tree:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=aa54b1d27fe0c2b78e664a34fd0fdf7cd1960d71
next prev parent reply other threads:[~2026-05-10 17:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-08 8:53 [PATCH net v3] rxrpc: Also unshare DATA/RESPONSE packets when paged frags are present Hyunwoo Kim
2026-05-08 15:45 ` David Howells
2026-05-09 2:32 ` Jiayuan Chen
2026-05-09 14:30 ` Jeffrey E Altman
2026-05-10 15:45 ` Jakub Kicinski
2026-05-10 16:48 ` Hyunwoo Kim
2026-05-10 17:03 ` Jakub Kicinski
2026-05-10 17:05 ` Fernando Fernandez Mancera
2026-05-10 17:05 ` Hyunwoo Kim [this message]
2026-05-10 17:23 ` Jakub Kicinski
2026-05-11 1:54 ` Jiayuan Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=agC6z1FeEN6jMjyk@v4bel \
--to=imv4bel@gmail.com \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jiayuan.chen@linux.dev \
--cc=kuba@kernel.org \
--cc=linux-afs@lists.infradead.org \
--cc=marc.dionne@auristor.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=qingfang.deng@linux.dev \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.