From: Dan Carpenter <error27@gmail.com>
To: Harshit Shaw <shawharshit116@gmail.com>
Cc: deller@gmx.de, tzimmermann@suse.de, chintanlike@gmail.com,
andriy.shevchenko@intel.com, gregkh@linuxfoundation.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: fbtft: check return value of device_create_file()
Date: Mon, 11 May 2026 14:46:28 +0300 [thread overview]
Message-ID: <agHBlP9Z1NVQMQ3W@stanley.mountain> (raw)
In-Reply-To: <20260511100140.4794-1-shawharshit116@gmail.com>
On Mon, May 11, 2026 at 10:01:40AM +0000, Harshit Shaw wrote:
> device_create_file() can fail but its return value was being
> ignored in fbtft_sysfs_init(). Check the return value and
> emit a warning if sysfs file creation fails.
>
> Signed-off-by: Harshit Shaw <shawharshit116@gmail.com>
> ---
What's the point of this though? How is your warning message more
informative than the warning messages printed out by
device_create_file()?
regards,
dan carpenter
prev parent reply other threads:[~2026-05-11 11:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-11 10:01 [PATCH] staging: fbtft: check return value of device_create_file() Harshit Shaw
2026-05-11 10:08 ` Greg KH
2026-05-11 11:46 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=agHBlP9Z1NVQMQ3W@stanley.mountain \
--to=error27@gmail.com \
--cc=andriy.shevchenko@intel.com \
--cc=chintanlike@gmail.com \
--cc=deller@gmx.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=shawharshit116@gmail.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.