Re: [RFC 1/4] dt-bindings: iio: light: add DT binding for Broadcom APDS9999

["Jose A. Perez de Azpillaga" <azpijr@gmail.com>]

On Mon, May 11, 2026 at 01:26:35PM +0100, Jonathan Cameron wrote:
> On Mon, 11 May 2026 12:14:44 +0200
> "Jose A. Perez de Azpillaga" <azpijr@gmail.com> wrote:
>
> Title doesn't need to mention binding twice.

I will fix it in v2.

> dt-bindings: iio: light: add Broadcomm ADPS9999
>
> > Add Device Tree binding documentation for the Broadcom APDS9999
> > ambient light sensor.
> >
> > Proximity and RGB features are not yet implemented in the driver
> > and therefore not included in this binding.
> >
> > Signed-off-by: Jose A. Perez de Azpillaga <azpijr@gmail.com>
>
> Can you combine this with the existing avago,apds9300.yaml binding?
> Other than the missing interrupt in this file they look identical.
>
> Note that a separate driver doesn't necessarily need a separate binding
> doc.  May not be worth doing given the extra supply this part takes
> (which you are currently missing by the look of it)

the VCSEL supply and required vdd-supply make a combined binding messy
with conditional schemas. keeping it separate.

...

> Power supply should be required

noted for v2.

> Also you need to fully describe the part where possible. Here there
> is an interrupt and a vcsel-supply by the look of it.

okay, I'll address everything said in v2.

--
jose a. p-a