From: Keith Busch <kbusch@kernel.org>
To: Maurizio Lombardi <mlombard@arkamax.eu>
Cc: Sagi Grimberg <sagi@grimberg.me>, Christoph Hellwig <hch@lst.de>,
Maurizio Lombardi <mlombard@redhat.com>,
mheyne@amazon.de, emilne@redhat.com, jmeneghi@redhat.com,
linux-nvme@lists.infradead.org, dwagner@suse.de,
mkhalfella@purestorage.com, chaitanyak@nvidia.com,
hare@kernel.org
Subject: Re: [PATCH V4 3/9] nvme: fix race condition between connected uevent and STARTED_ONCE flag
Date: Mon, 11 May 2026 11:10:04 -0600 [thread overview]
Message-ID: <agINbJ65S8w8cycB@kbusch-mbp> (raw)
In-Reply-To: <DIFYPQP2Z8D5.QSBMLF4V9FNX@arkamax.eu>
On Mon, May 11, 2026 at 05:45:36PM +0200, Maurizio Lombardi wrote:
> On Mon May 11, 2026 at 5:09 PM CEST, Keith Busch wrote:
> > On Mon, May 11, 2026 at 03:54:04PM +0300, Sagi Grimberg wrote:
> >>
> >> > On Mon, May 11, 2026 at 01:10:34AM +0300, Sagi Grimberg wrote:
> >> > > This should even go as a separate patch:
> >> > You mean a stadalone fix? Because it already is a separate patch.
> >>
> >> Yes, this is a race condition fix that can go separately.
> >
> > Sure thing, I've applied patch 3/9 to nvme-7.1 as a separate bug fix.
>
> Oh, that was way faster than I expected.
>
> The issue is that, in explaining the rationale behind PATCH 3, I
> mentioned in its commit message the admin_timeout sysfs attribute
> introduced by this patchset.
>
> You may want to remove that reference if you plan to merge patch 3
> indipendently of the rest of this patchset.
>
> In the vanilla kernel, the only sysfs attribute that could be affected by
> this race condition is nvme_sysfs_delete().
Ah, thanks. I got to this one quicker because I had some free time for
patch maintenance. I'll fix up the message.
next prev parent reply other threads:[~2026-05-11 17:10 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-08 13:33 [PATCH V4 0/9] nvme: Refactor and expose per-controller timeout configuration Maurizio Lombardi
2026-05-08 13:33 ` [PATCH V4 1/9] nvme: Let the blocklayer set timeouts for requests Maurizio Lombardi
2026-05-11 9:37 ` Hannes Reinecke
2026-05-08 13:33 ` [PATCH V4 2/9] nvme: add sysfs attribute to change admin timeout per nvme controller Maurizio Lombardi
2026-05-08 16:57 ` Daniel Wagner
2026-05-10 22:10 ` Sagi Grimberg
2026-05-11 8:07 ` Christoph Hellwig
2026-05-11 11:29 ` Maurizio Lombardi
2026-05-11 12:31 ` Christoph Hellwig
2026-05-11 9:46 ` Hannes Reinecke
2026-05-11 10:05 ` Maurizio Lombardi
2026-05-08 13:33 ` [PATCH V4 3/9] nvme: fix race condition between connected uevent and STARTED_ONCE flag Maurizio Lombardi
2026-05-08 16:57 ` Daniel Wagner
2026-05-10 22:10 ` Sagi Grimberg
2026-05-11 8:07 ` Christoph Hellwig
2026-05-11 12:54 ` Sagi Grimberg
2026-05-11 15:09 ` Keith Busch
2026-05-11 15:45 ` Maurizio Lombardi
2026-05-11 17:10 ` Keith Busch [this message]
2026-05-11 8:08 ` Christoph Hellwig
2026-05-11 9:47 ` Hannes Reinecke
2026-05-08 13:33 ` [PATCH V4 4/9] nvme: pci: use admin queue timeout over NVME_ADMIN_TIMEOUT Maurizio Lombardi
2026-05-10 22:10 ` Sagi Grimberg
2026-05-11 8:08 ` Christoph Hellwig
2026-05-11 9:48 ` Hannes Reinecke
2026-05-08 13:33 ` [PATCH V4 5/9] nvme: add sysfs attribute to change IO timeout per controller Maurizio Lombardi
2026-05-08 17:08 ` Daniel Wagner
2026-05-13 13:00 ` Maurizio Lombardi
2026-05-10 22:12 ` Sagi Grimberg
2026-05-11 8:52 ` Maurizio Lombardi
2026-05-08 13:33 ` [PATCH V4 6/9] nvme: use per controller timeout waits over depending on global default Maurizio Lombardi
2026-05-11 8:10 ` Christoph Hellwig
2026-05-11 11:42 ` Maurizio Lombardi
2026-05-11 12:32 ` Christoph Hellwig
2026-05-11 9:50 ` Hannes Reinecke
2026-05-08 13:33 ` [PATCH V4 7/9] nvme-core: align fabrics_q teardown with admin_q in nvme_free_ctrl Maurizio Lombardi
2026-05-10 22:15 ` Sagi Grimberg
2026-05-11 8:11 ` Christoph Hellwig
2026-05-11 9:53 ` Hannes Reinecke
2026-05-11 9:57 ` Maurizio Lombardi
2026-05-08 13:33 ` [PATCH V4 8/9] nvmet-loop: do not alloc admin tag set during reset Maurizio Lombardi
2026-05-08 17:09 ` Daniel Wagner
2026-05-10 22:16 ` Sagi Grimberg
2026-05-11 8:12 ` Christoph Hellwig
2026-05-11 9:55 ` Hannes Reinecke
2026-05-08 13:33 ` [PATCH V4 9/9] nvme-core: warn on allocating admin tag set with existing queue Maurizio Lombardi
2026-05-10 22:16 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=agINbJ65S8w8cycB@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=chaitanyak@nvidia.com \
--cc=dwagner@suse.de \
--cc=emilne@redhat.com \
--cc=hare@kernel.org \
--cc=hch@lst.de \
--cc=jmeneghi@redhat.com \
--cc=linux-nvme@lists.infradead.org \
--cc=mheyne@amazon.de \
--cc=mkhalfella@purestorage.com \
--cc=mlombard@arkamax.eu \
--cc=mlombard@redhat.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.