From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.netfilter.org (mail.netfilter.org [217.70.190.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C993F4B8DE3 for ; Tue, 12 May 2026 11:24:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.190.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778585077; cv=none; b=dipMZvO6CNdlFF8M9xNbFiiiLnmIrmQf95itbw0TTv7qlvx9Z7fWysR/FK7AnacxvPGcw2zcAPw7urEqvy9fCf/bpzKkiqEP9scfHWh0Ydg4E5Tb1XJ7CucGzs8ez9/Y11VLpB5y7KA3TwqnX3fvRMHDT+Qf7P9qB0aUw7hwaFg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778585077; c=relaxed/simple; bh=X6BxXFUJTG/Guu3mg8QwUMqmvoAhYOukNnL4G8ngDZ0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Bk19LNxdnruYKH2PI7MInsfqjDkyWkRflVMEBnQAxwyXi626sNedFHMQ5n5o4zKzL3dNGddyDMjNRpPY+RwIE82m3cpGrXflDGkdmhF5PirosR+jQBEuABcN2WUHiF29n6F7TmhNIfDG+cUkbWffaR+/GgHQKa9dk4XlnR8Qns0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=netfilter.org; spf=pass smtp.mailfrom=netfilter.org; dkim=pass (2048-bit key) header.d=netfilter.org header.i=@netfilter.org header.b=ZhYWOplb; arc=none smtp.client-ip=217.70.190.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=netfilter.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=netfilter.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=netfilter.org header.i=@netfilter.org header.b="ZhYWOplb" Received: from netfilter.org (mail-agni [217.70.190.124]) by mail.netfilter.org (Postfix) with UTF8SMTPSA id 2A94E6017D; Tue, 12 May 2026 13:24:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netfilter.org; s=2025; t=1778585072; bh=snBmz6x1s42yTaEa2xGEdM3KSY3iDTf3kEI2BFUHYTU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZhYWOplbENIQZfWwO2GOQ7AOivanmO3VXT8NmEjoCji0qpfxA+4vZw25AEYyv6Rbw Y//oi4m7oYyxE32dEi4IyHhvnndg1VO0A4nshi5nFiElTj+WdxphFU2BWcv6x5C/ts xYXfPn5NBR2G5pOZafmgCvNBfGhYGPP6qvpfnhbcxOxvs2c+H4RwjfKn3gyrl7oo2l 7D81QC34injeABZO/QVW9bFZju4ooYu3xzgC/B4qKpJVaVRrW6xVU+GZSYQ3nPTmO4 swBwMrIOj3Khe2kYeydBCWJ+V7TpaZ+8QvOA4l3AvzyzHf+nkkhTm9Azt8cMK/6mdB dXjYqkCWr6p/w== Date: Tue, 12 May 2026 13:24:29 +0200 From: Pablo Neira Ayuso To: Ren Wei Cc: netfilter-devel@vger.kernel.org, fw@strlen.de, phil@nwl.cc, stephane.ml.bryant@gmail.com, yuantan098@gmail.com, yifanwucs@gmail.com, tomapufckgml@gmail.com, bird@lzu.edu.cn, royenheart@gmail.com Subject: Re: [PATCH nf 1/1] netfilter: nf_queue: hold bridge skb->dev while queued Message-ID: References: Precedence: bulk X-Mailing-List: netfilter-devel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="lUc2ecu79LRwF7Ye" Content-Disposition: inline In-Reply-To: --lUc2ecu79LRwF7Ye Content-Type: text/plain; charset=utf-8 Content-Disposition: inline On Tue, May 12, 2026 at 03:57:25PM +0800, Ren Wei wrote: > From: Haoze Xie > > br_pass_frame_up() rewrites skb->dev from the ingress port to the bridge > master before queueing bridge LOCAL_IN packets. NFQUEUE only holds > references on state.in/out and bridge physdevs, so a queued bridge > packet can retain a freed bridge master in skb->dev until reinjection. > > When the verdict is reinjected later, br_netif_receive_skb() re-enters > the receive path with skb->dev still pointing at the freed bridge master, > triggering a use-after-free. > > Store skb->dev in the queue entry for bridge builds, hold a reference on > it for the queue lifetime, and use the saved device when dropping queued > packets during NETDEV_DOWN handling. Next attempt: Maybe hold reference on skb->dev... --lUc2ecu79LRwF7Ye Content-Type: text/x-diff; charset=utf-8 Content-Disposition: attachment; filename="fix.patch" diff --git a/net/netfilter/nf_queue.c b/net/netfilter/nf_queue.c index a6c81c04b3a5..26a4db5e17d4 100644 --- a/net/netfilter/nf_queue.c +++ b/net/netfilter/nf_queue.c @@ -66,6 +66,7 @@ static void nf_queue_entry_release_refs(struct nf_queue_entry *entry) if (state->sk) nf_queue_sock_put(state->sk); + dev_put(entry->skb->dev); #if IS_ENABLED(CONFIG_BRIDGE_NETFILTER) dev_put(entry->physin); dev_put(entry->physout); @@ -104,6 +105,7 @@ bool nf_queue_entry_get_refs(struct nf_queue_entry *entry) dev_hold(state->in); dev_hold(state->out); + dev_hold(entry->skb->dev); #if IS_ENABLED(CONFIG_BRIDGE_NETFILTER) dev_hold(entry->physin); --lUc2ecu79LRwF7Ye--