All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Baoquan He <baoquan.he@linux.dev>
Cc: linux-mm@kvack.org, akpm@linux-foundation.org, chrisl@kernel.org,
	usama.arif@linux.dev, baohua@kernel.org, kasong@tencent.com,
	nphamcs@gmail.com, shikemeng@huaweicloud.com,
	youngjun.park@lge.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 1/3] mm/swap: rename mm/page_io.c to mm/swap_io.c
Date: Tue, 12 May 2026 22:21:15 -0700	[thread overview]
Message-ID: <agQKS17GVeAxXYHG@infradead.org> (raw)
In-Reply-To: <20260512104201.716213-2-baoquan.he@linux.dev>

On Tue, May 12, 2026 at 06:41:59PM +0800, Baoquan He wrote:
> Codes in mm/page_io.c are only related to swap io, it has
> nothing to do with other page io.

That is true.  At the same time it also (mostly) isn't about all swap
I/O, but specifically about the block based I/O backend for swap, and
secondarily a little bit about helpers for the swsusp I/O to the swap
file, with a little bit generic swap I/O wrappers thrown in.

So the new new isn't grest either.  And I'd rather wait with this until
we can nicely split stuff out - the rest of this series is a good step
toward that, and my swap_activate series is another.  After that we
should be able to stop creating swap_extent structures for
SWP_FS_OPS-based I/O, and contain struct swap_extent with the bio code
and actually create a coherent abstraction.  This will require moving
a bit more code around, though.  My preference for the resulting name
would be swap-block.c or swap-bio.c, but that's up for future
discussion.

Can we just skip this for now?


  parent reply	other threads:[~2026-05-13  5:21 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-12 10:41 [PATCH v6 0/3] mm/swap: use swap_ops to register swap device's methods Baoquan He
2026-05-12 10:41 ` [PATCH v6 1/3] mm/swap: rename mm/page_io.c to mm/swap_io.c Baoquan He
2026-05-13  0:27   ` Chris Li
2026-05-13  5:21   ` Christoph Hellwig [this message]
2026-05-13  7:10     ` Baoquan He
2026-05-12 10:42 ` [PATCH v6 2/3] mm/swap: use swap_ops to register swap device's methods Baoquan He
2026-05-12 17:53   ` Kairui Song
2026-05-14  2:06     ` Baoquan He
2026-05-14  6:41       ` Kairui Song
2026-05-14  8:40         ` Baoquan He
2026-05-13  5:32   ` Christoph Hellwig
2026-05-13 15:33     ` Baoquan He
2026-05-15  6:30       ` Christoph Hellwig
2026-05-15 21:31         ` Chris Li
2026-05-13  5:45   ` Christoph Hellwig
2026-05-13 15:38     ` Baoquan He
2026-05-12 10:42 ` [PATCH v6 3/3] mm/swap_io.c: rename swap_writepage_* to swap_write_folio_* Baoquan He
2026-05-12 17:54   ` Kairui Song
2026-05-13  0:31   ` Chris Li
2026-05-13  5:36   ` Christoph Hellwig
2026-05-13 15:44     ` Baoquan He

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=agQKS17GVeAxXYHG@infradead.org \
    --to=hch@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=baohua@kernel.org \
    --cc=baoquan.he@linux.dev \
    --cc=chrisl@kernel.org \
    --cc=kasong@tencent.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=nphamcs@gmail.com \
    --cc=shikemeng@huaweicloud.com \
    --cc=usama.arif@linux.dev \
    --cc=youngjun.park@lge.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.