From: Cyrill Gorcunov <gorcunov@gmail.com>
To: LKML <linux-kernel@vger.kernel.org>, NETDEV <netdev@vger.kernel.org>
Cc: Tony Nguyen <anthony.l.nguyen@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>
Subject: [PATCH] ice: Fix wrong dsn read in ice_adapter_put
Date: Wed, 13 May 2026 12:09:25 +0300 [thread overview]
Message-ID: <agQ_xZUp3Sq905O_@grain> (raw)
When registering an adapter instance, we read the PCI configuration
space to fetch the DSN and generate an adapter index for lookups.
However, if the adapter has been physically unplugged, the PCI space
is no longer accessible. Reading it returns a zero value, which results
in either an incorrect adapter instance being put or the proper instance
not being put at all. To fix this, we will use the previously known
index instead.
Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
---
drivers/net/ethernet/intel/ice/ice_adapter.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
Index: linux-tip.git/drivers/net/ethernet/intel/ice/ice_adapter.c
===================================================================
--- linux-tip.git.orig/drivers/net/ethernet/intel/ice/ice_adapter.c
+++ linux-tip.git/drivers/net/ethernet/intel/ice/ice_adapter.c
@@ -130,13 +130,13 @@ struct ice_adapter *ice_adapter_get(stru
*/
void ice_adapter_put(struct pci_dev *pdev)
{
+ const struct ice_pf *pf = pci_get_drvdata(pdev);
+ unsigned long index = pf->adapter->index;
struct ice_adapter *adapter;
- unsigned long index;
- index = ice_adapter_xa_index(pdev);
scoped_guard(mutex, &ice_adapters_mutex) {
adapter = xa_load(&ice_adapters, index);
- if (WARN_ON(!adapter))
+ if (WARN_ON(!adapter || adapter != pf->adapter))
return;
if (!refcount_dec_and_test(&adapter->refcount))
return;
next reply other threads:[~2026-05-13 9:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-13 9:09 Cyrill Gorcunov [this message]
2026-05-17 12:53 ` [PATCH] ice: Fix wrong dsn read in ice_adapter_put Simon Horman
2026-05-17 22:21 ` [PATCH v2] " Cyrill Gorcunov
2026-05-18 10:02 ` Cyrill Gorcunov
2026-05-18 14:36 ` Cyrill Gorcunov
2026-05-20 18:03 ` Simon Horman
2026-05-20 18:57 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=agQ_xZUp3Sq905O_@grain \
--to=gorcunov@gmail.com \
--cc=anthony.l.nguyen@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.