From: Dan Carpenter <error27@gmail.com>
To: Tomasz Unger <tomasz.unger@yahoo.pl>
Cc: Andy Shevchenko <andy@kernel.org>,
Hans de Goede <hansg@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-staging@lists.linux.dev
Subject: Re: [PATCH v3] staging: media: atomisp: remove stale "Generated code" comments
Date: Wed, 13 May 2026 10:00:18 +0300 [thread overview]
Message-ID: <agQhgsgYJfizeLuk@stanley.mountain> (raw)
In-Reply-To: <20260512-atomisp-remove-generated-comment-v3-1-97930e4e1ca8@yahoo.pl>
On Tue, May 12, 2026 at 08:10:52PM +0200, Tomasz Unger wrote:
> Remove the "Generated code: do not edit or commmit." comments and
> the resulting double blank lines from five files. This code is coupled
> with legacy firmware and will never be re-generated, so the comment
> is misleading and should be dropped entirely rather than having its
> typo fixed.
>
> Suggested-by: Dan Carpenter <error27@gmail.com>
I didn't really suggest it. I just pointed out that you need to
delete the blank line following it so the right way to do this would
be to put a little note under the ---
> Signed-off-by: Tomasz Unger <tomasz.unger@yahoo.pl>
> ---
^^^
cut off line, here.
v3: remove trailing blank lines (as noted by Dan Carpenter)
Although I'm also happy to boost my tag count so I don't really mind
being credited either.
regards,
dan carpenter
prev parent reply other threads:[~2026-05-13 7:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260512-atomisp-remove-generated-comment-v3-1-97930e4e1ca8.ref@yahoo.pl>
2026-05-12 18:10 ` [PATCH v3] staging: media: atomisp: remove stale "Generated code" comments Tomasz Unger
2026-05-12 19:25 ` Andy Shevchenko
2026-05-13 7:00 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=agQhgsgYJfizeLuk@stanley.mountain \
--to=error27@gmail.com \
--cc=andy@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tomasz.unger@yahoo.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.