From: Peng Fan <peng.fan@oss.nxp.com>
To: Vincent Jardin <vjardin@free.fr>
Cc: u-boot@lists.denx.de, Alice Guo <alice.guo@nxp.com>,
Fabio Estevam <festevam@gmail.com>,
Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>,
"NXP i.MX U-Boot Team" <uboot-imx@nxp.com>,
Stefano Babic <sbabic@nabladev.com>,
Tom Rini <trini@konsulko.com>, Wasim Khan <wasim.khan@nxp.com>
Subject: Re: [PATCH v1] board: nxp: common: support CONFIG_FSL_USE_PCA9547_MUX
Date: Wed, 13 May 2026 17:59:05 +0800 [thread overview]
Message-ID: <agRLae5P3EUV+G8L@shlinux89> (raw)
In-Reply-To: <20260510220751.578230-1-vjardin@free.fr>
On Mon, May 11, 2026 at 12:07:30AM +0200, Vincent Jardin wrote:
>Use select_i2c_ch_pca9547() only when CONFIG_FSL_USE_PCA9547_MUX
>is set, but several call in board/nxp/lx2160a/lx2160a.c invoke
>it unconditionally,
>or using unrelated Kconfigs (CONFIG_EMC2305, CONFIG_VID).
>
>Compilation with LX2160A target that omits the mux therefore fails with
>
> error: implicit declaration of function 'select_i2c_ch_pca9547'
>
>Add a static inline stub with -EOPNOTSUPP for the
>!CONFIG_FSL_USE_PCA9547_MUX case so all cases compile cleanly.
>
>Adapted from the convention used by include/scmi_nxp_protocols.h for
>SCMI subprotocol stubs.
>
>There is no functional change for NXP boards: all eight upstream
>LX2160A defconfigs (lx2160ardb / lx2160aqds / lx2162aqds and their
>secure / stmm / verified_boot variants) already set
>CONFIG_FSL_USE_PCA9547_MUX=y, so the real declaration wins.
>
>The purpose is to support new boards that do not use the PCA9547.
>
>Signed-off-by: Vincent Jardin <vjardin@free.fr>
>
Reviewed-by: Peng Fan <peng.fan@nxp.com>
prev parent reply other threads:[~2026-05-13 9:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-10 22:07 [PATCH v1] board: nxp: common: support CONFIG_FSL_USE_PCA9547_MUX Vincent Jardin
2026-05-13 9:59 ` Peng Fan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=agRLae5P3EUV+G8L@shlinux89 \
--to=peng.fan@oss.nxp.com \
--cc=alice.guo@nxp.com \
--cc=festevam@gmail.com \
--cc=meenakshi.aggarwal@nxp.com \
--cc=sbabic@nabladev.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=uboot-imx@nxp.com \
--cc=vjardin@free.fr \
--cc=wasim.khan@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.