From: Florian Westphal <fw@strlen.de>
To: Fernando Fernandez Mancera <fmancera@suse.de>
Cc: netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
phil@nwl.cc, pablo@netfilter.org,
Alejandro Olivan Alvarez <alejandro.olivan.alvarez@gmail.com>
Subject: Re: [PATCH nf] netfilter: nf_conncount: prevent connlimit drops for early confirmed ct
Date: Wed, 13 May 2026 14:45:52 +0200 [thread overview]
Message-ID: <agRygM7hHtKs8jQB@strlen.de> (raw)
In-Reply-To: <20260513121547.6434-1-fmancera@suse.de>
Fernando Fernandez Mancera <fmancera@suse.de> wrote:
> if (ct && nf_ct_is_confirmed(ct)) {
> - /* local connections are confirmed in postrouting so confirmation
> - * might have happened before hitting connlimit
> - */
> - if (skb->skb_iif != LOOPBACK_IFINDEX) {
> + if (test_bit(IPS_ASSURED_BIT, &ct->status) || ctinfo == IP_CT_ESTABLISHED) {
> err = -EEXIST;
> goto out_put;
> }
IIRC IP_CT_ESTABLISHED requires we can observe traffic in both
directions. I'm not sure it was a good idea to allow this new
usage case added in 69894e5b4c5e ("netfilter: nft_connlimit: update the count if add was skipped"),
but I don't think we can revert it either :-(
No idea how to fix this mess.
next prev parent reply other threads:[~2026-05-13 12:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-13 12:15 [PATCH nf] netfilter: nf_conncount: prevent connlimit drops for early confirmed ct Fernando Fernandez Mancera
2026-05-13 12:45 ` Florian Westphal [this message]
2026-05-13 13:48 ` Fernando Fernandez Mancera
2026-05-13 14:13 ` Florian Westphal
2026-05-13 14:52 ` Fernando Fernandez Mancera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=agRygM7hHtKs8jQB@strlen.de \
--to=fw@strlen.de \
--cc=alejandro.olivan.alvarez@gmail.com \
--cc=coreteam@netfilter.org \
--cc=fmancera@suse.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.