All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicolas Schier <nsc@kernel.org>
To: Julian Braha <julianbraha@gmail.com>
Cc: nathan@kernel.org, jani.nikula@linux.intel.com,
	akpm@linux-foundation.org, gary@garyguo.net, ljs@kernel.org,
	arnd@arndb.de, gregkh@linuxfoundation.org, masahiroy@kernel.org,
	ojeda@kernel.org, corbet@lwn.net, qingfang.deng@linux.dev,
	linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org,
	linux-doc@vger.kernel.org, linux-kbuild@vger.kernel.org
Subject: Re: [RFC v2 0/2] add kconfirm
Date: Wed, 13 May 2026 17:22:32 +0200	[thread overview]
Message-ID: <agSXOHvQqTxSsArW@levanger> (raw)
In-Reply-To: <20260509203808.1142311-1-julianbraha@gmail.com>

On Sat, May 09, 2026 at 09:38:06PM +0100, Julian Braha wrote:
> Hi all,
> 
> kconfirm is a tool to detect misusage of Kconfig. It detects dead code,
> constant conditions, and invalid (reverse) ranges. There are also optional
> checks to detect config options that select visible config options, and to
> check for dead links in the help texts.
> 
> The full patchset (with the vendored dependencies) is available in my
> linux fork, git branch 'kconfirm_rfc2', and is based on linux v7.1-rc2:
> https://github.com/julianbraha/linux/tree/kconfirm_rfc2

Thanks!  I like the idea of having a static analyser for kconfig!



I guess the github branch is expected to work out of the box, but on my arm64
system this fails with:

    kconfirm$ make -j8 kconfirm
    error: no matching package named `env_logger` found
    location searched: crates.io index
    required by package `kconfirm-lib v0.9.0 (/data/kbuild/kbuild-fixes/kconfirm/scripts/kconfirm/kconfirm-lib)`
    As a reminder, you're using offline mode (--offline) which can sometimes cause surprising resolution failures, if this error is too confusing you may wish to retry without the offline flag.
    make[2]: *** [Makefile:17: kconfirm] Error 101
    make[1]: *** [kconfirm/Makefile:2244: kconfirm] Error 2
    make: *** [Makefile:248: __sub-make] Error 2
    [exit code 2]

and if 'kconfirm' does not need a .config file, you want to add 'kconfirm' to
the list of 'no-dot-config-targets' in top-level Makefile.


FTR: the 'kconfirm' and 'kconfirmclean' targets need some love: both do not
really integrate in kbuild, yet: 'kconfirm' is not working with out-of-source
builds (O=...), 'kconfirmclean' should not be required if 'make clean' is
supported correctly, and 'make mrproper' removes the whole scripts/kconfirm
tree due to the change in 'scripts/Makefile'.  (Tested?)

> 
> The patches sent here with the RFC include everything other than the
> vendored dependencies, including the tool's code, the documentation, and
> the makefile changes.
> Following this discussion:
> https://lore.kernel.org/all/20260405122749.4990dcb538d457769a3276e0@linux-foundation.org/
> in which Andrew brought up the possibility of moving kconfirm in-tree,
> I've prepared this RFC to do so. See also kconfirm's introduction to the
> mailing list:
> https://lore.kernel.org/all/6ec4df6d-1445-48ca-8f54-1d1a83c4716d@gmail.com/

The large amount of changes has been mentioned often enough;  even if all the
vendored dependencies could be dropped, I am not convinced yet, that it is a
good idea to maintain kconfirm in-tree due to its project size.

IMO, we need at least someone who steps up for maintaining kconfirm and
registers in a dedicated MAINTAINERS entry.  (My own rust knowledge is not good
enough for appropriate review, I can only offer some initial testing and
frequent use when it is working/integrated.)

Kind regards,
Nicolas

  parent reply	other threads:[~2026-05-13 15:23 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-09 20:38 [RFC v2 0/2] add kconfirm Julian Braha
2026-05-09 20:38 ` [RFC PATCH v2 1/2] scripts: " Julian Braha
2026-05-11  9:57   ` Jani Nikula
2026-05-11 13:18     ` Julian Braha
2026-05-09 20:38 ` [RFC PATCH v2 2/2] Documentation: dev-tools: " Julian Braha
2026-05-10  5:06 ` [RFC v2 0/2] " Jan Engelhardt
2026-05-10  9:49   ` Miguel Ojeda
2026-05-10 23:06     ` Julian Braha
2026-05-13 14:12       ` Julian Braha
2026-05-10 23:28     ` Jan Engelhardt
2026-05-13 15:52       ` Miguel Ojeda
2026-05-11  4:24 ` Demi Marie Obenour
2026-05-13 13:59   ` Julian Braha
2026-05-13 15:22 ` Nicolas Schier [this message]
2026-05-13 16:04   ` Julian Braha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=agSXOHvQqTxSsArW@levanger \
    --to=nsc@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=corbet@lwn.net \
    --cc=gary@garyguo.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=julianbraha@gmail.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ljs@kernel.org \
    --cc=masahiroy@kernel.org \
    --cc=nathan@kernel.org \
    --cc=ojeda@kernel.org \
    --cc=qingfang.deng@linux.dev \
    --cc=rust-for-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.