From: Zhao Liu <zhao1.liu@intel.com>
To: Igor Mammedov <imammedo@redhat.com>
Cc: qemu-devel@nongnu.org, mst@redhat.com, anisinha@redhat.com,
pbonzini@redhat.com, peter.maydell@linaro.org,
shannon.zhaosl@gmail.com, philmd@linaro.org, rad@semihalf.com,
leif.lindholm@oss.qualcomm.com, qemu-arm@nongnu.org
Subject: Re: [PATCH v2 06/21] tests: acpi: x86/q35: update expected WDAT blob
Date: Wed, 13 May 2026 23:48:04 +0800 [thread overview]
Message-ID: <agSdNF7GFYgJK0vt@intel.com> (raw)
In-Reply-To: <20260303092532.2410177-7-imammedo@redhat.com>
On Tue, Mar 03, 2026 at 10:25:17AM +0100, Igor Mammedov wrote:
> Date: Tue, 3 Mar 2026 10:25:17 +0100
> From: Igor Mammedov <imammedo@redhat.com>
> Subject: [PATCH v2 06/21] tests: acpi: x86/q35: update expected WDAT blob
>
> replace blank table with a new one:
>
> +[000h 0000 4] Signature : "WDAT" [Watchdog Action Table]
> +[004h 0004 4] Table Length : 00000134
> +[008h 0008 1] Revision : 01
> +[009h 0009 1] Checksum : 31
> +[00Ah 0010 6] Oem ID : "BOCHS "
> +[010h 0016 8] Oem Table ID : "BXPC "
> +[018h 0024 4] Oem Revision : 00000001
> +[01Ch 0028 4] Asl Compiler ID : "BXPC"
> +[020h 0032 4] Asl Compiler Revision : 00000001
> +
> +[024h 0036 4] Header Length : 00000020
> +[028h 0040 2] PCI Segment : 00FF
> +[02Ah 0042 1] PCI Bus : FF
> +[02Bh 0043 1] PCI Device : FF
> +[02Ch 0044 1] PCI Function : FF
> +[02Dh 0045 3] Reserved : 000000
> +[030h 0048 4] Timer Period : 00000258
> +[034h 0052 4] Max Count : 000003FF
> +[038h 0056 4] Min Count : 00000004
> +[03Ch 0060 1] Flags (decoded below) : 81
> + Enabled : 1
> + Stopped When Asleep : 1
> +[03Dh 0061 3] Reserved : 000000
> +[040h 0064 4] Watchdog Entry Count : 0000000A
> +
> +[044h 0068 1] Watchdog Action : 01
> +[045h 0069 1] Instruction : 02
> +[046h 0070 2] Reserved : 0000
> +
> +[048h 0072 12] Register Region : [Generic Address Structure]
> +[048h 0072 1] Space ID : 01 [SystemIO]
> +[049h 0073 1] Bit Width : 10
> +[04Ah 0074 1] Bit Offset : 00
> +[04Bh 0075 1] Encoded Access Width : 02 [Word Access:16]
> +[04Ch 0076 8] Address : 0000000000000660
> +
> +[054h 0084 4] Value : 00000001
> +[058h 0088 4] Register Mask : 000001FF
> +
> +[05Ch 0092 1] Watchdog Action : 08
> +[05Dh 0093 1] Instruction : 00
> +[05Eh 0094 2] Reserved : 0000
> +
> +[060h 0096 12] Register Region : [Generic Address Structure]
> +[060h 0096 1] Space ID : 01 [SystemIO]
> +[061h 0097 1] Bit Width : 10
> +[062h 0098 1] Bit Offset : 00
> +[063h 0099 1] Encoded Access Width : 02 [Word Access:16]
> +[064h 0100 8] Address : 0000000000000668
> +
> +[06Ch 0108 4] Value : 00000000
> +[070h 0112 4] Register Mask : 00000800
> +
> +[074h 0116 1] Watchdog Action : 09
> +[075h 0117 1] Instruction : 82
> +[076h 0118 2] Reserved : 0000
> +
> +[078h 0120 12] Register Region : [Generic Address Structure]
> +[078h 0120 1] Space ID : 01 [SystemIO]
> +[079h 0121 1] Bit Width : 10
> +[07Ah 0122 1] Bit Offset : 00
> +[07Bh 0123 1] Encoded Access Width : 02 [Word Access:16]
> +[07Ch 0124 8] Address : 0000000000000668
> +
> +[084h 0132 4] Value : 00000000
> +[088h 0136 4] Register Mask : 00000800
> +
> +[08Ch 0140 1] Watchdog Action : 0A
> +[08Dh 0141 1] Instruction : 00
> +[08Eh 0142 2] Reserved : 0000
> +
> +[090h 0144 12] Register Region : [Generic Address Structure]
> +[090h 0144 1] Space ID : 01 [SystemIO]
> +[091h 0145 1] Bit Width : 10
> +[092h 0146 1] Bit Offset : 00
> +[093h 0147 1] Encoded Access Width : 02 [Word Access:16]
> +[094h 0148 8] Address : 0000000000000668
> +
> +[09Ch 0156 4] Value : 00000800
> +[0A0h 0160 4] Register Mask : 00000800
> +
> +[0A4h 0164 1] Watchdog Action : 0B
> +[0A5h 0165 1] Instruction : 82
> +[0A6h 0166 2] Reserved : 0000
> +
> +[0A8h 0168 12] Register Region : [Generic Address Structure]
> +[0A8h 0168 1] Space ID : 01 [SystemIO]
> +[0A9h 0169 1] Bit Width : 10
> +[0AAh 0170 1] Bit Offset : 00
> +[0ABh 0171 1] Encoded Access Width : 02 [Word Access:16]
> +[0ACh 0172 8] Address : 0000000000000668
> +
> +[0B4h 0180 4] Value : 00000800
> +[0B8h 0184 4] Register Mask : 00000800
> +
> +[0BCh 0188 1] Watchdog Action : 06
> +[0BDh 0189 1] Instruction : 03
> +[0BEh 0190 2] Reserved : 0000
> +
> +[0C0h 0192 12] Register Region : [Generic Address Structure]
> +[0C0h 0192 1] Space ID : 01 [SystemIO]
> +[0C1h 0193 1] Bit Width : 10
> +[0C2h 0194 1] Bit Offset : 00
> +[0C3h 0195 1] Encoded Access Width : 02 [Word Access:16]
> +[0C4h 0196 8] Address : 0000000000000672
> +
> +[0CCh 0204 4] Value : 00000000
> +[0D0h 0208 4] Register Mask : 000003FF
> +
> +[0D4h 0212 1] Watchdog Action : 05
> +[0D5h 0213 1] Instruction : 01
> +[0D6h 0214 2] Reserved : 0000
> +
> +[0D8h 0216 12] Register Region : [Generic Address Structure]
> +[0D8h 0216 1] Space ID : 01 [SystemIO]
> +[0D9h 0217 1] Bit Width : 10
> +[0DAh 0218 1] Bit Offset : 00
> +[0DBh 0219 1] Encoded Access Width : 02 [Word Access:16]
> +[0DCh 0220 8] Address : 0000000000000672
> +
> +[0E4h 0228 4] Value : 00000000
> +[0E8h 0232 4] Register Mask : 000003FF
> +
> +[0ECh 0236 1] Watchdog Action : 20
> +[0EDh 0237 1] Instruction : 00
> +[0EEh 0238 2] Reserved : 0000
> +
> +[0F0h 0240 12] Register Region : [Generic Address Structure]
> +[0F0h 0240 1] Space ID : 01 [SystemIO]
> +[0F1h 0241 1] Bit Width : 10
> +[0F2h 0242 1] Bit Offset : 00
> +[0F3h 0243 1] Encoded Access Width : 02 [Word Access:16]
> +[0F4h 0244 8] Address : 0000000000000666
> +
> +[0FCh 0252 4] Value : 00000002
> +[100h 0256 4] Register Mask : 00000002
> +
> +[104h 0260 1] Watchdog Action : 21
> +[105h 0261 1] Instruction : 82
> +[106h 0262 2] Reserved : 0000
> +
> +[108h 0264 12] Register Region : [Generic Address Structure]
> +[108h 0264 1] Space ID : 01 [SystemIO]
> +[109h 0265 1] Bit Width : 10
> +[10Ah 0266 1] Bit Offset : 00
> +[10Bh 0267 1] Encoded Access Width : 02 [Word Access:16]
> +[10Ch 0268 8] Address : 0000000000000666
> +
> +[114h 0276 4] Value : 00000002
> +[118h 0280 4] Register Mask : 00000002
> +
> +[11Ch 0284 1] Watchdog Action : 21
> +[11Dh 0285 1] Instruction : 82
> +[11Eh 0286 2] Reserved : 0000
> +
> +[120h 0288 12] Register Region : [Generic Address Structure]
> +[120h 0288 1] Space ID : 01 [SystemIO]
> +[121h 0289 1] Bit Width : 10
> +[122h 0290 1] Bit Offset : 00
> +[123h 0291 1] Encoded Access Width : 02 [Word Access:16]
> +[124h 0292 8] Address : 0000000000000666
> +
> +[12Ch 0300 4] Value : 00000004
> +[130h 0304 4] Register Mask : 00000004
>
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> Acked-by: Ani Sinha <anisinha@redhat.com>
> ---
> tests/qtest/bios-tables-test-allowed-diff.h | 1 -
> tests/data/acpi/x86/q35/WDAT.wdat | Bin 0 -> 308 bytes
> 2 files changed, 1 deletion(-)
Reviewed-by: Zhao Liu <zhao1.liu@intel.com>
next prev parent reply other threads:[~2026-05-13 15:20 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-03 9:25 [PATCH v2 00/21] Introduce ACPI watchdog for Q35 and arm/virt boards Igor Mammedov
2026-03-03 9:25 ` [PATCH v2 01/21] acpi: add API to build WDAT instructions Igor Mammedov
2026-05-13 15:23 ` Zhao Liu
2026-03-03 9:25 ` [PATCH v2 02/21] x86: q35: add 'wdat' property Igor Mammedov
2026-05-13 14:58 ` Zhao Liu
2026-05-14 7:16 ` Ani Sinha
2026-03-03 9:25 ` [PATCH v2 03/21] x86: q35: generate WDAT ACPI table Igor Mammedov
2026-05-13 15:47 ` Zhao Liu
2026-05-13 15:28 ` Michael S. Tsirkin
2026-05-14 14:32 ` Igor Mammedov
2026-03-03 9:25 ` [PATCH v2 04/21] tests: acpi: x86/q35: whitelist new WDAT table Igor Mammedov
2026-05-13 15:48 ` Zhao Liu
2026-03-03 9:25 ` [PATCH v2 05/21] tests: acpi: x86/q35: add WDAT table test case Igor Mammedov
2026-05-13 15:49 ` Zhao Liu
2026-03-03 9:25 ` [PATCH v2 06/21] tests: acpi: x86/q35: update expected WDAT blob Igor Mammedov
2026-05-13 15:48 ` Zhao Liu [this message]
2026-03-03 9:25 ` [PATCH v2 07/21] arm: sbsa_gwdt: fixup default "clock-frequency" Igor Mammedov
2026-03-03 9:25 ` [PATCH v2 08/21] arm: add tracing events to sbsa_gwdt Igor Mammedov
2026-03-03 9:25 ` [PATCH v2 09/21] arm: virt: create sbsa_gwdt watchdog Igor Mammedov
2026-03-03 9:25 ` [PATCH v2 10/21] arm: sbsa_gwdt: add 'wdat' option Igor Mammedov
2026-03-03 9:25 ` [PATCH v2 11/21] arm: virt: add support for WDAT based watchdog Igor Mammedov
2026-03-03 9:25 ` [PATCH v2 12/21] tests: acpi: arm/virt: whitelist new WDAT table Igor Mammedov
2026-03-03 9:25 ` [PATCH v2 13/21] tests: acpi: arm/virt: add WDAT table test case Igor Mammedov
2026-03-03 9:25 ` [PATCH v2 14/21] tests: acpi: arm/virt: update expected WDAT blob Igor Mammedov
2026-03-03 9:25 ` [PATCH v2 15/21] tests: acpi: arm/virt: whitelist GTDT table Igor Mammedov
2026-03-03 9:25 ` [PATCH v2 16/21] tests: acpi: arm/virt: add GTDT watchdog table test case Igor Mammedov
2026-03-03 9:25 ` [PATCH v2 17/21] tests: acpi: arm/virt: update expected GTDT blob Igor Mammedov
2026-03-03 9:25 ` [PATCH v2 18/21] sbsa_gwdt: reduce code ident Igor Mammedov
2026-03-03 9:25 ` [PATCH v2 19/21] sbsa_gwdt: move all foo_REFRESH logic under REFRESH condition Igor Mammedov
2026-03-03 9:25 ` [PATCH v2 20/21] sbsa_gwdt: reschedule timer on direct WCV load Igor Mammedov
2026-03-03 9:25 ` [PATCH v2 21/21] sbsa_gwdt: limit compare_value to INT64_MAX Igor Mammedov
2026-04-28 14:12 ` [PATCH v2 00/21] Introduce ACPI watchdog for Q35 and arm/virt boards Igor Mammedov
2026-05-12 13:30 ` Igor Mammedov
2026-05-12 14:45 ` Ani Sinha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=agSdNF7GFYgJK0vt@intel.com \
--to=zhao1.liu@intel.com \
--cc=anisinha@redhat.com \
--cc=imammedo@redhat.com \
--cc=leif.lindholm@oss.qualcomm.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rad@semihalf.com \
--cc=shannon.zhaosl@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.