From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Andre Przywara <andre.przywara@arm.com>
Cc: "Sanjay Chitroda" <sanjayembeddedse@gmail.com>,
"Michal Piekos" <michal.piekos@mmpsystems.pl>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Chen-Yu Tsai" <wens@kernel.org>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Samuel Holland" <samuel@sholland.org>,
"Maksim Kiselev" <bigunclemax@gmail.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] iio: adc: sun20i-gpadc: add A523 gpadc support
Date: Wed, 13 May 2026 23:12:05 +0300 [thread overview]
Message-ID: <agTbFbicv9yzTQb9@ashevche-desk.local> (raw)
In-Reply-To: <4248ac7e-3cce-4db8-a2c1-710f2c903490@arm.com>
On Wed, May 13, 2026 at 01:53:49PM +0200, Andre Przywara wrote:
> On 5/13/26 13:44, Sanjay Chitroda wrote:
> > On 13 May 2026 10:29:43 am IST, Michal Piekos <michal.piekos@mmpsystems.pl> wrote:
> > > + if (ret <= 0)
> >
> > Thank you Michal for the change.
> >
> > Have you validated the changes ?
> > It looks while success ret would be 0 and it would give return error.
Good catch!
> But devm_clk_bulk_get_all_enabled() returns the number of clocks found and
> enabled. And since we need at least one, I think this is correct, and the
> error message below reflects that.
>
> To me that change looks good:
>
> Reviewed-by: Andre Przywara <andre.przywara@arm.com>
== 0 ???
Doesn't look like correct code.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-05-13 20:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-13 4:59 [PATCH v2 0/3] Add GPADC support for A523 Michal Piekos
2026-05-13 4:59 ` [PATCH v2 1/3] dt-bindings: iio: adc: Add GPADC for Allwinner A523 Michal Piekos
2026-05-13 19:15 ` Conor Dooley
2026-05-14 2:23 ` sashiko-bot
2026-05-13 4:59 ` [PATCH v2 2/3] iio: adc: sun20i-gpadc: add A523 gpadc support Michal Piekos
2026-05-13 11:44 ` Sanjay Chitroda
2026-05-13 11:53 ` Andre Przywara
2026-05-13 16:16 ` Jonathan Cameron
2026-05-13 21:34 ` Andre Przywara
2026-05-13 20:12 ` Andy Shevchenko [this message]
2026-05-13 21:19 ` Andre Przywara
2026-05-13 21:34 ` Andy Shevchenko
2026-05-13 20:10 ` Andy Shevchenko
2026-05-14 2:29 ` sashiko-bot
2026-05-13 4:59 ` [PATCH v2 3/3] arm64: dts: allwinner: a523: add gpadc node Michal Piekos
2026-05-14 2:42 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=agTbFbicv9yzTQb9@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andre.przywara@arm.com \
--cc=andy@kernel.org \
--cc=bigunclemax@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jernej.skrabec@gmail.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=michal.piekos@mmpsystems.pl \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
--cc=samuel@sholland.org \
--cc=sanjayembeddedse@gmail.com \
--cc=wens@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.