From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B11A131F987; Thu, 14 May 2026 01:42:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778722975; cv=none; b=jh5uu7dOUPhqnFCZYN0GVcdEUJg0oaiI8Y+WNUpHxySfwX671UdquLcRY/ruvps12MeXrtLUFxeaKq60XUdhYSAWkt1GhMx+wq1Eu9UrjiYFT0lt+iiWG1ekpN8uydYIL1al/nDPGRdiCDYcKq0bQ1KrwZZu78Vu3emz1rpnzkM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778722975; c=relaxed/simple; bh=oBhCuHah8JcJzRxbSplEMoBSn9c7+hDNbVI06xJE8n0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=S8mXB6oDdHQcSKOs2I6FVy9UeC7mlfqTEH4CmJj90lC4yflZvAsBpABnfmIEVlb8OvQxDHoh7y0gvF/T3C1PB/08oLcr0U5lvgSRcRBCbJKmFbWYWn4VMKTFhDp8h2s1ypguwx1hXo3iPmpUoq4BMs7VvjjZBwNRcGjxHmRlT5c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=LUQEggTA; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="LUQEggTA" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 35F06C19425; Thu, 14 May 2026 01:42:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778722975; bh=oBhCuHah8JcJzRxbSplEMoBSn9c7+hDNbVI06xJE8n0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LUQEggTAnbX4mghOtvtXKy799oS38unx1v4B51VTgl0oxzaZHIsTAk+Ry6m2ICAjM wuw0qSH0EwNXwcWMmVOf5X7kiasv6J0sX73J3K2IbLorAOx1KyIpASgpQMO4lpMRFE 1855QjA+/cHbABktGQpZ0j14oMOIDBq4PAV73j+WRSUU4eraKAR4mtxxPFqzH2c+pm //n86azelmDEacVYHBeumOhiBw3QOBqA4YibPkhizu4H6x7KWZiYmpeiQ3Q1YkgGSG ZAhLaPm/eegbbHtNhauBtVT0viC+mYbmzzq7l9BXpOzcneBho3WnJaOtsgA3FZvkyN 50leu6uVsOc9w== Date: Thu, 14 May 2026 09:42:49 +0800 From: "Peter Chen (CIX)" To: Svyatoslav Ryhel Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vinod Koul , Neil Armstrong , Thierry Reding , Jonathan Hunter , Greg Kroah-Hartman , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-tegra@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH v1 2/6] usb: chipidea: tegra: Avoid controller/PHY init if bus is externally controlled Message-ID: References: <20260511135703.62470-1-clamor95@gmail.com> <20260511135703.62470-3-clamor95@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On 26-05-13 20:30:10, Svyatoslav Ryhel wrote: > вт, 12 трав. 2026 р. о 10:51 Peter Chen (CIX) пише: > > > > On 26-05-12 09:13:40, Svyatoslav Ryhel wrote: > > > вт, 12 трав. 2026 р. о 04:16 Peter Chen (CIX) пише: > > > > > > > > On 26-05-11 16:56:57, Svyatoslav Ryhel wrote: > > > > > If the USB controller and PHY are externally controlled, then the > > > > > registration of the controller and the PHY initialization should be > > > > > skipped, since these configurations must be done by the device that > > > > > controls the bus to work correctly. > > > > > > > > > > > > > I find you only control USB controller device add at PHY driver, most of USB drivers > > > > has PHY control, for chipidea, it has PHY control at core.c, would please try to > > > > adapt for it? > > > > > > > > > > Usually yes, but this is not the case for Tegra unfortunately. As you > > > can see Tegra specific section of Chipidea driver specifically > > > describes why it has to set PHY manually. > > > > > > /* > > > * USB controller registers shouldn't be touched before PHY is > > > * initialized, otherwise CPU will hang because clocks are gated. > > > * PHY driver controls gating of internal USB clocks on Tegra. > > > */ > > > > > > So in order to provide correct work of USB when set by an external > > > device, both PHY and controller init/add must be skipped. > > > > You could call generic PHY APIs at ci_hdrc_tegra.c, after PHY init or power on, > > call controller initialization. > > > > I was tinkering with Chipidea driver for Tegra a bit. If you meant to > use flag only to control usb controller device init and leave PHY to > be handled by controller, then yes, that is possible and that is > better approach. > Yes, you may summarize the initialization sequence, and see if put PHY control at Tegra glue layer or at Chipidea core. -- Best regards, Peter From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 728EACD4F21 for ; Thu, 14 May 2026 01:42:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=22/0SKHgL5UUctFK5nCdcXaFATjIWGGWxpeD9IGYhWo=; b=XNL47XNnwnaN9O CVgJJEVXKJz0+wFKwQXXT7VmTm0U2MJVkqbZN1dF3U0FmKvGHukBIq9RrOESZLwN89GD2HFAfBSM9 AkyKb2iLQmD4C9yq+jfDcCLwo02Ye+W/bs9MaFt7jR3otyFQiSLsrzxqdAf+fFVfSGUepdnGvjfEE gJuND3B/fpTgMNWSRZzdB2Qx274DvTR0JMRsu8icPTzT3v3rVJbQYvVT/7YbfGOeMQp6f0EvevyEi ICnlME5trAgVfcQaLpv1Y0FKdiF+jGFFCcVd92HxvJF9OGRasr0kAb/EjjsriUG6e2dchlVqI6Aab CflPUqvzLekYsi8l0lkA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wNL6H-00000004INX-44Ei; Thu, 14 May 2026 01:42:57 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wNL6G-00000004IN2-1N2S for linux-phy@lists.infradead.org; Thu, 14 May 2026 01:42:57 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 7F7AC40DF9; Thu, 14 May 2026 01:42:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 35F06C19425; Thu, 14 May 2026 01:42:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778722975; bh=oBhCuHah8JcJzRxbSplEMoBSn9c7+hDNbVI06xJE8n0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LUQEggTAnbX4mghOtvtXKy799oS38unx1v4B51VTgl0oxzaZHIsTAk+Ry6m2ICAjM wuw0qSH0EwNXwcWMmVOf5X7kiasv6J0sX73J3K2IbLorAOx1KyIpASgpQMO4lpMRFE 1855QjA+/cHbABktGQpZ0j14oMOIDBq4PAV73j+WRSUU4eraKAR4mtxxPFqzH2c+pm //n86azelmDEacVYHBeumOhiBw3QOBqA4YibPkhizu4H6x7KWZiYmpeiQ3Q1YkgGSG ZAhLaPm/eegbbHtNhauBtVT0viC+mYbmzzq7l9BXpOzcneBho3WnJaOtsgA3FZvkyN 50leu6uVsOc9w== Date: Thu, 14 May 2026 09:42:49 +0800 From: "Peter Chen (CIX)" To: Svyatoslav Ryhel Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vinod Koul , Neil Armstrong , Thierry Reding , Jonathan Hunter , Greg Kroah-Hartman , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-tegra@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH v1 2/6] usb: chipidea: tegra: Avoid controller/PHY init if bus is externally controlled Message-ID: References: <20260511135703.62470-1-clamor95@gmail.com> <20260511135703.62470-3-clamor95@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260513_184256_406348_BFE8EAD2 X-CRM114-Status: GOOD ( 23.69 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org T24gMjYtMDUtMTMgMjA6MzA6MTAsIFN2eWF0b3NsYXYgUnloZWwgd3JvdGU6Cj4g0LLRgiwgMTIg 0YLRgNCw0LIuIDIwMjbigK/RgC4g0L4gMTA6NTEgUGV0ZXIgQ2hlbiAoQ0lYKSA8cGV0ZXIuY2hl bkBrZXJuZWwub3JnPiDQv9C40YjQtToKPiA+Cj4gPiBPbiAyNi0wNS0xMiAwOToxMzo0MCwgU3Z5 YXRvc2xhdiBSeWhlbCB3cm90ZToKPiA+ID4g0LLRgiwgMTIg0YLRgNCw0LIuIDIwMjbigK/RgC4g 0L4gMDQ6MTYgUGV0ZXIgQ2hlbiAoQ0lYKSA8cGV0ZXIuY2hlbkBrZXJuZWwub3JnPiDQv9C40YjQ tToKPiA+ID4gPgo+ID4gPiA+IE9uIDI2LTA1LTExIDE2OjU2OjU3LCBTdnlhdG9zbGF2IFJ5aGVs IHdyb3RlOgo+ID4gPiA+ID4gSWYgdGhlIFVTQiBjb250cm9sbGVyIGFuZCBQSFkgYXJlIGV4dGVy bmFsbHkgY29udHJvbGxlZCwgdGhlbiB0aGUKPiA+ID4gPiA+IHJlZ2lzdHJhdGlvbiBvZiB0aGUg Y29udHJvbGxlciBhbmQgdGhlIFBIWSBpbml0aWFsaXphdGlvbiBzaG91bGQgYmUKPiA+ID4gPiA+ IHNraXBwZWQsIHNpbmNlIHRoZXNlIGNvbmZpZ3VyYXRpb25zIG11c3QgYmUgZG9uZSBieSB0aGUg ZGV2aWNlIHRoYXQKPiA+ID4gPiA+IGNvbnRyb2xzIHRoZSBidXMgdG8gd29yayBjb3JyZWN0bHku Cj4gPiA+ID4gPgo+ID4gPiA+Cj4gPiA+ID4gSSBmaW5kIHlvdSBvbmx5IGNvbnRyb2wgVVNCIGNv bnRyb2xsZXIgZGV2aWNlIGFkZCBhdCBQSFkgZHJpdmVyLCBtb3N0IG9mIFVTQiBkcml2ZXJzCj4g PiA+ID4gaGFzIFBIWSBjb250cm9sLCBmb3IgY2hpcGlkZWEsIGl0IGhhcyBQSFkgY29udHJvbCBh dCBjb3JlLmMsIHdvdWxkIHBsZWFzZSB0cnkgdG8KPiA+ID4gPiBhZGFwdCBmb3IgaXQ/Cj4gPiA+ ID4KPiA+ID4KPiA+ID4gVXN1YWxseSB5ZXMsIGJ1dCB0aGlzIGlzIG5vdCB0aGUgY2FzZSBmb3Ig VGVncmEgdW5mb3J0dW5hdGVseS4gQXMgeW91Cj4gPiA+IGNhbiBzZWUgVGVncmEgc3BlY2lmaWMg c2VjdGlvbiBvZiBDaGlwaWRlYSBkcml2ZXIgc3BlY2lmaWNhbGx5Cj4gPiA+IGRlc2NyaWJlcyB3 aHkgaXQgaGFzIHRvIHNldCBQSFkgbWFudWFsbHkuCj4gPiA+Cj4gPiA+IC8qCj4gPiA+ICAqIFVT QiBjb250cm9sbGVyIHJlZ2lzdGVycyBzaG91bGRuJ3QgYmUgdG91Y2hlZCBiZWZvcmUgUEhZIGlz Cj4gPiA+ICAqIGluaXRpYWxpemVkLCBvdGhlcndpc2UgQ1BVIHdpbGwgaGFuZyBiZWNhdXNlIGNs b2NrcyBhcmUgZ2F0ZWQuCj4gPiA+ICAqIFBIWSBkcml2ZXIgY29udHJvbHMgZ2F0aW5nIG9mIGlu dGVybmFsIFVTQiBjbG9ja3Mgb24gVGVncmEuCj4gPiA+ICAqLwo+ID4gPgo+ID4gPiBTbyBpbiBv cmRlciB0byBwcm92aWRlIGNvcnJlY3Qgd29yayBvZiBVU0Igd2hlbiBzZXQgYnkgYW4gZXh0ZXJu YWwKPiA+ID4gZGV2aWNlLCBib3RoIFBIWSBhbmQgY29udHJvbGxlciBpbml0L2FkZCBtdXN0IGJl IHNraXBwZWQuCj4gPgo+ID4gWW91IGNvdWxkIGNhbGwgZ2VuZXJpYyBQSFkgQVBJcyBhdCBjaV9o ZHJjX3RlZ3JhLmMsIGFmdGVyIFBIWSBpbml0IG9yIHBvd2VyIG9uLAo+ID4gY2FsbCBjb250cm9s bGVyIGluaXRpYWxpemF0aW9uLgo+ID4KPiAKPiBJIHdhcyB0aW5rZXJpbmcgd2l0aCBDaGlwaWRl YSBkcml2ZXIgZm9yIFRlZ3JhIGEgYml0LiBJZiB5b3UgbWVhbnQgdG8KPiB1c2UgZmxhZyBvbmx5 IHRvIGNvbnRyb2wgdXNiIGNvbnRyb2xsZXIgZGV2aWNlIGluaXQgYW5kIGxlYXZlIFBIWSB0bwo+ IGJlIGhhbmRsZWQgYnkgY29udHJvbGxlciwgdGhlbiB5ZXMsIHRoYXQgaXMgcG9zc2libGUgYW5k IHRoYXQgaXMKPiBiZXR0ZXIgYXBwcm9hY2guCj4gCgpZZXMsIHlvdSBtYXkgc3VtbWFyaXplIHRo ZSBpbml0aWFsaXphdGlvbiBzZXF1ZW5jZSwgYW5kIHNlZSBpZiBwdXQgUEhZCmNvbnRyb2wgYXQg VGVncmEgZ2x1ZSBsYXllciBvciBhdCBDaGlwaWRlYSBjb3JlLgoKLS0gCgpCZXN0IHJlZ2FyZHMs ClBldGVyCgotLSAKbGludXgtcGh5IG1haWxpbmcgbGlzdApsaW51eC1waHlAbGlzdHMuaW5mcmFk ZWFkLm9yZwpodHRwczovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51 eC1waHkK