From: Herbert Xu <herbert@gondor.apana.org.au>
To: Dong Chenchen <dongchenchen2@huawei.com>
Cc: steffen.klassert@secunet.com, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
horms@kernel.org, tpluszz77@gmail.com, netdev@vger.kernel.org,
zhangchangzhong@huawei.com
Subject: Re: [PATCH net] net: xfrm: Fix dev refcnt leak in async resumption
Date: Thu, 14 May 2026 12:53:07 +0800 [thread overview]
Message-ID: <agVVM1ArZMFS4bl4@gondor.apana.org.au> (raw)
In-Reply-To: <20260509074443.104163-1-dongchenchen2@huawei.com>
On Sat, May 09, 2026 at 03:44:43PM +0800, Dong Chenchen wrote:
> xfrm async resumption hold dev ref until after transport_finish.
> When afinfo is NULL (e.g. x->props.family is invalid) and xfrm_gro
> is not set, dev_put in transport_finish() and xfrm_gro path is skipped.
> This will trigger refcnt leak.
There should never be a an xfrm_state with a NULL afinfo.
That would be a serious bug.
How did you trigger this?
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2026-05-14 4:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-09 7:44 [PATCH net] net: xfrm: Fix dev refcnt leak in async resumption Dong Chenchen
2026-05-13 17:07 ` Simon Horman
2026-05-14 3:43 ` dongchenchen (A)
2026-05-14 4:53 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=agVVM1ArZMFS4bl4@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=davem@davemloft.net \
--cc=dongchenchen2@huawei.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=steffen.klassert@secunet.com \
--cc=tpluszz77@gmail.com \
--cc=zhangchangzhong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.