From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3397A31E852 for ; Thu, 14 May 2026 21:17:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778793432; cv=none; b=rfW2ODqMUnhlJVJDQBTEjmds+iCq1g9cmxKZrf/O4erF6bxWixDFCPLRT8azzXQrFHoIRTA+0H2ArXqMc7ot+GrwTNMQHcA8WHsKujMmiUr1C4KKEIHzdnfKD4gZDjoHMUx9/Ycjez2P7rkhcBgw+rwElSUyOjHUAOHSRAdTFZI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778793432; c=relaxed/simple; bh=f374yOOteT1lhWHVc3xDSLLUiTmrQ+/1duYD3PPrNr0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ozari8KiIiScy+Z3/F2bX91AjiouSEBL0gT6fhV9X6nzBa4OJpg5c0FpYKzFK2uNFGIJ9bxshA6tV6Jy0AqxGsc5TwkJTx/mKJw81qEZ/vLMGSEzAjSRwf9uo9pzvsQjQrG+QC0XOk/KZkmcCA0tEWWqtGzyRCs33s+CkQr97A0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=T1NaVI1z; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="T1NaVI1z" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-45ae6a0e523so2418769f8f.1 for ; Thu, 14 May 2026 14:17:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778793430; x=1779398230; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:mail-followup-to:message-id:subject:cc:to :from:date:from:to:cc:subject:date:message-id:reply-to; bh=HmU2QdCe85bILypWHefyZFVcWWsKYpG1noJcgT8vi7w=; b=T1NaVI1z7c9HyIoJE0R+iCzGtJ37ikQQ6JFCihz7cqTERVTh+rkWsEqm1g1Uvx5cHC k/jbBPSJAhBAk5nYM/zAJp76bTy7XUdjALOBbWI9mwKZtq7cbuY26e1/eN76CI6q5Pf0 kLAh1IrDiDpyGew0fj96501w8mQBKbVVf8EclQ3o/d8LeLRYFq3WFtYp9NLni66uSV6+ RxZcxF2OJAjA/dSWynekC/uXiCAHqKbqIoRgr9pYAkgKiQsZbq1S8YEZk3okDMKKK4Nx Sagty2UvhsmJTyQnu3p1ndOmLBdSsLvKu2TidN3/KII4JA1o2BdfkyDJZJ07y2ry3uMc vNNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778793430; x=1779398230; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:mail-followup-to:message-id:subject:cc:to :from:date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=HmU2QdCe85bILypWHefyZFVcWWsKYpG1noJcgT8vi7w=; b=eDIzTgAujffxRYNGM2JYLswJuyHKZJTm/t/u2zc5YZtG4hMSF9PrwGUsDgfGJE4BiI uXtuEaogWo86iUqDzbYem1OCnUZRPsPoflUQqvx/8dseU0QAbN+D4/Biua6sGQARnGFN 2m0Qj1f7+5j43BcUXRW2tMMy467VxetEGb5V4Q3gxY0+b11EJy1BcT3uxa5Z8cNyPVj2 YdHp9TcfgAIQKgvnkuzDXMT6tk+PxucGtbRgMUWJosaL/z0JOWHOjtlBQeBYghUuvt4X KjZ2+5ud9i2mf/rsLCfllr9mRFLougQgpMRNgyxr4Q+Cn4+0Rew5o3fWCgwxhHJ+cAob BoLw== X-Forwarded-Encrypted: i=1; AFNElJ+N6Al/Y0o1AweSG+Azy2Jy4HFYqmFMN/UurUBIG4G5mfYg0LFScL/wnfTw/KfFZt/fLrxFLm5uyK3D6TE=@vger.kernel.org X-Gm-Message-State: AOJu0Yyq5QXz4Dvweam9cYcXzjpqm2zEiEks9ZpC89a6KIjwzSkPEhZD BeY1kExX2kJByim3Q65uOd5W4/RyXJzbyFZc44q3Xq2ScO7ZFaHydCIY X-Gm-Gg: Acq92OEMg1sUrsJoCA27ThaYWaJ2vZNAb2hh40zvtbdNedzXL+3q1kCZWgT2eYKGQBX /DZtpHk7GQoSG6bTEl55LUothNIoqCDHxjjzVQr0qSVFXOYXlbQyjz0/lH+6+LRb6aE2stB+UZu dlK05mNFjngvilbNboRq/gHX9sLVpfIEVAA1HZ0DQeNMZkLR7fSFJlA/Y18SMz4PLlFA64VkLJE 0j8WxYhRNyBeHN9Bxg/EfkYshAVx2/zA8W4I/z5YEhc/GVSrZU7ihXhSNsKr+0acD5reJrvLbbP vcRBnRfuOxUDFdFIpb4vpcnWKbq23/a5Gfyi+ClJnMcjWg4K8oqhi1P3KQH7OvMEB6WBwzcJUen RqTOBjIK810Y7r0wewCoXeDzAWYFVcMqi3Gd8sHA2gXkHSQXn9xkFCoRZzXEd40PgEaSzfMaHYt za3XaC2qYQEvz5ZAb++SBDz1oPn54= X-Received: by 2002:a5d:5d0e:0:b0:449:fb9e:4b4e with SMTP id ffacd0b85a97d-45e5c36755dmr965484f8f.15.1778793429319; Thu, 14 May 2026 14:17:09 -0700 (PDT) Received: from localhost ([94.19.228.143]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45d9e768072sm9290771f8f.5.2026.05.14.14.17.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 May 2026 14:17:08 -0700 (PDT) Date: Fri, 15 May 2026 00:17:07 +0300 From: Andrey Skvortsov To: Chen-Yu Tsai Cc: Jernej Skrabec , Samuel Holland , linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] bus: sunxi-rsb: Always check register address validity Message-ID: Mail-Followup-To: Andrey Skvortsov , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org References: <20260301144939.1832806-1-andrej.skvortzov@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On 26-03-14 15:33, Chen-Yu Tsai wrote: > On Sun, Mar 1, 2026 at 10:50 PM Andrey Skvortsov > wrote: > > > > From: Samuel Holland > > > > The register address was already validated for read operations in > > regmap_sunxi_rsb_reg_read before being truncated to a u8. Write operations > > have the same set of possible addresses, and the address is being truncated > > from u32 to u8 here as well, so the same check is needed. > > > > Signed-off-by: Samuel Holland > > Signed-off-by: Andrey Skvortsov > > Should probably have: > > Fixes: d787dcdb9c8f ("bus: sunxi-rsb: Add driver for Allwinner Reduced > Serial Bus") > > I will added (via b4) when applying. > > Reviewed-by: Chen-Yu Tsai Hi, do I need to update and resend this patch? -- Best regards, Andrey Skvortsov