From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 62CB5CD4F39 for ; Thu, 14 May 2026 17:40:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0r9mfF3dWh5oaiGIxhX9Vx6RfIT8tlJtbM5F2gMw/2s=; b=Lh/i9AlUicoNoH +I3mUEk5zp0SaVEkt2CtoYAqx2O974xmsU4dR1vYyqQ19QufC0cvrTRbnLaWL0FsfzU64EbVKDwxs Y2AR17D3IhaAKK3ZiLKAD18+l4R3Ca5uoPs0S+OLETv0bJPN7CJ/jMTdnM8ykgAk/f1V8NSYnRTA0 sQ72rHgaZ3oH6fCo5km272Px+jM3DtmINUoxBbuw0g2Z6TeJndSS4/+oqDGPm7gbTa1qIU37pt1pm Gasvqu24qYeGqfB/CK9Vbc41D3f/4DlI8po1mrRu0/NCXuwU/w+nfOweRlSskcZi+Woc2owOz6HGI H0/KhSNSQxNGcr5QhoqQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wNa3K-00000006EBl-0a5o; Thu, 14 May 2026 17:40:54 +0000 Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wNa3G-00000006EAS-3EnR for kvm-riscv@lists.infradead.org; Thu, 14 May 2026 17:40:52 +0000 Received: by mail-wr1-x42e.google.com with SMTP id ffacd0b85a97d-45d96d21e82so731211f8f.0 for ; Thu, 14 May 2026 10:40:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778780449; x=1779385249; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=KnaJVAZDC++uQU8uHfAQulgEWlG+rcJqqh5PyI/aA3o=; b=fRgOre7jFRoy30N/21bQ7kNQB9UWKi9kqXONXoXDCCUuARVBrJ7ZaVCK9y++xqpMpL /ZCJzRpoLtviw86UtQYNrHdAj9lrphwjYy5+AbeiDBAmp7gja3OCY+Uw3m1VhXwL0pmz CxFMH2WzmaHioLGdQXEvaN2z20WxC2YkCxT4yYUTrVcZU9JnkfzcKJp5h5u2K9WlMxVZ SBSoKCx13+uya3t+qXd61cHXlaZvvAKs01CINflFCPyUN7MOadPzwNE2WjEGH7O15aKs y4bfiNWf1tUhknnxd1onDpz77QHTBifsVg6ItDy6XlL566Ank5JLK5Nmy870ZN5CVIom IasA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778780449; x=1779385249; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KnaJVAZDC++uQU8uHfAQulgEWlG+rcJqqh5PyI/aA3o=; b=Bry1QcqH9RN8DTmZMh5/0G7vEotiblYl89NXHEw2H3AUN9nH8YnXSOj8gSaafBLa8M Jang4ehbnAsC4lWBQK1JVbCSxpZiDYJAzIXhNGie/Ln1EaYLn72rNMNTD8iSJGwuKEPC sJ6nEjN13MdDMNG9hDHmDYyi1tniRnHKrY0Tfh2GSzAFIZLQQmq4i2F3DH43Ra6PWdKT moLX8+JWj0/i3FlTPgBYIWScX173+WAy1Q6P2hKeDOsOHKeGRUTQBbIJnObRhwQv1Dbo RjYkcWZLQi47ZdaYiR/lq1At5yntnpxr3AvFt7hEPrFk3SeLyxppYygwrnpvg+miN+gt a0og== X-Forwarded-Encrypted: i=1; AFNElJ/980i0D/8YTHOD9ei4CvgF0AX4kdrikzW7tlwXmsZBua9VX5+6GJQSExLYTixl2HR0LrcBWdoj/Zw=@lists.infradead.org X-Gm-Message-State: AOJu0YwJv2R6yc3Z6m5ui9Ur0dV/dA82rmkDPCz1P76wG264cWj4Vj7Y uH5/uizuA1oaBqm+yc8fHO0e5KU1axuqD6xnZLe156mdlsxIDwXAIdPB X-Gm-Gg: Acq92OFdd8lVtrwG30a7gIa7Oy+drbspfhTTAbExL9Yo6ymmv8I0Ylh05R2S5KYtllN cPaX4wb8EOvUnKPTmn3ZBEndjBA0Zntckt65iFwPGXTeR/+eyZj1skCG1qA4BRgRksmUC0Xl2nS JCUVO/k7Gz5ieV9D82ApYpgDGw9/vDdEyZeROfz4Tt/OJ3XboyTjdTT6jcwNRVBpsFPBin0F+dI Xl3RG+2OSPru3xNHqgGfvWfn3YcCtXjfcXsSMSsNNyKyKg0uRREsunAbS1LZf5w6SrU5tIfks7a 1tdrh3iSOvIEgD+NC58dBRP3gWycq5lGyOMM7nTmGCAOG1O57eeloDrucAUC55OmqAH0KXGPkbR bYayZWfIBpSwbgz3oVZGFyFU5fU2fU3CfpNNbDEBekJ3j458vKaSPqiW4Hs9ssCB2xog4ZOdomc 7Jl9yCAwqWHzd9+bTEQqyEe4djriG4ogKPMmpwGSOBpQhjaXobUwDeSbfDKg== X-Received: by 2002:a05:6000:2c06:b0:45d:4fc0:fe0a with SMTP id ffacd0b85a97d-45e5c5dd346mr66055f8f.32.1778780448681; Thu, 14 May 2026 10:40:48 -0700 (PDT) Received: from osama ([2a02:908:1b6:8980:4f8c:d716:5699:930b]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45d9ed2ffdfsm7481200f8f.15.2026.05.14.10.40.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 May 2026 10:40:48 -0700 (PDT) Date: Thu, 14 May 2026 19:40:46 +0200 From: Osama Abdelkader To: Anup Patel Cc: Atish Patra , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH] riscv: kvm: return SBI_ERR_FAILURE for PMU shmem OOM Message-ID: References: <20260415220930.287592-1-osama.abdelkader@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260514_104050_820430_92C190D3 X-CRM114-Status: GOOD ( 21.51 ) X-BeenThere: kvm-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "kvm-riscv" Errors-To: kvm-riscv-bounces+kvm-riscv=archiver.kernel.org@lists.infradead.org T24gVGh1LCBNYXkgMTQsIDIwMjYgYXQgMDc6MTM6MDRQTSArMDUzMCwgQW51cCBQYXRlbCB3cm90 ZToKPiBPbiBUaHUsIEFwciAxNiwgMjAyNiBhdCAzOjQw4oCvQU0gT3NhbWEgQWJkZWxrYWRlcgo+ IDxvc2FtYS5hYmRlbGthZGVyQGdtYWlsLmNvbT4gd3JvdGU6Cj4gPgo+ID4ga3ZtX3Jpc2N2X3Zj cHVfcG11X3NuYXBzaG90X3NldF9zaG1lbSgpIGFuZCBrdm1fcmlzY3ZfdmNwdV9wbXVfZXZlbnRf aW5mbygpCj4gPiByZXR1cm5lZCAtRU5PTUVNIGZyb20gdGhlIFNCSSBleHRlbnNpb24gaGFuZGxl ciwgd2hpY2ggY2F1c2VkCj4gPiBrdm1fcmlzY3ZfdmNwdV9zYmlfZWNhbGwoKSB0byBhYm9ydCBL Vk1fUlVOIGFuZCBzdXJmYWNlIHRoZSBlcnJvciB0bwo+ID4gdXNlcnNwYWNlIGluc3RlYWQgb2Yg Y29tcGxldGluZyB0aGUgRUNBTEwgd2l0aCBhIG5lZ2F0aXZlIFNCSSBlcnJvciBpbiBhMC4KPiA+ IFVzZSBTQklfRVJSX0ZBSUxVUkUgYW5kIHRoZSBub3JtYWwgcmV0ZGF0YSBwYXRoLCBtYXRjaGlu ZyBvdGhlciBQTVUKPiA+IGhhbmRsZXJzIGFuZCBrdm1fc2JpX2V4dF9wbXVfaGFuZGxlciBjb21t ZW50Lgo+ID4KPiA+IFNpZ25lZC1vZmYtYnk6IE9zYW1hIEFiZGVsa2FkZXIgPG9zYW1hLmFiZGVs a2FkZXJAZ21haWwuY29tPgo+IAo+IFNwbGl0IHRoaXMgaW50byB0d28gcGF0Y2hlcyB3aGVyZToK PiAKPiAxKSBPbmUgcGF0Y2ggZml4aW5nIGt2bV9yaXNjdl92Y3B1X3BtdV9zbmFwc2hvdF9zZXRf c2htZW0oKQo+IDIpIFNlY29uZCBwYXRjaCBmaXhpbmcga3ZtX3Jpc2N2X3ZjcHVfcG11X2V2ZW50 X2luZm8oKQo+IAo+IE1ha2Ugc3VyZSB0byBhZGQgRml4ZXMgdGFnIGluIGJvdGggcGF0Y2hlcy4K PiAKPiBSZWdhcmRzLAo+IEFudXAKClRoYW5rcyBBbnVwIGZvciB0aGUgcmV2aWV3LCBJIGp1c3Qg ZGlkIHRoYXQuCgpSZWdhcmRzLApPc2FtYQoKPiAKPiA+IC0tLQo+ID4gIGFyY2gvcmlzY3Yva3Zt L3ZjcHVfcG11LmMgfCAxMiArKysrKysrKy0tLS0KPiA+ICAxIGZpbGUgY2hhbmdlZCwgOCBpbnNl cnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQo+ID4KPiA+IGRpZmYgLS1naXQgYS9hcmNoL3Jpc2N2 L2t2bS92Y3B1X3BtdS5jIGIvYXJjaC9yaXNjdi9rdm0vdmNwdV9wbXUuYwo+ID4gaW5kZXggZTg3 MzQzMGU1OTZiLi5mMzZiMDk5ZjQ0N2MgMTAwNjQ0Cj4gPiAtLS0gYS9hcmNoL3Jpc2N2L2t2bS92 Y3B1X3BtdS5jCj4gPiArKysgYi9hcmNoL3Jpc2N2L2t2bS92Y3B1X3BtdS5jCj4gPiBAQCAtNDM1 LDggKzQzNSwxMCBAQCBpbnQga3ZtX3Jpc2N2X3ZjcHVfcG11X3NuYXBzaG90X3NldF9zaG1lbShz dHJ1Y3Qga3ZtX3ZjcHUgKnZjcHUsIHVuc2lnbmVkIGxvbmcgcwo+ID4gICAgICAgICB9Cj4gPgo+ ID4gICAgICAgICBrdnBtdS0+c2RhdGEgPSBremFsbG9jKHNuYXBzaG90X2FyZWFfc2l6ZSwgR0ZQ X0FUT01JQyk7Cj4gPiAtICAgICAgIGlmICgha3ZwbXUtPnNkYXRhKQo+ID4gLSAgICAgICAgICAg ICAgIHJldHVybiAtRU5PTUVNOwo+ID4gKyAgICAgICBpZiAoIWt2cG11LT5zZGF0YSkgewo+ID4g KyAgICAgICAgICAgICAgIHNiaXJldCA9IFNCSV9FUlJfRkFJTFVSRTsKPiA+ICsgICAgICAgICAg ICAgICBnb3RvIG91dDsKPiA+ICsgICAgICAgfQo+ID4KPiA+ICAgICAgICAgLyogTm8gbmVlZCB0 byBjaGVjayB3cml0YWJsZSBzbG90IGV4cGxpY2l0bHkgYXMga3ZtX3ZjcHVfd3JpdGVfZ3Vlc3Qg ZG9lcyBpdCBpbnRlcm5hbGx5ICovCj4gPiAgICAgICAgIGlmIChrdm1fdmNwdV93cml0ZV9ndWVz dCh2Y3B1LCBzYWRkciwga3ZwbXUtPnNkYXRhLCBzbmFwc2hvdF9hcmVhX3NpemUpKSB7Cj4gPiBA QCAtNDgwLDggKzQ4MiwxMCBAQCBpbnQga3ZtX3Jpc2N2X3ZjcHVfcG11X2V2ZW50X2luZm8oc3Ry dWN0IGt2bV92Y3B1ICp2Y3B1LCB1bnNpZ25lZCBsb25nIHNhZGRyX2xvdwo+ID4gICAgICAgICB9 Cj4gPgo+ID4gICAgICAgICBlaW5mbyA9IGt6YWxsb2Moc2htZW1fc2l6ZSwgR0ZQX0tFUk5FTCk7 Cj4gPiAtICAgICAgIGlmICghZWluZm8pCj4gPiAtICAgICAgICAgICAgICAgcmV0dXJuIC1FTk9N RU07Cj4gPiArICAgICAgIGlmICghZWluZm8pIHsKPiA+ICsgICAgICAgICAgICAgICByZXQgPSBT QklfRVJSX0ZBSUxVUkU7Cj4gPiArICAgICAgICAgICAgICAgZ290byBvdXQ7Cj4gPiArICAgICAg IH0KPiA+Cj4gPiAgICAgICAgIHJldCA9IGt2bV92Y3B1X3JlYWRfZ3Vlc3QodmNwdSwgc2htZW0s IGVpbmZvLCBzaG1lbV9zaXplKTsKPiA+ICAgICAgICAgaWYgKHJldCkgewo+ID4gLS0KPiA+IDIu NDMuMAo+ID4KCi0tIAprdm0tcmlzY3YgbWFpbGluZyBsaXN0Cmt2bS1yaXNjdkBsaXN0cy5pbmZy YWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8va3Zt LXJpc2N2Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C4E14CD4F39 for ; Thu, 14 May 2026 17:41:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZeBkadwz3QfnVU10snUY2LXZhDCUg97iKcaJobYkibc=; b=q2ImaKtc+36KWv 9eXn7PsewWI/frnmRJgZKEurNYJBu/xc9L5y8GO7pa7+0hp8tIMP+pvTvzAvib28r077SN6SWB+8M 5D9shRYHhbvj084n5KphXNgRp4+lkqhGXq5MIgMOmUmITEk6LgEfcJkly3nuWQCfUfs1X1dKXOcZW x01v9SBSUVx2h+EI4whblW9bl57WyGEmx5BEU7u1N4SP9L9FbCGo54YazXAfzqzgIMbK0FZTDZPXE TDe+PdMBbWhpiJkKQJyaHWgptqrBKSDScvVN6iKCwflj6ydrUoxyMLDpfCNGbTKiqpHccTT0h1MSD pSSCyiM94TR3l5vlE24A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wNa3J-00000006EBM-0Ehh; Thu, 14 May 2026 17:40:53 +0000 Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wNa3G-00000006EAR-2uOw for linux-riscv@lists.infradead.org; Thu, 14 May 2026 17:40:51 +0000 Received: by mail-wr1-x432.google.com with SMTP id ffacd0b85a97d-44a5174670eso4668462f8f.1 for ; Thu, 14 May 2026 10:40:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778780449; x=1779385249; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=KnaJVAZDC++uQU8uHfAQulgEWlG+rcJqqh5PyI/aA3o=; b=fRgOre7jFRoy30N/21bQ7kNQB9UWKi9kqXONXoXDCCUuARVBrJ7ZaVCK9y++xqpMpL /ZCJzRpoLtviw86UtQYNrHdAj9lrphwjYy5+AbeiDBAmp7gja3OCY+Uw3m1VhXwL0pmz CxFMH2WzmaHioLGdQXEvaN2z20WxC2YkCxT4yYUTrVcZU9JnkfzcKJp5h5u2K9WlMxVZ SBSoKCx13+uya3t+qXd61cHXlaZvvAKs01CINflFCPyUN7MOadPzwNE2WjEGH7O15aKs y4bfiNWf1tUhknnxd1onDpz77QHTBifsVg6ItDy6XlL566Ank5JLK5Nmy870ZN5CVIom IasA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778780449; x=1779385249; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KnaJVAZDC++uQU8uHfAQulgEWlG+rcJqqh5PyI/aA3o=; b=S86T2ubSWIn7vo5sXBW+G0i+BnW1Q8nYmT3zjA5IgUSHDg9lYL4QtKG92HLBsaxOnO kEs/2GgTWLa6qWXK6pP2kch+lZSnARE+qS5PFR07No+rq57iqpgybw7O7sqIwdQbcgg2 jT5e/0AzK/9+EEtw5bW4zezMxkK5DD0lrLaGScW1ghnfwg5inawPO6ftFAgdMozpvpOT +bMjhmJqZiLOd0xs/dQXS9+DMEdxeWvjHLk0bLVjHmaDaFER9D5AReXWkdpaQiPklR1q YqQ6VG0KeEEpegfzNof1UVU1ZL2oXsFFcqyg+Oak5RUC+5IeKKfIwhwxQxu25zH7zF7y MFGA== X-Forwarded-Encrypted: i=1; AFNElJ9a/EqxtbKE72KBkphOYFe0bDk3kleWpDeTIWPRxo4urMXXukkfDP8CZUG9u6Wgh+zcNHQBWwEBdlDRWQ==@lists.infradead.org X-Gm-Message-State: AOJu0Yw7Nnb0QobRnQM+5O3YWXrFB0DNjyiIwrhRZAF65TmX8hKGXLae WCq2xbvm/FuRQxfLBjAQSEIoS8wEb3FOKuMuvC7mqEx6MY/6uWgHypVp X-Gm-Gg: Acq92OF+LalL9lfPR3sBt3KXMe75ilgm5K4LUzbZ8ZEgdyPHoi739I9DHaQusdVA1Qm 9wZdT5AxI685VAKQg/U6W2d2rLNFimaQWzntWwpT8wS/W3XiaezSuOpyN6tKvOYThHXS3s6Fu0e XlCaOWooLQNlDpv7eHKUIw8r12NaebmLWWdNBk2RV9CkZUPbmZ66hnzXFTjWCcDhvCz7OnxUG6w Npk6eFCzMiOVVT2BDMgjyy4xtRdNE1CBKjlMMYufML7Jla06W44BwW0JquS3EtWDilfdB0paWZn fYIlfE1NDB/FLSWhdNx/e2n+PCgbgomJDwApgviydp2DlVE7C9pbjj+Dmvq/qa5ImffUhcvEfm8 Sw9fzdHQh/8TU3FhjtxojIfQG4Ag6zUt2DQpJ/a866PMDvFcAxinu99Ia46XiS3uNa+7BqmXsOt 8RSCEwU+7zij8IIRJkreqq9OGpVBTZEl9ncVvB+m87DDtVgcD/xKf7tBcyKw== X-Received: by 2002:a05:6000:2c06:b0:45d:4fc0:fe0a with SMTP id ffacd0b85a97d-45e5c5dd346mr66055f8f.32.1778780448681; Thu, 14 May 2026 10:40:48 -0700 (PDT) Received: from osama ([2a02:908:1b6:8980:4f8c:d716:5699:930b]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45d9ed2ffdfsm7481200f8f.15.2026.05.14.10.40.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 May 2026 10:40:48 -0700 (PDT) Date: Thu, 14 May 2026 19:40:46 +0200 From: Osama Abdelkader To: Anup Patel Cc: Atish Patra , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH] riscv: kvm: return SBI_ERR_FAILURE for PMU shmem OOM Message-ID: References: <20260415220930.287592-1-osama.abdelkader@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260514_104050_750459_7117F42E X-CRM114-Status: GOOD ( 21.51 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gVGh1LCBNYXkgMTQsIDIwMjYgYXQgMDc6MTM6MDRQTSArMDUzMCwgQW51cCBQYXRlbCB3cm90 ZToKPiBPbiBUaHUsIEFwciAxNiwgMjAyNiBhdCAzOjQw4oCvQU0gT3NhbWEgQWJkZWxrYWRlcgo+ IDxvc2FtYS5hYmRlbGthZGVyQGdtYWlsLmNvbT4gd3JvdGU6Cj4gPgo+ID4ga3ZtX3Jpc2N2X3Zj cHVfcG11X3NuYXBzaG90X3NldF9zaG1lbSgpIGFuZCBrdm1fcmlzY3ZfdmNwdV9wbXVfZXZlbnRf aW5mbygpCj4gPiByZXR1cm5lZCAtRU5PTUVNIGZyb20gdGhlIFNCSSBleHRlbnNpb24gaGFuZGxl ciwgd2hpY2ggY2F1c2VkCj4gPiBrdm1fcmlzY3ZfdmNwdV9zYmlfZWNhbGwoKSB0byBhYm9ydCBL Vk1fUlVOIGFuZCBzdXJmYWNlIHRoZSBlcnJvciB0bwo+ID4gdXNlcnNwYWNlIGluc3RlYWQgb2Yg Y29tcGxldGluZyB0aGUgRUNBTEwgd2l0aCBhIG5lZ2F0aXZlIFNCSSBlcnJvciBpbiBhMC4KPiA+ IFVzZSBTQklfRVJSX0ZBSUxVUkUgYW5kIHRoZSBub3JtYWwgcmV0ZGF0YSBwYXRoLCBtYXRjaGlu ZyBvdGhlciBQTVUKPiA+IGhhbmRsZXJzIGFuZCBrdm1fc2JpX2V4dF9wbXVfaGFuZGxlciBjb21t ZW50Lgo+ID4KPiA+IFNpZ25lZC1vZmYtYnk6IE9zYW1hIEFiZGVsa2FkZXIgPG9zYW1hLmFiZGVs a2FkZXJAZ21haWwuY29tPgo+IAo+IFNwbGl0IHRoaXMgaW50byB0d28gcGF0Y2hlcyB3aGVyZToK PiAKPiAxKSBPbmUgcGF0Y2ggZml4aW5nIGt2bV9yaXNjdl92Y3B1X3BtdV9zbmFwc2hvdF9zZXRf c2htZW0oKQo+IDIpIFNlY29uZCBwYXRjaCBmaXhpbmcga3ZtX3Jpc2N2X3ZjcHVfcG11X2V2ZW50 X2luZm8oKQo+IAo+IE1ha2Ugc3VyZSB0byBhZGQgRml4ZXMgdGFnIGluIGJvdGggcGF0Y2hlcy4K PiAKPiBSZWdhcmRzLAo+IEFudXAKClRoYW5rcyBBbnVwIGZvciB0aGUgcmV2aWV3LCBJIGp1c3Qg ZGlkIHRoYXQuCgpSZWdhcmRzLApPc2FtYQoKPiAKPiA+IC0tLQo+ID4gIGFyY2gvcmlzY3Yva3Zt L3ZjcHVfcG11LmMgfCAxMiArKysrKysrKy0tLS0KPiA+ICAxIGZpbGUgY2hhbmdlZCwgOCBpbnNl cnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQo+ID4KPiA+IGRpZmYgLS1naXQgYS9hcmNoL3Jpc2N2 L2t2bS92Y3B1X3BtdS5jIGIvYXJjaC9yaXNjdi9rdm0vdmNwdV9wbXUuYwo+ID4gaW5kZXggZTg3 MzQzMGU1OTZiLi5mMzZiMDk5ZjQ0N2MgMTAwNjQ0Cj4gPiAtLS0gYS9hcmNoL3Jpc2N2L2t2bS92 Y3B1X3BtdS5jCj4gPiArKysgYi9hcmNoL3Jpc2N2L2t2bS92Y3B1X3BtdS5jCj4gPiBAQCAtNDM1 LDggKzQzNSwxMCBAQCBpbnQga3ZtX3Jpc2N2X3ZjcHVfcG11X3NuYXBzaG90X3NldF9zaG1lbShz dHJ1Y3Qga3ZtX3ZjcHUgKnZjcHUsIHVuc2lnbmVkIGxvbmcgcwo+ID4gICAgICAgICB9Cj4gPgo+ ID4gICAgICAgICBrdnBtdS0+c2RhdGEgPSBremFsbG9jKHNuYXBzaG90X2FyZWFfc2l6ZSwgR0ZQ X0FUT01JQyk7Cj4gPiAtICAgICAgIGlmICgha3ZwbXUtPnNkYXRhKQo+ID4gLSAgICAgICAgICAg ICAgIHJldHVybiAtRU5PTUVNOwo+ID4gKyAgICAgICBpZiAoIWt2cG11LT5zZGF0YSkgewo+ID4g KyAgICAgICAgICAgICAgIHNiaXJldCA9IFNCSV9FUlJfRkFJTFVSRTsKPiA+ICsgICAgICAgICAg ICAgICBnb3RvIG91dDsKPiA+ICsgICAgICAgfQo+ID4KPiA+ICAgICAgICAgLyogTm8gbmVlZCB0 byBjaGVjayB3cml0YWJsZSBzbG90IGV4cGxpY2l0bHkgYXMga3ZtX3ZjcHVfd3JpdGVfZ3Vlc3Qg ZG9lcyBpdCBpbnRlcm5hbGx5ICovCj4gPiAgICAgICAgIGlmIChrdm1fdmNwdV93cml0ZV9ndWVz dCh2Y3B1LCBzYWRkciwga3ZwbXUtPnNkYXRhLCBzbmFwc2hvdF9hcmVhX3NpemUpKSB7Cj4gPiBA QCAtNDgwLDggKzQ4MiwxMCBAQCBpbnQga3ZtX3Jpc2N2X3ZjcHVfcG11X2V2ZW50X2luZm8oc3Ry dWN0IGt2bV92Y3B1ICp2Y3B1LCB1bnNpZ25lZCBsb25nIHNhZGRyX2xvdwo+ID4gICAgICAgICB9 Cj4gPgo+ID4gICAgICAgICBlaW5mbyA9IGt6YWxsb2Moc2htZW1fc2l6ZSwgR0ZQX0tFUk5FTCk7 Cj4gPiAtICAgICAgIGlmICghZWluZm8pCj4gPiAtICAgICAgICAgICAgICAgcmV0dXJuIC1FTk9N RU07Cj4gPiArICAgICAgIGlmICghZWluZm8pIHsKPiA+ICsgICAgICAgICAgICAgICByZXQgPSBT QklfRVJSX0ZBSUxVUkU7Cj4gPiArICAgICAgICAgICAgICAgZ290byBvdXQ7Cj4gPiArICAgICAg IH0KPiA+Cj4gPiAgICAgICAgIHJldCA9IGt2bV92Y3B1X3JlYWRfZ3Vlc3QodmNwdSwgc2htZW0s IGVpbmZvLCBzaG1lbV9zaXplKTsKPiA+ICAgICAgICAgaWYgKHJldCkgewo+ID4gLS0KPiA+IDIu NDMuMAo+ID4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CmxpbnV4LXJpc2N2IG1haWxpbmcgbGlzdApsaW51eC1yaXNjdkBsaXN0cy5pbmZyYWRlYWQub3Jn Cmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcmlzY3YK From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 41AB22E542C for ; Thu, 14 May 2026 17:40:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778780451; cv=none; b=RLjT2Di4KIculoeNaM/XnQMybpTuxy0Ks0omJBUGVUSCSeT8WVJe51jzOF28EJPlEbiCPpQ0faadhHPoaQzn6IojDbpXcq0h8BWOWw4JCg6dYuLC7jC+nhv/hZS4TqLo1KCt9qtYpigepu4o9YC6qKnqo2mdW3yJzy7OfvbmjuU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778780451; c=relaxed/simple; bh=LaCpCdJ6vB3PHJFZwa69h40OFOstSpns4OZEo7++8GQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=aEI0IXKxDFVr9mieqQvj491+WHR+mZUc4y416dW9irdrN0COX+ZruD7ehtF9B9Xs4PG52WkRS29Fm1UjNPAQdqik/veu4wPQN8i6oULYZdYgqE5Mreort53EByxaB4Bf/FWyNzMcBxLrNwN8iPacbNYGs9uC5sux2JQDhNb6Fkk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=etQeCTrl; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="etQeCTrl" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-44a5174670eso4668463f8f.1 for ; Thu, 14 May 2026 10:40:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778780449; x=1779385249; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=KnaJVAZDC++uQU8uHfAQulgEWlG+rcJqqh5PyI/aA3o=; b=etQeCTrlcVnw0exp4DUyMumFFqLO3+e3gpHBRQe0HEXxIksslPirFIBGpYgHjDAKm5 BP6tC1MrxblXE3R2RCKwstkt3NXl9zEmBUmnHKBEjGSN3E/RuBsvS5pay0zvN42uvYNM fZQV3iljx/YO22HzxSMucWe1IEZ1ZYCHLJWqXfdiLLu2AI15TppjIdip2uPGHgNYXSDh I3c7ryrDn2q93arAo+1F6GuqnbZMX2uRZaNX5DklVTl1SuK8V5sHD3gCSjhXzNZmP+Kf GwezXu7iFvgqNqs2eoXftdDyufUgzR4Z78TsNIlH6UX5Mx9x83PkyahiwPWp4E99bkA/ RNEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778780449; x=1779385249; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KnaJVAZDC++uQU8uHfAQulgEWlG+rcJqqh5PyI/aA3o=; b=sbZMS9I+1eJoSz10OFQ03udSaQRqtH2lNgViSIYbSRgttAm5sFdbmD3QH5SEiVBtbx d1bFAhi7ebCtAB0bombzddY8EXlGAbO1rH5fCBc9Jtxn5aSFY5jOzdMevTZTmMNIyq8z g+AAWw8pW2kT8P3Tm69jydQ3FPWSNzGHW6ALzZ2j6Wrd6hXZdVy3uUWb/57QCS3uwtbH 9X1v9g5FAfFXZlArNDai0Ubkbv6xHY1HvjtAbxfc5IijOheqFjpdCNHZU8dqzSJgeLwK vLI0N6lmsoXKH+e2yHLOIX2kpidQ/dXpcy8nIzlgS600vmy3ziIRs8mK1c2CjD+ECMyQ MMcQ== X-Forwarded-Encrypted: i=1; AFNElJ+k16wkLjwqveUEq8RDcgwBwArnFo503wWAfzpAgCx1QH38mEysuQg64NhkWcAO2JoKrJw=@vger.kernel.org X-Gm-Message-State: AOJu0YxqyPtt3s/p0Lihocq6cACNAMZ4usL5Yckdmn17MMos9FZV0tHH H7JHqS/jiZyedquQsSWNykrW3FFPEZ96E8j85vtNIiB1lAy9z8C9Q0Z3 X-Gm-Gg: Acq92OGTF3aLlLwf642PBc2vnn5je4ApqNRZkat1x3h/BfnmCbwGohtYySoqctKX6SQ mPO63M72mZfrqMF/buYxd879mV69+Et1DgQt5GVO6qd3rcLVO1eXVX5gazhyQ8eTMb8XUEDWB1N v0Donwnbtdiom6vkemFun3T7OCaDO0WUB/DYuLJyUV208mE/xyYUffzM+mtAXZRbaRvdB25WvKm BEbGyDqjjRxG4Gb4gIdxdlF3IKCNjZgDp6W5+gqIMfkGFws7waK7tIn6KH5anHvHIFOf8jCad6Z HijYwQlHBlEIebYNUhUhSXgoCSwPrVnS5jn9UcJRMVpkVxrYrCbbGI8dwPWBFGFKgR8MJQ9vSSm 3QIeg9JkgiOobaoeUcReFrspJX9h3cBkXlNmpscykiFWkdpiFaJzV0CL/1S1JX/OurBlqaZievy wWGIhDncjltr3UwkT1BDhmy9fFDYaTiFZ8R9Xj9umjAYlQOghgj9Gj3jRszA== X-Received: by 2002:a05:6000:2c06:b0:45d:4fc0:fe0a with SMTP id ffacd0b85a97d-45e5c5dd346mr66055f8f.32.1778780448681; Thu, 14 May 2026 10:40:48 -0700 (PDT) Received: from osama ([2a02:908:1b6:8980:4f8c:d716:5699:930b]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45d9ed2ffdfsm7481200f8f.15.2026.05.14.10.40.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 May 2026 10:40:48 -0700 (PDT) Date: Thu, 14 May 2026 19:40:46 +0200 From: Osama Abdelkader To: Anup Patel Cc: Atish Patra , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH] riscv: kvm: return SBI_ERR_FAILURE for PMU shmem OOM Message-ID: References: <20260415220930.287592-1-osama.abdelkader@gmail.com> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Thu, May 14, 2026 at 07:13:04PM +0530, Anup Patel wrote: > On Thu, Apr 16, 2026 at 3:40 AM Osama Abdelkader > wrote: > > > > kvm_riscv_vcpu_pmu_snapshot_set_shmem() and kvm_riscv_vcpu_pmu_event_info() > > returned -ENOMEM from the SBI extension handler, which caused > > kvm_riscv_vcpu_sbi_ecall() to abort KVM_RUN and surface the error to > > userspace instead of completing the ECALL with a negative SBI error in a0. > > Use SBI_ERR_FAILURE and the normal retdata path, matching other PMU > > handlers and kvm_sbi_ext_pmu_handler comment. > > > > Signed-off-by: Osama Abdelkader > > Split this into two patches where: > > 1) One patch fixing kvm_riscv_vcpu_pmu_snapshot_set_shmem() > 2) Second patch fixing kvm_riscv_vcpu_pmu_event_info() > > Make sure to add Fixes tag in both patches. > > Regards, > Anup Thanks Anup for the review, I just did that. Regards, Osama > > > --- > > arch/riscv/kvm/vcpu_pmu.c | 12 ++++++++---- > > 1 file changed, 8 insertions(+), 4 deletions(-) > > > > diff --git a/arch/riscv/kvm/vcpu_pmu.c b/arch/riscv/kvm/vcpu_pmu.c > > index e873430e596b..f36b099f447c 100644 > > --- a/arch/riscv/kvm/vcpu_pmu.c > > +++ b/arch/riscv/kvm/vcpu_pmu.c > > @@ -435,8 +435,10 @@ int kvm_riscv_vcpu_pmu_snapshot_set_shmem(struct kvm_vcpu *vcpu, unsigned long s > > } > > > > kvpmu->sdata = kzalloc(snapshot_area_size, GFP_ATOMIC); > > - if (!kvpmu->sdata) > > - return -ENOMEM; > > + if (!kvpmu->sdata) { > > + sbiret = SBI_ERR_FAILURE; > > + goto out; > > + } > > > > /* No need to check writable slot explicitly as kvm_vcpu_write_guest does it internally */ > > if (kvm_vcpu_write_guest(vcpu, saddr, kvpmu->sdata, snapshot_area_size)) { > > @@ -480,8 +482,10 @@ int kvm_riscv_vcpu_pmu_event_info(struct kvm_vcpu *vcpu, unsigned long saddr_low > > } > > > > einfo = kzalloc(shmem_size, GFP_KERNEL); > > - if (!einfo) > > - return -ENOMEM; > > + if (!einfo) { > > + ret = SBI_ERR_FAILURE; > > + goto out; > > + } > > > > ret = kvm_vcpu_read_guest(vcpu, shmem, einfo, shmem_size); > > if (ret) { > > -- > > 2.43.0 > >