From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.netfilter.org (mail.netfilter.org [217.70.190.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 41FE825776 for ; Fri, 15 May 2026 00:10:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.190.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778803856; cv=none; b=WZ4kJPtXEGWZErIZ2FTVgxtNYODOiNpzAOG4k+wFUiu3QJMBeaTabnOrL8Mc/LA759RW9Vp/8cW3ogbSXQLODg1ugc8nF0licbDasfbCZeTxStFLMbIDBaf8sR4svWXACLZ+cUbEz6xPLeyMIyS/hqPP3m/YIf2wpwqz0ho3yy4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778803856; c=relaxed/simple; bh=fbmBEsJbZ2OmQsp1EOcGogW5CTbk/79MSYvgWUmVjpg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=I4c8+VwO0YeQnuY+QSwSsgU5VM5Yo6GnCkrCceLxo6EWTckF0Lc6SCmO0lj1mS8K1pitNygzTqwvv9ifzDkLxdXOgc5B4YwWrN0qtM6uCQEFSrTwFJgSo5tFKo4XY+x8aqB+ohWbx3/Bk+FsKTr+uOoOBSfUMcY3uE9IHaZHbcE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=netfilter.org; spf=pass smtp.mailfrom=netfilter.org; dkim=pass (2048-bit key) header.d=netfilter.org header.i=@netfilter.org header.b=c1x0L2VH; arc=none smtp.client-ip=217.70.190.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=netfilter.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=netfilter.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=netfilter.org header.i=@netfilter.org header.b="c1x0L2VH" Received: from netfilter.org (mail-agni [217.70.190.124]) by mail.netfilter.org (Postfix) with UTF8SMTPSA id 5E2086017E; Fri, 15 May 2026 02:10:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netfilter.org; s=2025; t=1778803853; bh=j8Wbl3oxghy8mdPyTOCBh7YBL4TdGkgunoQ6ubsNz1o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=c1x0L2VHp/5dMebpwNAUZIgauljTP0Tf1Bxp2bNknB+dYUEXw4+Z7sB7sAvcyH959 DsyvQt2h8HqKKv3Odf0Pg03ekwebk7fDT5kgY5xABd9n62pwpzxR8coUsq62pZ+rVO Xs6fgwJAVmghjgepfb4kmeLNKWaHZ4rQ9C4+sCRjMJqyaCvVQBgaI3wp7No4bSxr5p P3/6odJ9wfSb9HjDHcNoV9zCSi1f0EOQxcsRNDiD5spQccpaoSgFWlXWrrMjSW3s1E BZp8e2V9t1OadxDnNFttkGzbF7RnRpVdvjyA35aEYgS1R+4bgaftWCO+f60kT1eycy er0No+V5QvHvw== Date: Fri, 15 May 2026 02:10:50 +0200 From: Pablo Neira Ayuso To: Florian Westphal Cc: netfilter-devel@vger.kernel.org Subject: Re: [PATCH nf,v2] netfilter: conntrack: add dead flag to helpers Message-ID: References: <20260514143016.874811-1-pablo@netfilter.org> Precedence: bulk X-Mailing-List: netfilter-devel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: On Fri, May 15, 2026 at 01:55:08AM +0200, Florian Westphal wrote: > Pablo Neira Ayuso wrote: > > > The seqcnt can be pernet and it can be restricted to nfnetlink_queue. > > > > > > Any better idea? > > > > Maybe add a helper_id which is set at helper registration time. Then > > nf_conn_help stores this helper_id field. Unconfirmed conntrack on > > reinject use this helper_id to re-lookup the helper when reinjecting. > > This would force a slow path for unconfirmed conntracks, to > > re-validate if the helper is still there. > > > > cttimeout would need this too, a lookup to check if the timeout policy > > is still around. > > Hmm, maybe just re-use the nf_conntrack_ext_genid for this? > I think this unreg/rmmod isn't so frequent. nf_ct_iterate_destroy() is called for both cthelper/cttimeout, which already bumps nf_conntrack_ext_genid. Simply add the check from nf_reinject() path then? > Another alternative would be to give up on this design completely > and just grab module references :-) But that would not be enough for userspace ct helpers, right?