From: Patrick Steinhardt <ps@pks.im>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 0/8] setup: centralize object database creation
Date: Fri, 22 May 2026 08:03:05 +0200 [thread overview]
Message-ID: <ag_xmQO_BSzRsoAv@pks.im> (raw)
In-Reply-To: <xmqqqzn4xp0c.fsf@gitster.g>
On Fri, May 22, 2026 at 09:32:35AM +0900, Junio C Hamano wrote:
> Patrick Steinhardt <ps@pks.im> writes:
>
> > The series is built on top of aec3f58750 (Sync with 'maint', 2026-05-21)
> > with ps/setup-wo-the-repository at df69f40c34 (setup: stop using
> > `the_repository` in `init_db()`, 2026-05-19) merged into it.
>
> FWIW, this merge needs the following merge-fix squashed into it,
> for the topic to build standalone.
>
> commit ce350f62ceb26f3276ea3b7ad78b7f8cb4c35cf7
> Author: Junio C Hamano <gitster@pobox.com>
> Date: Wed May 13 12:20:29 2026 +0900
>
> merge-fix/ps/setup-wo-the-repository
>
> with js/objects-larger-than-4gb-on-windows
>
> diff --git a/t/helper/test-synthesize.c b/t/helper/test-synthesize.c
> index 1f28ecf0f2..3fa534fbdf 100644
> --- a/t/helper/test-synthesize.c
> +++ b/t/helper/test-synthesize.c
> @@ -506,7 +506,7 @@ static int cmd__synthesize__pack(int argc, const char **argv,
> OPT_END()
> };
>
> - setup_git_directory_gently(&non_git);
> + setup_git_directory_gently(the_repository, &non_git);
> repo = the_repository;
> algo = unsafe_hash_algo(repo->hash_algo);
Oh, right, I should have mentioned this. I do have the same fixup on top
of the merge, thanks.
Patrick
next prev parent reply other threads:[~2026-05-22 6:03 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-21 7:42 [PATCH 0/8] setup: centralize object database creation Patrick Steinhardt
2026-05-21 7:42 ` [PATCH 1/8] t0001: plug test gaps for git-init(1) with GIT_OBJECT_DIRECTORY Patrick Steinhardt
2026-05-21 16:49 ` Junio C Hamano
2026-05-21 17:51 ` Kristoffer Haugsbakk
2026-05-22 6:06 ` Patrick Steinhardt
2026-05-22 9:05 ` Kristoffer Haugsbakk
2026-05-21 7:42 ` [PATCH 2/8] setup: drop `setup_git_env()` Patrick Steinhardt
2026-05-21 7:42 ` [PATCH 3/8] setup: deduplicate logic to apply repository format Patrick Steinhardt
2026-05-21 7:42 ` [PATCH 4/8] repository: stop initializing the object database in `repo_set_gitdir()` Patrick Steinhardt
2026-05-21 7:42 ` [PATCH 5/8] setup: stop creating the object database in `setup_git_env()` Patrick Steinhardt
2026-05-21 7:42 ` [PATCH 6/8] setup: stop initializing object database without repository Patrick Steinhardt
2026-05-21 7:42 ` [PATCH 7/8] repository: stop reading loose object map twice on repo init Patrick Steinhardt
2026-05-21 7:42 ` [PATCH 8/8] setup: construct object database in `apply_repository_format()` Patrick Steinhardt
2026-05-21 17:59 ` Junio C Hamano
2026-05-22 6:03 ` Patrick Steinhardt
2026-05-22 0:32 ` [PATCH 0/8] setup: centralize object database creation Junio C Hamano
2026-05-22 6:03 ` Patrick Steinhardt [this message]
2026-05-26 5:56 ` [PATCH v2 " Patrick Steinhardt
2026-05-26 5:56 ` [PATCH v2 1/8] t0001: plug test gaps for git-init(1) with GIT_OBJECT_DIRECTORY Patrick Steinhardt
2026-06-03 12:22 ` Karthik Nayak
2026-05-26 5:56 ` [PATCH v2 2/8] setup: drop `setup_git_env()` Patrick Steinhardt
2026-05-26 5:56 ` [PATCH v2 3/8] setup: deduplicate logic to apply repository format Patrick Steinhardt
2026-06-03 12:43 ` Karthik Nayak
2026-06-04 6:08 ` Patrick Steinhardt
2026-05-26 5:56 ` [PATCH v2 4/8] repository: stop initializing the object database in `repo_set_gitdir()` Patrick Steinhardt
2026-06-03 12:49 ` Karthik Nayak
2026-06-04 6:08 ` Patrick Steinhardt
2026-05-26 5:57 ` [PATCH v2 5/8] setup: stop creating the object database in `setup_git_env()` Patrick Steinhardt
2026-06-03 12:57 ` Karthik Nayak
2026-05-26 5:57 ` [PATCH v2 6/8] setup: stop initializing object database without repository Patrick Steinhardt
2026-05-26 5:57 ` [PATCH v2 7/8] repository: stop reading loose object map twice on repo init Patrick Steinhardt
2026-05-26 5:57 ` [PATCH v2 8/8] setup: construct object database in `apply_repository_format()` Patrick Steinhardt
2026-06-03 13:04 ` [PATCH v2 0/8] setup: centralize object database creation Karthik Nayak
2026-06-04 6:08 ` Patrick Steinhardt
2026-06-04 7:46 ` [PATCH v3 " Patrick Steinhardt
2026-06-04 7:46 ` [PATCH v3 1/8] t0001: plug test gaps for git-init(1) with GIT_OBJECT_DIRECTORY Patrick Steinhardt
2026-06-04 7:46 ` [PATCH v3 2/8] setup: drop `setup_git_env()` Patrick Steinhardt
2026-06-04 7:46 ` [PATCH v3 3/8] setup: deduplicate logic to apply repository format Patrick Steinhardt
2026-06-04 7:46 ` [PATCH v3 4/8] repository: stop initializing the object database in `repo_set_gitdir()` Patrick Steinhardt
2026-06-04 7:46 ` [PATCH v3 5/8] setup: stop creating the object database in `setup_git_env()` Patrick Steinhardt
2026-06-04 7:46 ` [PATCH v3 6/8] setup: stop initializing object database without repository Patrick Steinhardt
2026-06-04 7:46 ` [PATCH v3 7/8] repository: stop reading loose object map twice on repo init Patrick Steinhardt
2026-06-04 7:46 ` [PATCH v3 8/8] setup: construct object database in `apply_repository_format()` Patrick Steinhardt
2026-06-05 14:16 ` [PATCH v3 0/8] setup: centralize object database creation Karthik Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ag_xmQO_BSzRsoAv@pks.im \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.