From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: thomas <thomas_lin@lecomputing.com>
Cc: rafael@kernel.org, lenb@kernel.org, hoan@os.amperecomputing.com,
linusw@kernel.org, brgl@kernel.org,
mika.westerberg@linux.intel.com, jsd@semihalf.com,
andi.shyti@kernel.org, broonie@kernel.org,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-spi@vger.kernel.org, lucas_hao@lecomputing.com,
puntar_liu@lecomputing.com, jihua_tao@lecomputing.com,
stan_xu@lecomputing.com, lumin_liu@lecomputing.com,
notics_zhang@lecomputing.com, braden_zhang@lecomputing.com,
harold_wu@lecomputing.com, will_zhang@lecomputing.com,
aurora_jiang@lecomputing.com, ryen_lin@lecomputing.com,
andy_jiang@lecomputing.com
Subject: Re: [PATCH 2/3] spi: dw-mmio: Add LECARC ACPI ID and init hook
Date: Fri, 15 May 2026 12:32:32 +0300 [thread overview]
Message-ID: <agboMC07Xojt5x2c@ashevche-desk.local> (raw)
In-Reply-To: <20260514024014.3376511-3-thomas_lin@lecomputing.com>
On Thu, May 14, 2026 at 10:40:11AM +0800, thomas wrote:
> Add ACPI ID "LECA0002" for LECARC SoCs. This ID requires a custom
> initialization function dw_spi_lecarc_init() that sets dws->dws.ip
> to DW_HSSI_ID.
>
> Also add corresponding ACPI description in acpi_apd.c.
...
> { "HISI02A3", APD_ADDR(hip08_lite_i2c_desc) },
> { "HISI0173", APD_ADDR(hip08_spi_desc) },
> { "NXP0001", APD_ADDR(nxp_i2c_desc) },
> + { "LECA0002", APD_ADDR(leca_spi_desc) },
Keep them ordered or close enough to be ordered. Id est in this case
locate it before NXP.
...
> +static int dw_spi_lecarc_init(struct platform_device *pdev,
> + struct dw_spi_mmio *dwsmmio)
> +{
> + dwsmmio->dws.ip = DW_HSSI_ID;
> +
> + return 0;
> +}
dw_spi_intel_init() is the same, why not reusing it?
Note, if uncomfortable with the name, make a patch to rename it to something like
dw_spi_hssi_no_dma_init().
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-05-15 9:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-14 2:40 [PATCH 0/3] Add LECARC ACPI IDs for DesignWare GPIO, SPI, I2C thomas
2026-05-14 2:40 ` [PATCH 1/3] gpio: dwapb: Add LECARC ACPI ID thomas
2026-05-14 2:40 ` [PATCH 2/3] spi: dw-mmio: Add LECARC ACPI ID and init hook thomas
2026-05-15 9:32 ` Andy Shevchenko [this message]
2026-05-14 2:40 ` [PATCH 3/3] i2c: designware: Add LECARC ACPI ID thomas
2026-05-15 9:38 ` Andy Shevchenko
2026-05-15 9:37 ` [PATCH 0/3] Add LECARC ACPI IDs for DesignWare GPIO, SPI, I2C Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=agboMC07Xojt5x2c@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=andi.shyti@kernel.org \
--cc=andy_jiang@lecomputing.com \
--cc=aurora_jiang@lecomputing.com \
--cc=braden_zhang@lecomputing.com \
--cc=brgl@kernel.org \
--cc=broonie@kernel.org \
--cc=harold_wu@lecomputing.com \
--cc=hoan@os.amperecomputing.com \
--cc=jihua_tao@lecomputing.com \
--cc=jsd@semihalf.com \
--cc=lenb@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=lucas_hao@lecomputing.com \
--cc=lumin_liu@lecomputing.com \
--cc=mika.westerberg@linux.intel.com \
--cc=notics_zhang@lecomputing.com \
--cc=puntar_liu@lecomputing.com \
--cc=rafael@kernel.org \
--cc=ryen_lin@lecomputing.com \
--cc=stan_xu@lecomputing.com \
--cc=thomas_lin@lecomputing.com \
--cc=will_zhang@lecomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.