All of lore.kernel.org
 help / color / mirror / Atom feed
From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: "Uwe Kleine-König (The Capable Hub)" <u.kleine-koenig@baylibre.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.com>,
	Oder Chiou <oder_chiou@realtek.com>,
	Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
	linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
	patches@opensource.cirrus.com,
	Markus Schneider-Pargmann <msp@baylibre.com>
Subject: Re: [PATCH v1 1/2] ASoC: Drop empty i2c remove callbacks
Date: Fri, 15 May 2026 11:13:20 +0100	[thread overview]
Message-ID: <agbxwOdgwX25RF9H@opensource.cirrus.com> (raw)
In-Reply-To: <3afd8230634dd68ac7c1885ee2b01da377349f89.1778692164.git.u.kleine-koenig@baylibre.com>

On Wed, May 13, 2026 at 07:23:03PM +0200, Uwe Kleine-König (The Capable Hub) wrote:
> A remove callback that does nothing has the same semantic (apart from a
> debug output) as no such callback at all as i2c_device_remove() just does:
> 
>         if (driver->remove) {
>                 dev_dbg(dev, "remove\n");
> 
>                 driver->remove(client);
>         }
> 
> Remove these useless callbacks.
> 
> While touching the driver structs, unify indention.
> 
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
> ---

Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>

Thanks,
Charles

  reply	other threads:[~2026-05-15 10:14 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-13 17:23 [PATCH v1 0/2] ASoC: Rework initialization of i2c_device_ids Uwe Kleine-König (The Capable Hub)
2026-05-13 17:23 ` [PATCH v1 1/2] ASoC: Drop empty i2c remove callbacks Uwe Kleine-König (The Capable Hub)
2026-05-15 10:13   ` Charles Keepax [this message]
2026-05-13 17:23 ` [PATCH v1 2/2] ASoC: Use named initializers for arrays of i2c_device_data Uwe Kleine-König (The Capable Hub)
2026-05-13 19:00   ` Krzysztof Kozlowski
2026-05-14  5:59     ` Krzysztof Kozlowski
2026-05-15 10:18   ` Charles Keepax

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=agbxwOdgwX25RF9H@opensource.cirrus.com \
    --to=ckeepax@opensource.cirrus.com \
    --cc=broonie@kernel.org \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=msp@baylibre.com \
    --cc=oder_chiou@realtek.com \
    --cc=patches@opensource.cirrus.com \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    --cc=u.kleine-koenig@baylibre.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.