All of lore.kernel.org
 help / color / mirror / Atom feed
From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: "Uwe Kleine-König (The Capable Hub)" <u.kleine-koenig@baylibre.com>
Cc: "Lee Jones" <lee@kernel.org>,
	"Markus Schneider-Pargmann" <msp@baylibre.com>,
	"Michael Hennerich" <michael.hennerich@analog.com>,
	"Chen-Yu Tsai" <wens@kernel.org>,
	"Marek Vasut" <marek.vasut+renesas@gmail.com>,
	"James Ogletree" <jogletre@opensource.cirrus.com>,
	"Fred Treven" <fred.treven@cirrus.com>,
	"Ben Bright" <ben.bright@cirrus.com>,
	"Support Opensource" <support.opensource@diasemi.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Richard Fitzgerald" <rf@opensource.cirrus.com>,
	"Chanwoo Choi" <cw00.choi@samsung.com>,
	"Krzysztof Kozlowski" <krzk@kernel.org>,
	"André Draszik" <andre.draszik@linaro.org>,
	"Aaro Koskinen" <aaro.koskinen@iki.fi>,
	"Andreas Kemnade" <andreas@kemnade.info>,
	"Kevin Hilman" <khilman@baylibre.com>,
	"Roger Quadros" <rogerq@kernel.org>,
	"Tony Lindgren" <tony@atomide.com>,
	"Samuel Kayode" <samkay014@gmail.com>,
	"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
	"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
	linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
	linux-sound@vger.kernel.org, linux-omap@vger.kernel.org,
	imx@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com,
	linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org
Subject: Re: [PATCH v1] mfd: Use named initializers for arrays of i2c_device_data
Date: Fri, 15 May 2026 11:20:51 +0100	[thread overview]
Message-ID: <agbzg9W+p2x391kW@opensource.cirrus.com> (raw)
In-Reply-To: <20260515095839.4005460-2-u.kleine-koenig@baylibre.com>

On Fri, May 15, 2026 at 11:58:39AM +0200, Uwe Kleine-König (The Capable Hub) wrote:
> While being less compact, using named initializers allows to more easily
> see which members of the structs are assigned which value without having
> to lookup the declaration of the struct. And it's also more robust
> against changes to the struct definition.
> 
> The mentioned robustness is relevant for a planned change to struct
> i2c_device_id that replaces .driver_data by an anonymous union.
> 
> While touching all these arrays, unify indention and usage of commas.
> 
> This patch doesn't modify the compiled arrays, only their representation
> in source form benefits. The former was confirmed with x86 and arm64
> builds.
> 
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
> ---

For the Wolfson/Cirrus bits:

Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>

Thanks,
Charles


  reply	other threads:[~2026-05-15 10:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-15  9:58 [PATCH v1] mfd: Use named initializers for arrays of i2c_device_data Uwe Kleine-König (The Capable Hub)
2026-05-15 10:20 ` Charles Keepax [this message]
2026-05-16  6:12 ` Uwe Kleine-König (The Capable Hub)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=agbzg9W+p2x391kW@opensource.cirrus.com \
    --to=ckeepax@opensource.cirrus.com \
    --cc=aaro.koskinen@iki.fi \
    --cc=alexandre.torgue@foss.st.com \
    --cc=andre.draszik@linaro.org \
    --cc=andreas@kemnade.info \
    --cc=andy@kernel.org \
    --cc=ben.bright@cirrus.com \
    --cc=cw00.choi@samsung.com \
    --cc=fred.treven@cirrus.com \
    --cc=imx@lists.linux.dev \
    --cc=jogletre@opensource.cirrus.com \
    --cc=khilman@baylibre.com \
    --cc=krzk@kernel.org \
    --cc=lee@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=marek.vasut+renesas@gmail.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=michael.hennerich@analog.com \
    --cc=msp@baylibre.com \
    --cc=rf@opensource.cirrus.com \
    --cc=rogerq@kernel.org \
    --cc=samkay014@gmail.com \
    --cc=support.opensource@diasemi.com \
    --cc=tony@atomide.com \
    --cc=u.kleine-koenig@baylibre.com \
    --cc=wens@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.